public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Josh Law <hlcj1234567@gmail.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Josh Law <objecting@objecting.org>
Subject: Re: [PATCH 4/4] arm64: kernel: Fix style in io.c macro
Date: Mon, 2 Mar 2026 14:51:14 +0000	[thread overview]
Message-ID: <aaWj4uIIiv_kwsFo@J2N7QTR9R3> (raw)
In-Reply-To: <20260301003407.2493781-4-objecting@objecting.org>

On Sun, Mar 01, 2026 at 12:34:07AM +0000, Josh Law wrote:
> Signed-off-by: Josh Law <objecting@objecting.org>
> ---
>  arch/arm64/kernel/io.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/kernel/io.c b/arch/arm64/kernel/io.c
> index fe86ada23c7d..ce27fa5d2e37 100644
> --- a/arch/arm64/kernel/io.c
> +++ b/arch/arm64/kernel/io.c
> @@ -17,10 +17,10 @@
>  #define memcpy_toio_aligned(to, from, count, bits)                        \
>  	({                                                                \
>  		volatile u##bits __iomem *_to = to;                       \
> -		const u##bits *_from = from;                              \
> +		const u##bits * _from = from;                             \
>  		size_t _count = count;                                    \
> -		const u##bits *_end_from = _from + ALIGN_DOWN(_count, 8); \
> -                                                                          \
> +		const u##bits * _end_from = _from + ALIGN_DOWN(_count, 8);\
> +\

There is no style violation here. There's no need to add a space between
'*' and the variable name.

Mark.

>  		for (; _from < _end_from; _from += 8, _to += 8)           \
>  			__const_memcpy_toio_aligned##bits(_to, _from, 8); \
>  		if ((_count % 8) >= 4) {                                  \
> -- 
> 2.43.0
> 
> 


  reply	other threads:[~2026-03-02 14:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-01  0:34 [PATCH 1/4] arm64: errata: Fix missing space after comma Josh Law
2026-03-01  0:34 ` [PATCH 2/4] arm64: fpsimd: make stack ctl_table const Josh Law
2026-03-01  0:34 ` [PATCH 3/4] arm64: kernel: Move const after static in get_kaslr_seed Josh Law
2026-03-01  0:34 ` [PATCH 4/4] arm64: kernel: Fix style in io.c macro Josh Law
2026-03-02 14:51   ` Mark Rutland [this message]
2026-03-02 15:45     ` Josh Law
2026-03-02 18:08       ` Mark Rutland
2026-03-02 18:21         ` Josh Law
2026-03-03 11:50 ` [PATCH 1/4] arm64: errata: Fix missing space after comma Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaWj4uIIiv_kwsFo@J2N7QTR9R3 \
    --to=mark.rutland@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=hlcj1234567@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=objecting@objecting.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox