From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D7EDC07548 for ; Wed, 15 Nov 2023 11:34:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9urCSiAwm/p7m+iO2tKqdm4aZRDb7fATs1JgN9Z1EyE=; b=K8fheJgGBIsoB/ ettOV+hnQ6W12IvKHOUI6V4qQUHg6jYdRV0QzB/dt1wWG953MdKzpy/XV9sBXhR1oWKE2PW8zQc9O ntwkAa5rvH04uHcWh35xO94fMleSmlreleC9CYSj1ADhICpnaPl0BJvy3XcG7I69ZGps4iGEoURhF R3ql++H+nR6xMNkQ0lO0O5ZKu9M0OsFE++KnsK+LNivcl7qDQ8h80lVoNN7pL1npMpuKl/L5v6CR5 CeaROraBA8Wo9+3FWGjeqq8xjQBP+G+T9B8/jdP6+Sbq6syqu8rT5QKmw0RtuhGo3Q3qolcuoRuCy zcQ+1sAFd5Xsprl/myLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r3E9q-000coH-0X; Wed, 15 Nov 2023 11:34:10 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r3E9m-000cjL-2O for linux-arm-kernel@lists.infradead.org; Wed, 15 Nov 2023 11:34:08 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id DD2B1B81977; Wed, 15 Nov 2023 11:34:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B64FC433C7; Wed, 15 Nov 2023 11:34:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700048043; bh=KVbTcjfjQMnTlb2mNWMfytXNOgiaVQnoIdzsAhE3uy8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ERSiHHhl8j2yVkH6aaroMxdbCJZPizh7yYkDyfB+l9YgtLpz3pbkB9FWIFVKOmXC/ 5IIFu4aAl78/OER5mGGNTYcANLLg/IaBhDeq+jTPLCHwxmpJY1HEdssTN7jSJU5++g Bzl5W2VzrwVaytmqYM9Cw3Oky8hxBhYlBzF0WMHJ/i8EuKCVy+FMVV7lx6qH3qb7Xr OMofWH1qPv1QcKSAheR7TVfXG7FAPBvLmr5ds7QSpXyG3BWOy3tkJmB6LfQGXLgeUf TzDFOsLL1RCcB1/v639WGSVQ7BPnxEQJMc0LklkIuP9B8YV4OlPTzHLF4Fmo+ku3FJ jrQ3pVlML7I5g== Message-ID: Date: Wed, 15 Nov 2023 13:33:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/6] usb: cdns3-ti: move reg writes from probe into an init_hw helper Content-Language: en-US To: =?UTF-8?Q?Th=C3=A9o_Lebrun?= , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Chen , Pawel Laszczak , Nishanth Menon , Vignesh Raghavendra , Tero Kristo Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20231113-j7200-usb-suspend-v1-0-ad1ee714835c@bootlin.com> <20231113-j7200-usb-suspend-v1-2-ad1ee714835c@bootlin.com> From: Roger Quadros In-Reply-To: <20231113-j7200-usb-suspend-v1-2-ad1ee714835c@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231115_033407_119698_DDFE5CCB X-CRM114-Status: GOOD ( 23.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgVGjDqW8sCgpPbiAxMy8xMS8yMDIzIDE2OjI2LCBUaMOpbyBMZWJydW4gd3JvdGU6Cj4gVGhl IGhhcmR3YXJlIGluaXRpYWxpc2F0aW9uIHJlZ2lzdGVyIHdyaXRlIHNlcXVlbmNlIGlzIG9ubHkg dXNlZCBhdAo+IHByb2JlLiBUbyBzdXBwb3J0IHN1c3BlbmQvcmVzdW1lIHdpdGggYSBjb250cm9s bGVyIGxvc2luZyBwb3dlciwgd2UKPiBtdXN0IHJlZG8gdGhpcyBzZXF1ZW5jZSBvZiB3cml0ZXMu Cj4gCj4gRXh0cmFjdCB0aGUgcmVnaXN0ZXIgd3JpdGUgc2VxdWVuY2UgdG8gYSBuZXcgY2Ruc190 aV9pbml0X2h3IGZ1bmN0aW9uIHRvCj4gcmV1c2UgaXQgbGF0ZXIgZG93biB0aGUgcm9hZCwgYXQg cmVzdW1lLgo+IAo+IFdlIGtlZXAgdGhlIGRldmljZXRyZWUtcGFyc2luZyBhc3BlY3Qgb2YgdGhl IHNlcXVlbmNlIGluIHByb2JlICYgYWRkIGEKPiBuZXcgZmllbGQgaW4gdGhlIHByaXZhdGUgc3Ry dWN0IHRvIHJlbWVtYmVyIHRoZSBVU0IyIHJlZmNsayByYXRlIGNvZGUKPiBjb21wdXRhdGlvbiBy ZXN1bHQuCj4gCj4gU2lnbmVkLW9mZi1ieTogVGjDqW8gTGVicnVuIDx0aGVvLmxlYnJ1bkBib290 bGluLmNvbT4KPiAtLS0KPiAgZHJpdmVycy91c2IvY2RuczMvY2RuczMtdGkuYyB8IDc2ICsrKysr KysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2Vk LCA0MSBpbnNlcnRpb25zKCspLCAzNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy91c2IvY2RuczMvY2RuczMtdGkuYyBiL2RyaXZlcnMvdXNiL2NkbnMzL2NkbnMzLXRpLmMK PiBpbmRleCA1OTQ1YzRiMWUxMWYuLmMzMzFiY2QyZmFlYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L3VzYi9jZG5zMy9jZG5zMy10aS5jCj4gKysrIGIvZHJpdmVycy91c2IvY2RuczMvY2RuczMtdGku Ywo+IEBAIC01Nyw2ICs1Nyw3IEBAIHN0cnVjdCBjZG5zX3RpIHsKPiAgCXVuc2lnbmVkIHZidXNf ZGl2aWRlcjoxOwo+ICAJc3RydWN0IGNsayAqdXNiMl9yZWZjbGs7Cj4gIAlzdHJ1Y3QgY2xrICps cG1fY2xrOwo+ICsJaW50IHVzYjJfcmVmY2xrX3JhdGVfY29kZTsKPiAgfTsKPiAgCj4gIHN0YXRp YyBjb25zdCBpbnQgY2Ruc190aV9yYXRlX3RhYmxlW10gPSB7CS8qIGluIEtIWiAqLwo+IEBAIC04 NSwxNSArODYsNTAgQEAgc3RhdGljIGlubGluZSB2b2lkIGNkbnNfdGlfd3JpdGVsKHN0cnVjdCBj ZG5zX3RpICpkYXRhLCB1MzIgb2Zmc2V0LCB1MzIgdmFsdWUpCj4gIAl3cml0ZWwodmFsdWUsIGRh dGEtPnVzYnNzICsgb2Zmc2V0KTsKPiAgfQo+ICAKPiArc3RhdGljIHZvaWQgY2Ruc190aV9pbml0 X2h3KHN0cnVjdCBjZG5zX3RpICpkYXRhKQo+ICt7Cj4gKwl1MzIgcmVnOwo+ICsKPiArCS8qIGFz c2VydCBSRVNFVCAqLwo+ICsJcmVnID0gY2Ruc190aV9yZWFkbChkYXRhLCBVU0JTU19XMSk7Cj4g KwlyZWcgJj0gflVTQlNTX1cxX1BXUlVQX1JTVDsKPiArCWNkbnNfdGlfd3JpdGVsKGRhdGEsIFVT QlNTX1cxLCByZWcpOwo+ICsKPiArCS8qIHNldCBzdGF0aWMgY29uZmlnICovCj4gKwlyZWcgPSBj ZG5zX3RpX3JlYWRsKGRhdGEsIFVTQlNTX1NUQVRJQ19DT05GSUcpOwo+ICsJcmVnICY9IH5VU0JT UzFfU1RBVElDX1BMTF9SRUZfU0VMX01BU0s7Cj4gKwlyZWcgfD0gZGF0YS0+dXNiMl9yZWZjbGtf cmF0ZV9jb2RlIDw8IFVTQlNTMV9TVEFUSUNfUExMX1JFRl9TRUxfU0hJRlQ7Cj4gKwo+ICsJcmVn ICY9IH5VU0JTUzFfU1RBVElDX1ZCVVNfU0VMX01BU0s7Cj4gKwlpZiAoZGF0YS0+dmJ1c19kaXZp ZGVyKQo+ICsJCXJlZyB8PSAxIDw8IFVTQlNTMV9TVEFUSUNfVkJVU19TRUxfU0hJRlQ7Cj4gKwo+ ICsJY2Ruc190aV93cml0ZWwoZGF0YSwgVVNCU1NfU1RBVElDX0NPTkZJRywgcmVnKTsKPiArCXJl ZyA9IGNkbnNfdGlfcmVhZGwoZGF0YSwgVVNCU1NfU1RBVElDX0NPTkZJRyk7Cj4gKwo+ICsJLyog c2V0IFVTQjJfT05MWSBtb2RlIGlmIHJlcXVlc3RlZCAqLwo+ICsJcmVnID0gY2Ruc190aV9yZWFk bChkYXRhLCBVU0JTU19XMSk7Cj4gKwlpZiAoZGF0YS0+dXNiMl9vbmx5KQo+ICsJCXJlZyB8PSBV U0JTU19XMV9VU0IyX09OTFk7Cj4gKwo+ICsJLyogc2V0IGRlZmF1bHQgbW9kZXN0cmFwICovCj4g KwlyZWcgfD0gVVNCU1NfVzFfTU9ERVNUUkFQX1NFTDsKPiArCXJlZyAmPSB+VVNCU1NfVzFfTU9E RVNUUkFQX01BU0s7Cj4gKwlyZWcgfD0gVVNCU1NfTU9ERVNUUkFQX01PREVfTk9ORSA8PCBVU0JT U19XMV9NT0RFU1RSQVBfU0hJRlQ7Cj4gKwljZG5zX3RpX3dyaXRlbChkYXRhLCBVU0JTU19XMSwg cmVnKTsKPiArCj4gKwkvKiBkZS1hc3NlcnQgUkVTRVQgKi8KPiArCXJlZyB8PSBVU0JTU19XMV9Q V1JVUF9SU1Q7Cj4gKwljZG5zX3RpX3dyaXRlbChkYXRhLCBVU0JTU19XMSwgcmVnKTsKPiArfQo+ ICsKPiAgc3RhdGljIGludCBjZG5zX3RpX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBk ZXYpCj4gIHsKPiAgCXN0cnVjdCBkZXZpY2UgKmRldiA9ICZwZGV2LT5kZXY7Cj4gIAlzdHJ1Y3Qg ZGV2aWNlX25vZGUgKm5vZGUgPSBwZGV2LT5kZXYub2Zfbm9kZTsKPiAgCXN0cnVjdCBjZG5zX3Rp ICpkYXRhOwo+IC0JaW50IGVycm9yOwo+IC0JdTMyIHJlZzsKPiAtCWludCByYXRlX2NvZGUsIGk7 Cj4gIAl1bnNpZ25lZCBsb25nIHJhdGU7Cj4gKwlpbnQgZXJyb3IsIGk7CgpTaG91bGQgd2UgbGVh dmUgcmF0ZV9jb2RlIGFuZCBnZXQgcmlkIG9mIGk/Cgo+ICAKPiAgCWRhdGEgPSBkZXZtX2t6YWxs b2MoZGV2LCBzaXplb2YoKmRhdGEpLCBHRlBfS0VSTkVMKTsKPiAgCWlmICghZGF0YSkKPiBAQCAt MTMzLDggKzE2OSw2IEBAIHN0YXRpYyBpbnQgY2Ruc190aV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1f ZGV2aWNlICpwZGV2KQo+ICAJCXJldHVybiAtRUlOVkFMOwo+ICAJfQo+ICAKPiAtCXJhdGVfY29k ZSA9IGk7Cj4gLQo+ICAJcG1fcnVudGltZV9lbmFibGUoZGV2KTsKPiAgCWVycm9yID0gcG1fcnVu dGltZV9nZXRfc3luYyhkZXYpPiAgCWlmIChlcnJvciA8IDApIHsKPiBAQCAtMTQyLDM5ICsxNzYs MTEgQEAgc3RhdGljIGludCBjZG5zX3RpX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBk ZXYpCj4gIAkJZ290byBlcnI7Cj4gIAl9Cj4gIAo+IC0JLyogYXNzZXJ0IFJFU0VUICovCj4gLQly ZWcgPSBjZG5zX3RpX3JlYWRsKGRhdGEsIFVTQlNTX1cxKTsKPiAtCXJlZyAmPSB+VVNCU1NfVzFf UFdSVVBfUlNUOwo+IC0JY2Ruc190aV93cml0ZWwoZGF0YSwgVVNCU1NfVzEsIHJlZyk7Cj4gLQo+ IC0JLyogc2V0IHN0YXRpYyBjb25maWcgKi8KPiAtCXJlZyA9IGNkbnNfdGlfcmVhZGwoZGF0YSwg VVNCU1NfU1RBVElDX0NPTkZJRyk7Cj4gLQlyZWcgJj0gflVTQlNTMV9TVEFUSUNfUExMX1JFRl9T RUxfTUFTSzsKPiAtCXJlZyB8PSByYXRlX2NvZGUgPDwgVVNCU1MxX1NUQVRJQ19QTExfUkVGX1NF TF9TSElGVDsKPiAtCj4gLQlyZWcgJj0gflVTQlNTMV9TVEFUSUNfVkJVU19TRUxfTUFTSzsKPiAg CWRhdGEtPnZidXNfZGl2aWRlciA9IGRldmljZV9wcm9wZXJ0eV9yZWFkX2Jvb2woZGV2LCAidGks dmJ1cy1kaXZpZGVyIik7Cj4gLQlpZiAoZGF0YS0+dmJ1c19kaXZpZGVyKQo+IC0JCXJlZyB8PSAx IDw8IFVTQlNTMV9TVEFUSUNfVkJVU19TRUxfU0hJRlQ7Cj4gLQo+IC0JY2Ruc190aV93cml0ZWwo ZGF0YSwgVVNCU1NfU1RBVElDX0NPTkZJRywgcmVnKTsKPiAtCXJlZyA9IGNkbnNfdGlfcmVhZGwo ZGF0YSwgVVNCU1NfU1RBVElDX0NPTkZJRyk7Cj4gLQo+IC0JLyogc2V0IFVTQjJfT05MWSBtb2Rl IGlmIHJlcXVlc3RlZCAqLwo+IC0JcmVnID0gY2Ruc190aV9yZWFkbChkYXRhLCBVU0JTU19XMSk7 Cj4gIAlkYXRhLT51c2IyX29ubHkgPSBkZXZpY2VfcHJvcGVydHlfcmVhZF9ib29sKGRldiwgInRp LHVzYjItb25seSIpOwo+IC0JaWYgKGRhdGEtPnVzYjJfb25seSkKPiAtCQlyZWcgfD0gVVNCU1Nf VzFfVVNCMl9PTkxZOwo+IC0KPiAtCS8qIHNldCBkZWZhdWx0IG1vZGVzdHJhcCAqLwo+IC0JcmVn IHw9IFVTQlNTX1cxX01PREVTVFJBUF9TRUw7Cj4gLQlyZWcgJj0gflVTQlNTX1cxX01PREVTVFJB UF9NQVNLOwo+IC0JcmVnIHw9IFVTQlNTX01PREVTVFJBUF9NT0RFX05PTkUgPDwgVVNCU1NfVzFf TU9ERVNUUkFQX1NISUZUOwo+IC0JY2Ruc190aV93cml0ZWwoZGF0YSwgVVNCU1NfVzEsIHJlZyk7 Cj4gKwlkYXRhLT51c2IyX3JlZmNsa19yYXRlX2NvZGUgPSBpOwoKYmVjYXVzZSAnaScgc2VlbXMg dGVtcG9yYXJ5LgoKPiAgCj4gLQkvKiBkZS1hc3NlcnQgUkVTRVQgKi8KPiAtCXJlZyB8PSBVU0JT U19XMV9QV1JVUF9SU1Q7Cj4gLQljZG5zX3RpX3dyaXRlbChkYXRhLCBVU0JTU19XMSwgcmVnKTsK PiArCWNkbnNfdGlfaW5pdF9odyhkYXRhKTsKPiAgCj4gIAllcnJvciA9IG9mX3BsYXRmb3JtX3Bv cHVsYXRlKG5vZGUsIE5VTEwsIE5VTEwsIGRldik7Cj4gIAlpZiAoZXJyb3IpIHsKPiAKCi0tIApj aGVlcnMsCi1yb2dlcgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo=