From: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
To: Chen Ni <nichen@iscas.ac.cn>
Cc: daniel.lezcano@linaro.org, tglx@kernel.org, wens@kernel.org,
jernej.skrabec@gmail.com, samuel@sholland.org,
p.zabel@pengutronix.de, mripard@kernel.org, mans@mansr.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH] clocksource/drivers/sun5i: Handle error returns from devm_reset_control_get_optional_exclusive()
Date: Wed, 4 Mar 2026 20:35:42 +0100 [thread overview]
Message-ID: <aaiJjrtVDJyFrpfw@mai.linaro.org> (raw)
In-Reply-To: <20260205084037.3661261-1-nichen@iscas.ac.cn>
On Thu, Feb 05, 2026 at 04:40:37PM +0800, Chen Ni wrote:
> The devm_reset_control_get_optional_exclusive() function may return an
> ERR_PTR in case of genuine reset control acquisition errors, not just
> NULL which indicates the legitimate absence of an optional reset.
>
> Add an IS_ERR() check after the call in sun5i_timer_probe(). On error,
> return the error code to ensure proper failure handling rather than
> proceeding with invalid pointers.
>
> Fixes: 7e5bac610d2f ("clocksource/drivers/sun5i: Convert to platform device driver")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
Applied, thanks
prev parent reply other threads:[~2026-03-04 19:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 8:40 [PATCH] clocksource/drivers/sun5i: Handle error returns from devm_reset_control_get_optional_exclusive() Chen Ni
2026-02-24 14:51 ` Chen-Yu Tsai
2026-03-04 19:35 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaiJjrtVDJyFrpfw@mai.linaro.org \
--to=daniel.lezcano@oss.qualcomm.com \
--cc=daniel.lezcano@linaro.org \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mans@mansr.com \
--cc=mripard@kernel.org \
--cc=nichen@iscas.ac.cn \
--cc=p.zabel@pengutronix.de \
--cc=samuel@sholland.org \
--cc=tglx@kernel.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox