From: Dan Carpenter <dan.carpenter@linaro.org>
To: Chen Ni <nichen@iscas.ac.cn>
Cc: sudeep.holla@kernel.org, cristian.marussi@arm.com,
sumit.garg@oss.qualcomm.com, jens.wiklander@linaro.org,
arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] firmware: arm_scmi: optee: Check return value of tee_shm_get_va()
Date: Thu, 5 Mar 2026 12:19:38 +0300 [thread overview]
Message-ID: <aalKqp_VPJjHxcQg@stanley.mountain> (raw)
In-Reply-To: <20260305071533.930896-1-nichen@iscas.ac.cn>
On Thu, Mar 05, 2026 at 03:15:33PM +0800, Chen Ni wrote:
> The function tee_shm_get_va() can return an error pointer if the shared
> memory is not properly mapped or if the offset is invalid.
The memory is properly mapped though. We just allocated it on the
previous line. The offset is zero and the size is
SCMI_SHMEM_MAX_PAYLOAD_SIZE so that's fine too.
There is no need for an IS_ERR() check.
regards,
dan carpenter
prev parent reply other threads:[~2026-03-05 9:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 7:15 [PATCH] firmware: arm_scmi: optee: Check return value of tee_shm_get_va() Chen Ni
2026-03-05 9:19 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aalKqp_VPJjHxcQg@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=arm-scmi@vger.kernel.org \
--cc=cristian.marussi@arm.com \
--cc=jens.wiklander@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=nichen@iscas.ac.cn \
--cc=sudeep.holla@kernel.org \
--cc=sumit.garg@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox