From: Sean Christopherson <seanjc@google.com>
To: David Matlack <dmatlack@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Ackerley Tng <ackerleytng@google.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Andrew Jones <ajones@ventanamicro.com>,
Anup Patel <anup@brainfault.org>,
Atish Patra <atish.patra@linux.dev>,
Bibo Mao <maobibo@loongson.cn>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Colin Ian King <colin.i.king@gmail.com>,
David Hildenbrand <david@kernel.org>,
Fuad Tabba <tabba@google.com>,
Huacai Chen <chenhuacai@kernel.org>,
James Houghton <jthoughton@google.com>,
Janosch Frank <frankja@linux.ibm.com>,
Joey Gouly <joey.gouly@arm.com>,
kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org,
kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-riscv@lists.infradead.org, Lisa Wang <wyihan@google.com>,
loongarch@lists.linux.dev, Marc Zyngier <maz@kernel.org>,
Maxim Levitsky <mlevitsk@redhat.com>,
Nutty Liu <nutty.liu@hotmail.com>,
Oliver Upton <oupton@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <pjw@kernel.org>,
"Pratik R. Sampat" <prsampat@amd.com>,
Rahul Kumar <rk0006818@gmail.com>, Shuah Khan <shuah@kernel.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Tianrui Zhao <zhaotianrui@loongson.cn>,
Wu Fei <wu.fei9@sanechips.com.cn>,
Yosry Ahmed <yosry.ahmed@linux.dev>,
Zenghui Yu <yuzenghui@huawei.com>
Subject: Re: [PATCH v2 04/10] KVM: selftests: Use u64 instead of uint64_t
Date: Thu, 5 Mar 2026 09:19:34 -0800 [thread overview]
Message-ID: <aam7JsCyQ5Oacvl5@google.com> (raw)
In-Reply-To: <20260220004223.4168331-5-dmatlack@google.com>
On Fri, Feb 20, 2026, David Matlack wrote:
> -static uint64_t pread_uint64(int fd, const char *filename, uint64_t index)
> +static u64 pread_uint64(int fd, const char *filename, u64 index)
I think it's also worth converting the function to pread_u64().
> {
> - uint64_t value;
> + u64 value;
> off_t offset = index * sizeof(value);
>
> TEST_ASSERT(pread(fd, &value, sizeof(value), offset) == sizeof(value),
next prev parent reply other threads:[~2026-03-05 17:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 0:42 [PATCH v2 00/10] KVM: selftests: Use kernel-style integer and g[vp]a_t types David Matlack
2026-02-20 0:42 ` [PATCH v2 01/10] KVM: selftests: Use gva_t instead of vm_vaddr_t David Matlack
2026-02-20 0:42 ` [PATCH v2 02/10] KVM: selftests: Use gpa_t instead of vm_paddr_t David Matlack
2026-02-20 0:42 ` [PATCH v2 03/10] KVM: selftests: Use gpa_t for GPAs in Hyper-V selftests David Matlack
2026-02-20 0:42 ` [PATCH v2 05/10] KVM: selftests: Use s64 instead of int64_t David Matlack
2026-02-20 0:42 ` [PATCH v2 07/10] KVM: selftests: Use s32 instead of int32_t David Matlack
2026-02-20 0:42 ` [PATCH v2 08/10] KVM: selftests: Use u16 instead of uint16_t David Matlack
2026-02-20 0:42 ` [PATCH v2 09/10] KVM: selftests: Use s16 instead of int16_t David Matlack
2026-02-20 0:42 ` [PATCH v2 10/10] KVM: selftests: Use u8 instead of uint8_t David Matlack
[not found] ` <20260220004223.4168331-5-dmatlack@google.com>
2026-03-05 17:19 ` Sean Christopherson [this message]
2026-03-05 17:26 ` [PATCH v2 04/10] KVM: selftests: Use u64 instead of uint64_t David Matlack
2026-03-05 17:22 ` [PATCH v2 00/10] KVM: selftests: Use kernel-style integer and g[vp]a_t types Sean Christopherson
2026-03-05 17:26 ` David Matlack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aam7JsCyQ5Oacvl5@google.com \
--to=seanjc@google.com \
--cc=ackerleytng@google.com \
--cc=ajones@ventanamicro.com \
--cc=alex@ghiti.fr \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@linux.dev \
--cc=borntraeger@linux.ibm.com \
--cc=chenhuacai@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=david@kernel.org \
--cc=dmatlack@google.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=joey.gouly@arm.com \
--cc=jthoughton@google.com \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=loongarch@lists.linux.dev \
--cc=maobibo@loongson.cn \
--cc=maz@kernel.org \
--cc=mlevitsk@redhat.com \
--cc=nutty.liu@hotmail.com \
--cc=oupton@kernel.org \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=pjw@kernel.org \
--cc=prsampat@amd.com \
--cc=rk0006818@gmail.com \
--cc=shuah@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=tabba@google.com \
--cc=wu.fei9@sanechips.com.cn \
--cc=wyihan@google.com \
--cc=yosry.ahmed@linux.dev \
--cc=yuzenghui@huawei.com \
--cc=zhaotianrui@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox