From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 760D6F3D33C for ; Thu, 5 Mar 2026 17:19:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To:From: Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jvL7QI7vtAV/elV7wuwJjb0ouQ5MS/0W571Ri2ejdh8=; b=OBEXyD2n4f30rfDdCmANFYTItu 5uhLxgpHad6MPGJgAsxceEp5zSTH04MHrg2N1Le/CZpb1ZGyOAl4Yv89/Kie/SRLUyZozZrRVEH8g iP8dFBlrm4EbZxv3+qGmDw8pK03W1pkWmZeRRjMZ4Mv8XB/jJcvrj6oWwxvMdWu0J3SIIXKo2i1Yk ynk+KI5v28B5IC5pq23n88JGseCeH099/LMQtMntqj6vFdRMv/B8JUcpXXafy4w3wRg5YdIRJl2yj zsRF+qN17PN+76NbXwcHriWm9cGv4ROw4R+P5VRbSZTmMt3hErrPWcRjiQVGbjCAjXLp4s+EfBZAy oPRPoAHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vyCMO-00000002HH1-1GIP; Thu, 05 Mar 2026 17:19:40 +0000 Received: from mail-pf1-x44a.google.com ([2607:f8b0:4864:20::44a]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vyCML-00000002HFE-2pse for linux-arm-kernel@lists.infradead.org; Thu, 05 Mar 2026 17:19:38 +0000 Received: by mail-pf1-x44a.google.com with SMTP id d2e1a72fcca58-82984468f85so594551b3a.1 for ; Thu, 05 Mar 2026 09:19:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772731176; x=1773335976; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=jvL7QI7vtAV/elV7wuwJjb0ouQ5MS/0W571Ri2ejdh8=; b=U+/NFEkOWE9jZ0bM1oY079L2ahCo07sLfRKa8o+CYugD3fwHz4jLi3hosu/GwioO3z Cu0Rf+oZdtDq0iaagNRnQCNw6ayYeSXbIG02mosII2OUI3lMgZkf18a/smDNNbiD1uxn Zhr0v5UOjMRzgo/Fn7yuHbdP0+hREaXskn5oFdc7an2+gW633W5jba3qXPuKW0YEUfWb ZEu+r3KDnjJOC44Aq9op2OvP5ADMCWhmfjcXdz2/JBIVvA6MSuHF5MCUnxAnVVpM4JAg b0KM5NgRBO690pF6g/E6LH7gczk4VcwiSRnDVnwTcRuBK0DM9M6OtU7oH80nzutnjeZ1 H7vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772731176; x=1773335976; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jvL7QI7vtAV/elV7wuwJjb0ouQ5MS/0W571Ri2ejdh8=; b=WM1/ZcphQPENxfNJO0H3T4r6ToEOoInSJLPNn8jXYesgWE3P6/xDEUWm/asA9doDJi DcSa2FoCroIF8mJTMWp0WXs6RmclUAqn9ir4h5OxYtyJ2pFVSZ3Rd2hh45kEfRTXr2V2 XosJQyoKVM6b57SS7xsjPMKHC0CI1HvftkqR5cGnA2tba3lHfy0GcASLdqEtycfWmNbm FjUuFnc6egWgXxl3qaGr9P/Eb3ogQymVagGnn2BOYcfOGtRJVSxExKfSwhZigvpLjCV1 RvdyhRR9kwbsgqNMv8I8S30HJfXAFEnSnKpmNua6L9zAtugiPIxBFSPeQjRihQukVgUs rBbA== X-Forwarded-Encrypted: i=1; AJvYcCWtP6u6XnMElwHha00s8hHrREZVzWEh6YnF9q2gC1WdYfH7ZaBzNjZ2fQ/CXYHFViSKUEN1Aab2OzDQLWN90ivC@lists.infradead.org X-Gm-Message-State: AOJu0YxmTpTC9VuvkRPH3pEEp6OFKT/Fdv3U2VPvjMJZQ09/8oBnqBqo pYZ5YVeQCGMWeCmfSYE0p/5xmpq+2KZnUKKaSpmsmq9pbtob6Vt+0l9szYXYUkPa5LU/7Tp7jan dAv7kcg== X-Received: from pfcp25.prod.google.com ([2002:a05:6a00:a259:b0:829:808f:cb8d]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:4295:b0:81b:d5d9:a83a with SMTP id d2e1a72fcca58-8299ae60809mr419972b3a.61.1772731175885; Thu, 05 Mar 2026 09:19:35 -0800 (PST) Date: Thu, 5 Mar 2026 09:19:34 -0800 In-Reply-To: <20260220004223.4168331-5-dmatlack@google.com> Mime-Version: 1.0 References: <20260220004223.4168331-1-dmatlack@google.com> <20260220004223.4168331-5-dmatlack@google.com> Message-ID: Subject: Re: [PATCH v2 04/10] KVM: selftests: Use u64 instead of uint64_t From: Sean Christopherson To: David Matlack Cc: Paolo Bonzini , Ackerley Tng , Albert Ou , Alexandre Ghiti , Andrew Jones , Anup Patel , Atish Patra , Bibo Mao , Christian Borntraeger , Claudio Imbrenda , Colin Ian King , David Hildenbrand , Fuad Tabba , Huacai Chen , James Houghton , Janosch Frank , Joey Gouly , kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org, Lisa Wang , loongarch@lists.linux.dev, Marc Zyngier , Maxim Levitsky , Nutty Liu , Oliver Upton , Palmer Dabbelt , Paul Walmsley , "Pratik R. Sampat" , Rahul Kumar , Shuah Khan , Suzuki K Poulose , Tianrui Zhao , Wu Fei , Yosry Ahmed , Zenghui Yu Content-Type: text/plain; charset="us-ascii" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260305_091937_717327_69A9E560 X-CRM114-Status: UNSURE ( 8.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 20, 2026, David Matlack wrote: > -static uint64_t pread_uint64(int fd, const char *filename, uint64_t index) > +static u64 pread_uint64(int fd, const char *filename, u64 index) I think it's also worth converting the function to pread_u64(). > { > - uint64_t value; > + u64 value; > off_t offset = index * sizeof(value); > > TEST_ASSERT(pread(fd, &value, sizeof(value), offset) == sizeof(value),