From: Lukasz Luba <lukasz.luba@arm.com>
To: Cristian Marussi <cristian.marussi@arm.com>,
Sibi Sankar <quic_sibis@quicinc.com>
Cc: sudeep.holla@arm.com, rafael@kernel.org, viresh.kumar@linaro.org,
morten.rasmussen@arm.com, dietmar.eggemann@arm.com,
pierre.gondois@arm.com, vincent.guittot@linaro.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_mdtipton@quicinc.com,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH V5 1/1] cpufreq: scmi: Register for limit change notifications
Date: Wed, 30 Oct 2024 09:55:38 +0000 [thread overview]
Message-ID: <ab36709d-a181-4621-a8e5-0ef38b80186b@arm.com> (raw)
In-Reply-To: <ZyH9HvKmYjlJC8_x@pluto>
On 10/30/24 09:32, Cristian Marussi wrote:
> On Tue, Jun 04, 2024 at 12:56:54AM +0530, Sibi Sankar wrote:
>> Register for limit change notifications if supported and use the throttled
>> frequency from the notification to apply HW pressure.
>>
>
> This sort of got lost in mbox...apologies.
>
> As discussed offlist, the issue with cpufreq and multiple SCMI instances
> remains BUT it will be solved later on with a different approach, so
> as of now this LGTM.
>
> Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Thank you Cristian for re-visiting this.
That code also LGTM and fits into my other construction built on top
of it [1] [2]. I had a talk with Rafael below that [1] about this
subject patch.
Feel free to add:
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
[1]
https://lore.kernel.org/lkml/20241029094452.495439-1-lukasz.luba@arm.com/
[2]
https://lore.kernel.org/lkml/20240403162315.1458337-1-lukasz.luba@arm.com/
prev parent reply other threads:[~2024-10-30 9:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 19:26 [PATCH V5 0/1] firmware: arm_scmi: Register and handle limits change notification Sibi Sankar
2024-06-03 19:26 ` [PATCH V5 1/1] cpufreq: scmi: Register for limit change notifications Sibi Sankar
2024-10-16 23:45 ` Mike Tipton
2024-10-30 9:32 ` Cristian Marussi
2024-10-30 9:55 ` Lukasz Luba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab36709d-a181-4621-a8e5-0ef38b80186b@arm.com \
--to=lukasz.luba@arm.com \
--cc=cristian.marussi@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=pierre.gondois@arm.com \
--cc=quic_mdtipton@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox