Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@nxp.com>
To: Ernest Van Hoecke <ernestvanhoecke@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Ernest Van Hoecke <ernest.vanhoecke@toradex.com>,
	Emanuele Ghidoli <emanuele.ghidoli@toradex.com>,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/6] arm64: dts: freescale: imx95-verdin: Add Ivy carrier board
Date: Tue, 10 Mar 2026 10:59:58 -0400	[thread overview]
Message-ID: <abAx3_5SHKmeZTt0@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <xghf5wajmzkz3vhi565q5fmclrelczobbvywg7z2tj3gj2rzlq@idn3vyhxxsde>

On Tue, Mar 10, 2026 at 11:06:08AM +0100, Ernest Van Hoecke wrote:
> On Thu, Mar 05, 2026 at 06:24:32PM +0100, Ernest Van Hoecke wrote:
>
> Hello Krzysztof,
> Hello Frank,
>
> Thanks for your review so far. I noticed that the node order here is
> also wrong and not alphanumeric on node name. I will fix some of them,
> but for some it could mean that for example, 'ain2_voltage_unmanaged:
> voltage-divider-ain2' is far from 'ain2-voltage', which is unfortunate
> since they are related. Together with the the current-sense and
> mux-controller nodes they form something of a logical group and it seems
> undesirable to have them be separated by a long 'leds' node and the
> regulator nodes.
>
> Would it be acceptable to keep the "group" together and sort
> alphanumerically within it, or is it preferred to sort all nodes
> alphanumerically?

Previous happen insert duplicated nodes many times because try "group"
function togeter or random order.

It is hard to define "group".  Use alphanumerically is easily to folllow
and it can use tools to check.

Now I take over freescale dts tree. there are over 500 dts under arm64
freescale. I want to use simple and straingforward rule to manage it.

ref use label (free nameing), you can use nice label name to keep good
orders.

Frank

>
> Kind regards,
> Ernest


  reply	other threads:[~2026-03-10 15:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-05 17:24 [PATCH 0/6] arm64: dts: freescale: add Verdin iMX95 Ernest Van Hoecke
2026-03-05 17:24 ` [PATCH 1/6] dt-bindings: arm: fsl: " Ernest Van Hoecke
2026-03-06  8:33   ` Krzysztof Kozlowski
2026-03-05 17:24 ` [PATCH 2/6] arm64: dts: freescale: Add Verdin iMX95 support Ernest Van Hoecke
2026-03-05 17:51   ` Frank Li
2026-03-05 17:24 ` [PATCH 3/6] arm64: dts: freescale: imx95-verdin: Add Dahlia carrier board Ernest Van Hoecke
2026-03-05 17:24 ` [PATCH 4/6] arm64: dts: freescale: imx95-verdin: Add Ivy " Ernest Van Hoecke
2026-03-10 10:06   ` Ernest Van Hoecke
2026-03-10 14:59     ` Frank Li [this message]
2026-03-05 17:24 ` [PATCH 5/6] arm64: dts: freescale: imx95-verdin: Add Mallow " Ernest Van Hoecke
2026-03-05 17:24 ` [PATCH 6/6] arm64: dts: freescale: imx95-verdin: Add Yavia " Ernest Van Hoecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abAx3_5SHKmeZTt0@lizhi-Precision-Tower-5810 \
    --to=frank.li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=emanuele.ghidoli@toradex.com \
    --cc=ernest.vanhoecke@toradex.com \
    --cc=ernestvanhoecke@gmail.com \
    --cc=festevam@gmail.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox