Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@nxp.com>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	linux@ew.tq-group.com, devicetree@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] arm64: dts: imx8mp-tqma8mpql-mba8mpxl-g133han01: Remove compatible from overlay
Date: Wed, 11 Mar 2026 14:59:32 -0400	[thread overview]
Message-ID: <abG7lPsRZZBIz5m-@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <6599983.31r3eYUQgx@steina-w>

On Wed, Mar 11, 2026 at 05:49:23PM +0100, Alexander Stein wrote:
> Hi,
>
> Am Mittwoch, 11. März 2026, 17:19:37 CET schrieb Frank Li:
> > On Wed, Mar 11, 2026 at 03:52:15PM +0100, Alexander Stein wrote:
> > > There is no reason to override the board compatible in a an overlay,
> > > remove it. While at it, update the copyright year.
> >
> > Any bad things happen if overwrite in overlay file?
>
> You might override the board compatible when it is set (differently) in
> the mainboard.

Is below better

"Override the board compatible is unexpected, especially when the same dtso
override difference mainboard. So remove it and update the copyright year."

Frank

>
> Best regards,
> Alexander
>
> > Frank
> >
> > >
> > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > ---
> > >  .../freescale/imx8mp-tqma8mpql-mba8mpxl-lvds-g133han01.dtso | 6 +-----
> > >  1 file changed, 1 insertion(+), 5 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl-lvds-g133han01.dtso b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl-lvds-g133han01.dtso
> > > index 5058cd9409c75..129b02a69ccf0 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl-lvds-g133han01.dtso
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl-lvds-g133han01.dtso
> > > @@ -1,6 +1,6 @@
> > >  // SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
> > >  /*
> > > - * Copyright (c) 2023 TQ-Systems GmbH <linux@ew.tq-group.com>,
> > > + * Copyright (c) 2023-2026 TQ-Systems GmbH <linux@ew.tq-group.com>,
> > >   * D-82229 Seefeld, Germany.
> > >   * Author: Alexander Stein
> > >   */
> > > @@ -10,10 +10,6 @@
> > >
> > >  #include <dt-bindings/clock/imx8mp-clock.h>
> > >
> > > -&{/} {
> > > -	compatible = "tq,imx8mp-tqma8mpql-mba8mpxl", "tq,imx8mp-tqma8mpql", "fsl,imx8mp";
> > > -};
> > > -
> > >  &backlight_lvds {
> > >  	status = "okay";
> > >  };
> > > --
> > > 2.43.0
> > >
> >
>
>
> --
> TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> Amtsgericht München, HRB 105018
> Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> http://www.tq-group.com/
>
>


      reply	other threads:[~2026-03-11 19:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 14:52 [PATCH 1/5] arm64: dts: imx8mp-tqma8mpql-mba8mpxl-g133han01: Remove compatible from overlay Alexander Stein
2026-03-11 14:52 ` [PATCH 2/5] arm64: dts: imx8mp-tqma8mpql-mba8mpxl-tm070jvhg33: " Alexander Stein
2026-03-11 14:52 ` [PATCH 3/5] arm64: dts: imx8mq-tqma8mq-mba8mx-tm070jvhg33: " Alexander Stein
2026-03-11 14:52 ` [PATCH 4/5] arm64: dts: imx8mn-tqma8mqnl-mba8mx-tm070jvhg33: " Alexander Stein
2026-03-11 14:52 ` [PATCH 5/5] arm64: dts: imx8mm-tqma8mqml-mba8mx-tm070jvhg33: " Alexander Stein
2026-03-11 16:19 ` [PATCH 1/5] arm64: dts: imx8mp-tqma8mpql-mba8mpxl-g133han01: " Frank Li
2026-03-11 16:49   ` Alexander Stein
2026-03-11 18:59     ` Frank Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abG7lPsRZZBIz5m-@lizhi-Precision-Tower-5810 \
    --to=frank.li@nxp.com \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@ew.tq-group.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox