From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2C22106ACCB for ; Thu, 12 Mar 2026 16:37:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CpXTVCCW6005K0xHrqGSAReuETRQ2pmWof9Ne9tW2iY=; b=vi35+5/YoNMu2ejOU6LYtj2vK2 B8lEHc51BqF9h9C1OBoJw9B40ylbliN9YujbTLdgSWrURTP3JPRfXXXWFtQuuqSmwZedANFXWlqYH wZKuiEEBy5HGGpOkwYXM4emBa1BW8Cy6ipsWnfrFHxCERJyu0HJwV5inDYanzr1CVe9mFjB5Pr7is dFOqVusPmKKk6hrcoCy8vGImMdJ4u3A6H+WAh10VKYNfKiocVap9YZmtz07uqPOLwKQ6OZAfI6mTE 8nfjlgw8wcQH6kbemLUVgIWUYsdWYUPHu+FjDmTC7oQ8NUpLWrPyE2H5KU6AXV6CbfQXaE0GcSJzr OHVvmD2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w0j1y-0000000EZgc-1FmU; Thu, 12 Mar 2026 16:37:02 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w0j1u-0000000EZdz-2NCo for linux-arm-kernel@lists.infradead.org; Thu, 12 Mar 2026 16:37:01 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D9E60165C; Thu, 12 Mar 2026 09:36:49 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0541C3F694; Thu, 12 Mar 2026 09:36:52 -0700 (PDT) Date: Thu, 12 Mar 2026 16:36:43 +0000 From: Cristian Marussi To: Sudeep Holla Cc: Cristian Marussi , Geert Uytterhoeven , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org, linux-clk@vger.kernel.org, linux-renesas-soc@vger.kernel.org, philip.radford@arm.com, james.quinlan@broadcom.com, f.fainelli@gmail.com, vincent.guittot@linaro.org, etienne.carriere@foss.st.com, peng.fan@oss.nxp.com, michal.simek@amd.com, dan.carpenter@linaro.org, geert+renesas@glider.be, kuninori.morimoto.gx@renesas.com, marek.vasut+renesas@gmail.com Subject: Re: [PATCH v2 08/13] firmware: arm_scmi: Harden clock protocol initialization Message-ID: References: <20260310184030.3669330-1-cristian.marussi@arm.com> <20260310184030.3669330-9-cristian.marussi@arm.com> <20260312-classy-misty-platypus-5baea1@sudeepholla> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260312-classy-misty-platypus-5baea1@sudeepholla> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260312_093658_744459_AA22467A X-CRM114-Status: GOOD ( 33.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 12, 2026 at 03:33:52PM +0000, Sudeep Holla wrote: > On Wed, Mar 11, 2026 at 06:45:41PM +0000, Cristian Marussi wrote: > > On Wed, Mar 11, 2026 at 05:59:43PM +0100, Geert Uytterhoeven wrote: > > > Hi Cristian, > > > > > > On Tue, 10 Mar 2026 at 19:56, Cristian Marussi wrote: > > > > Add proper error handling on failure to enumerate clocks features or > > > > rates. > > > > > > > > Signed-off-by: Cristian Marussi > > > > Hi, > > > > > > > > Thanks for your patch! > > > > > > > --- a/drivers/firmware/arm_scmi/clock.c > > > > +++ b/drivers/firmware/arm_scmi/clock.c > > > > > > > @@ -1143,8 +1149,12 @@ static int scmi_clock_protocol_init(const struct scmi_protocol_handle *ph) > > > > for (clkid = 0; clkid < cinfo->num_clocks; clkid++) { > > > > cinfo->clkds[clkid].id = clkid; > > > > ret = scmi_clock_attributes_get(ph, clkid, cinfo); > > > > - if (!ret) > > > > - scmi_clock_describe_rates_get(ph, clkid, cinfo); > > > > + if (ret) > > > > + return ret; > > > > > > This change breaks R-Car X5H with SCP FW SDKv4.28.0, as some clocks > > > do not support the SCMI CLOCK_ATTRIBUTES command. > > > Before, these clocks were still instantiated, but were further unusable. > > > After, the whole clock driver fails to initialize, and no SCMI clocks > > > are available at all. > > > > ...and this is exactly what I feared while doing this sort of hardening :P > > > > So there are a few possible solutions (beside reverting this straight away) > > > > The easy fix would be instead change the above in a > > > > if (ret) > > continue; > > > > ...with a bit of annoying accompanying FW_BUG logs, of course, to cause future > > FW releases to fix this :D > > > > Another option could be leave it as it is, since indeed it is the correct enforced > > behaviour, being CLOCK_ATTRIBUTES a mandatory command, BUT add on top an ad-hoc SCMI > > quirk targeting the affected FW releases... > > > > This latter option, though, while enforcing the correct behaviour AND > > fixing your R-Car issue, leaves open the door for a number of possible > > failures of other unknowingly buggy Vendors similarly deployed firmwares... > > > > ...that could be solved with more quirks of course...but...worth it ? > > > > Thoughts ? > > > > Let's see also what @Sudeep thinks about this... > > > > I prefer to fix it as a quirk to prevent similar issues on newer platforms if > the firmware baselines are derived from it. In the worst case, we can relax > the hardening until we figure out a proper quirk-based solution. Ok, I can post a V3 with a dummy quirk 'template' RFC to be filled by Geert with proper versioning....so I can check that there are no surprises round the (quirked) corner... Thanks, Cristian