public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Tomas Borquez <tomasborquez13@gmail.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Alisa-Dariana Roman" <alisa.roman@analog.com>,
	"Peter Rosin" <peda@axentia.se>,
	"Marius Cristea" <marius.cristea@microchip.com>,
	"Matteo Martelli" <matteomartelli3@gmail.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Jacopo Mondi" <jacopo@jmondi.org>,
	"Benson Leung" <bleung@chromium.org>,
	"Jyoti Bhayana" <jbhayana@google.com>,
	"Kim Seer Paller" <kimseer.paller@analog.com>,
	"Mariel Tinaco" <Mariel.Tinaco@analog.com>,
	"Janani Sunil" <janani.sunil@analog.com>,
	"Ariana Lazar" <ariana.lazar@microchip.com>,
	"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Guenter Roeck" <groeck@chromium.org>,
	"Olivier Moysan" <olivier.moysan@foss.st.com>,
	"Giorgi Tchankvetadze" <giorgitchankvetadze1997@gmail.com>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Shi Hao" <i.shihao.999@gmail.com>,
	"Antonio Borneo" <antonio.borneo@foss.st.com>,
	"Dixit Parmar" <dixitparmar19@gmail.com>,
	"Tzung-Bi Shih" <tzungbi@kernel.org>,
	"Gwendal Grignou" <gwendal@chromium.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	"Kurt Borja" <kuurtb@gmail.com>,
	"Waqar Hameed" <waqar.hameed@axis.com>,
	"Matti Vaittinen" <mazziesaccount@gmail.com>,
	chuguangqing <chuguangqing@inspur.com>,
	"Erikas Bitovtas" <xerikasxx@gmail.com>,
	"Mårten Lindahl" <marten.lindahl@axis.com>,
	"Fabrice Gasnier" <fabrice.gasnier@foss.st.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	chrome-platform@lists.linux.dev
Subject: Re: [PATCH] cleanup: uintptr_t to unsigned long
Date: Fri, 13 Mar 2026 11:29:51 +0200	[thread overview]
Message-ID: <abPZD-fLDYzE2WRc@ashevche-desk.local> (raw)
In-Reply-To: <20260313013435.25731-1-tomasborquez13@gmail.com>

On Thu, Mar 12, 2026 at 10:34:35PM -0300, Tomas Borquez wrote:
> Linus has been explicit that uintptr_t should not be used in the kernel.

And it's all usually about new code. The shuffling _existing_ code is a churn.
This churn has to be agreed upfront. (That's what Jonathan's mail is, so
you need to have two links and proper message.)

> The iio_chan_spec_ext_info struct uses uintptr_t for the private field
> and in its read/write function pointer signatures. Jonathan Cameron noted
> this should be cleaned up in one go across all users [1].
> 
> Update the struct definition in iio.h and backend.h, along with all
> drivers implementing or using iio_chan_spec_ext_info callbacks.
> 
> No functional change intended.

> [1] https://lore.kernel.org/linux-iio/20260111122034.174c754c@jic23-huawei/
> 

This should be Link tag. And to the original email.

> Suggested-by: Jonathan Cameron <jic23@kernel.org>

We don't accept wrongly prepared patches.
NAK.

...

>  drivers/iio/adc/stm32-dfsdm-adc.c             |  4 ++--
>  drivers/iio/afe/iio-rescale.c                 |  4 ++--
>  drivers/iio/amplifiers/hmc425a.c              |  4 ++--
>  drivers/iio/chemical/sunrise_co2.c            |  8 ++++----
>  .../cros_ec_sensors/cros_ec_sensors_core.c    |  4 ++--
>  drivers/iio/common/scmi_sensors/scmi_iio.c    |  2 +-
>  drivers/iio/dac/ad3530r.c                     |  4 ++--

Besides that, it's much better to group them one per subfolder: adc, dac,
et cetera. Currently this even spams tons of people who do not want to
be spammed.

Take your time and become familiar with the process before sending a proper
version of this.

-- 
With Best Regards,
Andy Shevchenko




      parent reply	other threads:[~2026-03-13  9:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13  1:34 [PATCH] cleanup: uintptr_t to unsigned long Tomas Borquez
2026-03-13  7:10 ` [PATCH v2] iio: " Tomas Borquez
2026-03-13  9:31   ` Andy Shevchenko
2026-03-13  9:29 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abPZD-fLDYzE2WRc@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=Mariel.Tinaco@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=alisa.roman@analog.com \
    --cc=andy@kernel.org \
    --cc=antonio.borneo@foss.st.com \
    --cc=antoniu.miclaus@analog.com \
    --cc=ariana.lazar@microchip.com \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=chuguangqing@inspur.com \
    --cc=dixitparmar19@gmail.com \
    --cc=dlechner@baylibre.com \
    --cc=fabrice.gasnier@foss.st.com \
    --cc=giorgitchankvetadze1997@gmail.com \
    --cc=groeck@chromium.org \
    --cc=gustavoars@kernel.org \
    --cc=gwendal@chromium.org \
    --cc=i.shihao.999@gmail.com \
    --cc=jacopo@jmondi.org \
    --cc=janani.sunil@analog.com \
    --cc=jbhayana@google.com \
    --cc=jic23@kernel.org \
    --cc=kimseer.paller@analog.com \
    --cc=kuurtb@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=marius.cristea@microchip.com \
    --cc=marten.lindahl@axis.com \
    --cc=matteomartelli3@gmail.com \
    --cc=mazziesaccount@gmail.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=olivier.moysan@foss.st.com \
    --cc=peda@axentia.se \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tomasborquez13@gmail.com \
    --cc=tzungbi@kernel.org \
    --cc=waqar.hameed@axis.com \
    --cc=xerikasxx@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox