From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Billy Tsai <billy_tsai@aspeedtech.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Joel Stanley" <joel@jms.id.au>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
morris_mao@aspeedtech.com
Subject: Re: [PATCH] iio: adc: aspeed: Reserve battery sensing channel for on-demand use
Date: Fri, 13 Mar 2026 12:08:36 +0200 [thread overview]
Message-ID: <abPiJEOL40C5eR1k@ashevche-desk.local> (raw)
In-Reply-To: <20260313-adc-v1-1-7a2edb4e5664@aspeedtech.com>
On Fri, Mar 13, 2026 at 06:02:16PM +0800, Billy Tsai wrote:
> For controllers with battery sensing capability (AST2600/AST2700), the last
> channel uses a different circuit design optimized for battery voltage
> measurement. This channel should not be enabled by default along with other
> channels to avoid potential interference and power efficiency issues.
>
> Changes made:
> - Introduce aspeed_adc_get_active_channels() to return the number of
> channels that should be enabled by default
> - For battery sensing capable controllers, exclude the last channel
> from the default channel enable mask
> - Enable the battery sensing channel only when explicitly accessed
> via read_raw()
> - Replace hardcoded channel numbers with ASPEED_ADC_BATTERY_CHANNEL macro
> - Add helper functions for cleaner channel management
Why not series of patches each for the change made?
> This ensures optimal power efficiency for normal ADC operations while
> maintaining full functionality when battery sensing is needed.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-13 10:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 10:02 [PATCH] iio: adc: aspeed: Reserve battery sensing channel for on-demand use Billy Tsai
2026-03-13 10:08 ` Andy Shevchenko [this message]
2026-03-16 2:41 ` Billy Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abPiJEOL40C5eR1k@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andrew@codeconstruct.com.au \
--cc=andy@kernel.org \
--cc=billy_tsai@aspeedtech.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=morris_mao@aspeedtech.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox