public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Stefan Wahren <wahrenst@gmx.net>
To: Jiri Slaby <jirislaby@kernel.org>, gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Emil Kronborg" <emil.kronborg@protonmail.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Uwe Kleine-König" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/2] serial: mxs-auart: fix tx
Date: Thu, 1 Feb 2024 18:59:37 +0100	[thread overview]
Message-ID: <aba9744f-977c-4306-9cdf-104800344b5d@gmx.net> (raw)
In-Reply-To: <3935b841-77b7-4265-a727-98a358cd56be@kernel.org>

Am 01.02.24 um 13:05 schrieb Jiri Slaby:
> On 01. 02. 24, 11:55, Jiri Slaby (SUSE) wrote:
>> Emil reports:
>>    After updating Linux on an i.MX28 board, serial communication over
>>    AUART broke. When I TX from the board and measure on the TX pin, it
>>    seems like the HW fifo is not emptied before the transmission is
>>    stopped.
>>
>> MXS performs weird things with stop_tx(). The driver makes it
>> conditional on uart_tx_stopped().
>>
>> So the driver needs special handling. Pass the brand new UART_TX_NOSTOP
>> to uart_port_tx_flags() and handle the stop on its own.
>>
>> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
>> Reported-by: Emil Kronborg <emil.kronborg@protonmail.com>
>> Fixes: 2d141e683e9a ("tty: serial: use uart_port_tx() helper")
>> Closes:
>> https://lore.kernel.org/all/miwgbnvy3hjpnricubg76ytpn7xoceehwahupy25bubbduu23s@om2lptpa26xw/
>
Tested-by: Stefan Wahren <wahrenst@gmx.net>

Thanks

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      parent reply	other threads:[~2024-02-01 17:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240201105557.28043-1-jirislaby@kernel.org>
     [not found] ` <20240201105557.28043-2-jirislaby@kernel.org>
2024-02-01 12:05   ` [PATCH v2 2/2] serial: mxs-auart: fix tx Jiri Slaby
2024-02-01 14:57     ` Greg KH
2024-02-01 17:59     ` Stefan Wahren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aba9744f-977c-4306-9cdf-104800344b5d@gmx.net \
    --to=wahrenst@gmx.net \
    --cc=emil.kronborg@protonmail.com \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox