From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 554B4C433E0 for ; Thu, 18 Feb 2021 03:08:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD3A064E2F for ; Thu, 18 Feb 2021 03:08:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD3A064E2F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=a10hAOBq1SioFcTOTDcDBCSf32E2ooEJXXZyaug6I+o=; b=bRRUI1lda9IUEvoEGtcwkO6xX H/cewPUS7xJUtGZ8gZ1n3qS0adlTtF/6GFCDcVB3Lv75PEFINL6w7OjAuIvW7qhCaHMpu6GBcw4o4 o57TWkxg/Yk2G0NO2t4SvimifnwgTFK08IhSPJp4kEb16utOPYfdYjxn1R2ooMm8+0Q5I6WOoGfWv fk2xYaWDiw+bbdgD65mmWfob9sxUmpnOyuUWVIPYMymN4PRZm38nyJrGuqMNpjpaSfeilKqyV0MTw FUoDBVDqQH7x+r9ffBsOmR+LIfPhmBGnjnsI1w4BU9DeK7p+5fVWQpDMY7I0B+WIeJNmh7wuLqn9i h8GvZymzw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCZdm-0003w2-9y; Thu, 18 Feb 2021 03:06:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCZdj-0003vK-P6 for linux-arm-kernel@lists.infradead.org; Thu, 18 Feb 2021 03:06:04 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0BE6D1FB; Wed, 17 Feb 2021 19:05:58 -0800 (PST) Received: from [192.168.0.130] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 881ED3F694; Wed, 17 Feb 2021 19:05:55 -0800 (PST) Subject: Re: [PATCH V3 14/14] coresight: etm-perf: Add support for trace buffer format To: Al Grant , Peter Zijlstra References: <1611737738-1493-1-git-send-email-anshuman.khandual@arm.com> <1611737738-1493-15-git-send-email-anshuman.khandual@arm.com> From: Anshuman Khandual Message-ID: Date: Thu, 18 Feb 2021 08:35:54 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210217_220603_876938_85539C53 X-CRM114-Status: GOOD ( 14.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "coresight@lists.linaro.org" , "mike.leach@linaro.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "lcherian@marvell.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/27/21 6:30 PM, Al Grant wrote: >>> +/* CoreSight PMU AUX buffer formats */ >>> +#define PERF_AUX_FLAG_CORESIGHT_FORMAT_CORESIGHT0x0000 /* >> Default for backward compatibility */ >>> +#define PERF_AUX_FLAG_CORESIGHT_FORMAT_RAW0x0100 /* >> Raw format of the source */ >> >> Would CORESIGHT_FORMAT_ETR / CORESIGHT_FORMAT_TRBE be better >> names? > > Unformatted (raw) streams could be used any time you had a writer dedicated > to a single trace source. So in a situation where you had one ETR per CPU, > it would be appropriate to use an unformatted stream. A TRBE is always > dedicated to a single CPU, but potentially you (i.e. when designing the system) > can do this with any type of trace sink. So the raw/formatted distinction is > really about whether you are combining multiple streams in one buffer or not, > rather than the type of block that is writing into the buffer. > > Al > Okay, will stick with the proposed format names here i.e PERF_AUX_FLAG_CORESIGHT_FORMAT_CORESIGHT PERF_AUX_FLAG_CORESIGHT_FORMAT_RAW _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel