From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE25FC48297 for ; Mon, 12 Feb 2024 15:35:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N9OPcBY5XFN5xBxJUgaik13vvkuhO99Z74DKjfpJLmU=; b=ElRZyyn5eDinLy /tbXaHJORl6BGJOH8L6iMxlkvFLVmJdsJ3cyJ9Llb17CMQD6GMZikXWeWm5m6RlVG+JEg2iYGA7aO FscEcwdF3Z+EaMNUuKmWrjPbt4HgSNVo18lYV/p3cd1yPgsOvFoqUE03TzY9bssr0EpslO1ughcZB Rne6GkkeZR0QWBpQ+h7uWc52dxJ+zPQO5zabCq+F2aGmGPxA78riRuAN537rLg9EGRr86gxCJjDZo +4UtXHHnTJX+04Hkj0ZCzGvMl1V06WFpZHJqsYQnZFUsDsHgX6wsjNqlpRO3jEPkXxn9lb8EvTx97 BTb48lowsU7hm6KfZ8xg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZYKd-00000005z6u-1841; Mon, 12 Feb 2024 15:34:55 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rZYKa-00000005z4t-2dqK for linux-arm-kernel@lists.infradead.org; Mon, 12 Feb 2024 15:34:54 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 600FDDA7; Mon, 12 Feb 2024 07:35:31 -0800 (PST) Received: from [10.57.78.115] (unknown [10.57.78.115]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9D37C3F766; Mon, 12 Feb 2024 07:34:45 -0800 (PST) Message-ID: Date: Mon, 12 Feb 2024 15:34:43 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 19/25] arm64/mm: Wire up PTE_CONT for user mappings Content-Language: en-GB To: David Hildenbrand , Mark Rutland Cc: Catalin Marinas , Will Deacon , Ard Biesheuvel , Marc Zyngier , James Morse , Andrey Ryabinin , Andrew Morton , Matthew Wilcox , Kefeng Wang , John Hubbard , Zi Yan , Barry Song <21cnbao@gmail.com>, Alistair Popple , Yang Shi , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240202080756.1453939-1-ryan.roberts@arm.com> <20240202080756.1453939-20-ryan.roberts@arm.com> <502a3ea7-fd86-4314-8292-c7999eda92eb@arm.com> <427ba87a-7dd0-4f3e-861f-fe6946b7cd97@redhat.com> From: Ryan Roberts In-Reply-To: <427ba87a-7dd0-4f3e-861f-fe6946b7cd97@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240212_073452_813620_810607F8 X-CRM114-Status: GOOD ( 24.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/02/2024 15:26, David Hildenbrand wrote: > On 12.02.24 15:45, Ryan Roberts wrote: >> On 12/02/2024 13:54, David Hildenbrand wrote: >>>>> If so, I wonder if we could instead do that comparison modulo the access/dirty >>>>> bits, >>>> >>>> I think that would work - but will need to think a bit more on it. >>>> >>>>> and leave ptep_get_lockless() only reading a single entry? >>>> >>>> I think we will need to do something a bit less fragile. ptep_get() does >>>> collect >>>> the access/dirty bits so its confusing if ptep_get_lockless() doesn't IMHO. So >>>> we will likely want to rename the function and make its documentation explicit >>>> that it does not return those bits. >>>> >>>> ptep_get_lockless_noyoungdirty()? yuk... Any ideas? >>>> >>>> Of course if I could convince you the current implementation is safe, I >>>> might be >>>> able to sidestep this optimization until a later date? >>> >>> As discussed (and pointed out abive), there might be quite some callsites where >>> we don't really care about uptodate accessed/dirty bits -- where ptep_get() is >>> used nowadays. >>> >>> One way to approach that I had in mind was having an explicit interface: >>> >>> ptep_get() >>> ptep_get_uptodate() >>> ptep_get_lockless() >>> ptep_get_lockless_uptodate() >> >> Yes, I like the direction of this. I guess we anticipate that call sites >> requiring the "_uptodate" variant will be the minority so it makes sense to use >> the current names for the "_not_uptodate" variants? But to do a slow migration, >> it might be better/safer to have the weaker variant use the new name - that >> would allow us to downgrade one at a time? > > Yes, I was primarily struggling with names. Likely it makes sense to either have > two completely new function names, or use the new name only for the "faster but > less precise" variant. > >> >>> >>> Especially the last one might not be needed. >> I've done a scan through the code and agree with Mark's original conclusions. >> Additionally, huge_pte_alloc() (which isn't used for arm64) doesn't rely on >> access/dirty info. So I think I could migrate everything to the weaker variant >> fairly easily. >> >>> >>> Futher, "uptodate" might not be the best choice because of PageUptodate() and >>> friends. But it's better than "youngdirty"/"noyoungdirty" IMHO. >> >> Certainly agree with "noyoungdirty" being a horrible name. How about "_sync" / >> "_nosync"? > > I could live with > > ptep_get_sync() > ptep_get_nosync() > > with proper documentation :) but could you live with: ptep_get() ptep_get_nosync() ptep_get_lockless_nosync() ? So leave the "slower, more precise" version with the existing name. > > I don't think we use "_sync" / "_nosync" in the context of pte operations yet. > > Well, there seems to be "__arm_v7s_pte_sync" in iommu code, bit at least in core > code nothing jumped at me. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel