From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB73CF53D76 for ; Mon, 16 Mar 2026 16:53:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=y2FogylTgWsPlZhZnRN3rQTcs9DpO5a/cBRkTfUxsGM=; b=WLFxwVPVpLTRiOdFk2YKtIfeVd x0j2PVhOu2dfXOGeJxOxrZR0SV2pzc/vySwF5sdqbIfr/O69gX9q2Zt5cWWHzVwsz/agVhP5I+VOZ 60UMpOvW/8uuh/2mdxozELxlyN0vlFXEJUVZQ1KiiKHaBEZVq7o5hAKn9ybSIEPLttJAJ1zpTV/hX bWcy0DLL+5vu7FHmEJ33Jurm27W5rMZL1e4Oq18S9saXduQZM6d+1u67VFJW400tC05A3Z2OiI7xT 8GUEHLVFgFhAtLK1ZD/X8DAKxMrzedmL4epy4V89Wr/b/1ng9+Q0CiqA22gPpJmqBwcj0ATA1soy0 HdhKpl6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w2BC4-00000004Uh0-3595; Mon, 16 Mar 2026 16:53:28 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w2BC1-00000004UgI-1ueG for linux-arm-kernel@lists.infradead.org; Mon, 16 Mar 2026 16:53:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DD16D1477; Mon, 16 Mar 2026 09:53:17 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DA9D43F73B; Mon, 16 Mar 2026 09:53:22 -0700 (PDT) Date: Mon, 16 Mar 2026 16:53:19 +0000 From: Cristian Marussi To: Geert Uytterhoeven Cc: Sudeep Holla , Cristian Marussi , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] firmware: arm_scmi: Support loop control in quirk code snippets Message-ID: References: <51de914cddef8fa86c2e7dd5397e5df759c45464.1773675224.git.geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51de914cddef8fa86c2e7dd5397e5df759c45464.1773675224.git.geert+renesas@glider.be> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260316_095325_534262_5E3646FE X-CRM114-Status: UNSURE ( 9.78 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 16, 2026 at 04:34:40PM +0100, Geert Uytterhoeven wrote: > Each SCMI firmware quirk contains a code snippet, which handles the > quirk, and has full access to the surrounding context. When this > context is (part of) a loop body, the code snippet may want to use loop > control statements like "break" and "continue". Unfortunately the > SCMI_QUIRK() macro implementation contains a dummy loop, taking > precedence over any outer loops. Hence quirk code cannot use loop > control statements, but has to resort to polluting the surrounding > context with a label, and use goto. Hi, indeed...good catch, thanks for this. I think, no need to backport as Fixes since existing quirks are NOT impacted. LGTM. Reviewed-by: Cristian Marussi Thanks, Cristian