From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7F21F33804 for ; Tue, 17 Mar 2026 07:23:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BZLPLNDlo80VXp1ghSVP6zc0i73sBy+jzZBBUxabyX0=; b=B2l6nG3pj0ylAh7IN0RkVx71UO IuUQa7Py150S5WjFgwe4+kA290k4EFt0xv8mXdgvidaQA9eXnMQcsK7pi/RJb+Xy9ShlUTkDjxJWN ex/GGn6H5CUvc/QB3N+Gf0y5GbIybQNMlwyMkQ+SKig0MfBpOwkwSs60g7B28yiToE8OQkGN2Zep3 d9TxluT4t4maMfmSHBBTfEsq5dXlCQGzY6x+XqUFvVhCSRRa2jw3wZTCDr0O+d3gYtu2fgOBhJKcT W9rr0GErxJTVrpKUUs25BpZgEhraNtbBuK3Jt6FI/UUaI1ZNYuYtXBJT4PFtW0Z6sgyX/f+9ErLTN mBHXLhxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w2Om6-00000005Z6n-2NCd; Tue, 17 Mar 2026 07:23:34 +0000 Received: from mail-westeuropeazlp170100001.outbound.protection.outlook.com ([2a01:111:f403:c201::1] helo=AM0PR83CU005.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w2Om4-00000005Z6C-0cdk for linux-arm-kernel@lists.infradead.org; Tue, 17 Mar 2026 07:23:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZIyIyfPhRMrY9h0jEocUI7x34MUIcjpwdvE03B9lpRkUga35e35VnMPA7MJ58C4RmRfPUhTkBokjiYJG5GUJTxbLEHp4mlZb3GwSct82vwvhETMdFZe3euCbZhIcoMHwMaJupaxvhJDm5G+2lDxIhrn1sGlz6r0Yr6WDk5tJcIYKvQWwQx1wyEPTXgva3vIoRM15/rFp+/CXTl7oDaGxAyNCfvyvw0XsffQc/zgs+1uGafYTlCD64lccVra++f8bob7KBnN/BLPxs5rLs2tmnvld7lBrORU9r8BeYMVoRUIUziJXoh/eWzhVf/BHof/V0CkmA2HFW+hnvr8+MHsB2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BZLPLNDlo80VXp1ghSVP6zc0i73sBy+jzZBBUxabyX0=; b=Tx92j5o1Y3AlDK3CC99DignCxoN+XVEUfaSz/v/n6QNYIn5Zv1BVZW2Az/i6qUhpMECiqD/QF7Hhf2JjliMy9ciyS9BsnFPdkyzESXLDOAElRlqbZmKRhiumTJx8G/h1y1KElMSdBlAItC4nQVcVdh7vCV94A+JiTzS27677BXvTMZefSb0szfTXXnaImH5RgsKocS/trzdf2tAHyjb4GNCPk2rFe35Rz0o9X+mNziiuIuKeEMhPgrcKg5xQN9MJmRMQh3BfEtBxmSAvdtaNSwYCv4lTgCsqfoEPzNFJbjhvZ53eibFY5r97QysH4bZoOaPxQbJbG/uWCb2nvEvVmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BZLPLNDlo80VXp1ghSVP6zc0i73sBy+jzZBBUxabyX0=; b=k0k9y3wDs8hP5o0hn5bzO014eF2gU1kaEQkyXF35MaOa1wnLPlI1MY9Inu3T6MRdAo2jwvP/7AigicCeG9wxy8fdZfNwVssJJoMtKCqfA8bcuwmKn3ZOYftsluRPUs0bqbVT9pTXdoEpZPbytESkfgW9c+bmPK0nWR0OQ1NSwTKM6w6ctTICLkCKu5YBZLcEV4/a02ZbiEG4J4mB1ctgeA+zOG1q1ZaBvVwNVVwVAZQ21e3zREoBnlGFTQEvBbI3OVjg/oXBjCHiGPfLm/oJ0HCxUu2GjKr3dtW0l9aadrnz0P2W8aTtYHrcHEekbg/WenUOTGXZ/TY/VMhEiYeN3Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DB9PR04MB8461.eurprd04.prod.outlook.com (2603:10a6:10:2cf::20) by PA1PR04MB11262.eurprd04.prod.outlook.com (2603:10a6:102:4eb::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9700.22; Tue, 17 Mar 2026 07:23:15 +0000 Received: from DB9PR04MB8461.eurprd04.prod.outlook.com ([fe80::21f6:947a:1f40:18af]) by DB9PR04MB8461.eurprd04.prod.outlook.com ([fe80::21f6:947a:1f40:18af%4]) with mapi id 15.20.9700.024; Tue, 17 Mar 2026 07:22:53 +0000 Date: Tue, 17 Mar 2026 15:25:30 +0800 From: Peng Fan To: Geert Uytterhoeven Cc: Sudeep Holla , Cristian Marussi , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] firmware: arm_scmi: Support loop control in quirk code snippets Message-ID: References: <51de914cddef8fa86c2e7dd5397e5df759c45464.1773675224.git.geert+renesas@glider.be> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51de914cddef8fa86c2e7dd5397e5df759c45464.1773675224.git.geert+renesas@glider.be> X-ClientProxiedBy: MA0PR01CA0067.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:ad::13) To DB9PR04MB8461.eurprd04.prod.outlook.com (2603:10a6:10:2cf::20) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB9PR04MB8461:EE_|PA1PR04MB11262:EE_ X-MS-Office365-Filtering-Correlation-Id: a9541e37-629d-4dc5-0d15-08de83f60089 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|366016|1800799024|376014|52116014|38350700014|18002099003|22082099003|56012099003|7053199007; X-Microsoft-Antispam-Message-Info: 0RfgQc7reOCFT0z7gbYqCu24MGqU1o1BLrjrSBG2WuVaLbeh2NDoMupryIar/jTS2RkW/vzQOOmqZFCvJRnTlV3dHNk6V7SlViinuGm58w589b0s1cE7bwvI5Jy+Qwbmxhg1CeRJ3yH6TeI1M9BSAs0yL5vjTSRmjsck+Zy6He3Ne0n6oTcY1/L4n1n19CJF05RHxWb0rVB2LANdkCDrR70jGA+XatjXRSyFJfFrRKj/9z+pNt2QA4s44f9Yojq0qWZMqYYsnjMAioi0P0bGBfIlNpaQf52m/p/3/2nyGF9zLhgnATl+ZcnGr07ArLpeq64sQauZ6K42LFS0lBR239tX875yuXXssavuXgdEOSzCt+9/gXNpRCeGDwYiVWPyuaJm47pqOMRN9uMRXlqpthBS3rPS1R2TIA6BI9BRgjaPCHNpUYVSyW4D4NdGvY4K6C8m3gsCFBAVugg3MzTbqDS9u8ALNOlIev6b0I+uyH1e05ZjE6EI+FwNxKBQvddi2N74VvnEpC6S6LjTQeJNZ0P9BKKeVLrK9bYiP7MtAPF74SkSMfDG1gyY/TRvrWMNjtjo+i7CZUoj7KhTmqKvskRPvqBdGMzIb0yX1H7yaHVS4RcanishzjKkKH/2JH7zyqLM3xiXbwHSi3Azf3ponR69ajn/KttY2NspFurlz3x9F7jqVT4jHd15uFGrwHL1PTSb9erCZMxLgOfP8volhBReMI8o5Mq4U1dzeHCDsnlHfUY141PwTmAW0XM2SQWgLqKDdNNVof/7J+Z/nLCzWgpF4vF9i5PwtTQZe6A84pY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR04MB8461.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(366016)(1800799024)(376014)(52116014)(38350700014)(18002099003)(22082099003)(56012099003)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?N5Meh65larkaDAj4uoC4euM7Yo7jP45fJekc3w7i0NSycPVlhiP7ZoOv4WOI?= =?us-ascii?Q?LY9y5sWyCbOa150RMyB/0vHJ7a+6AwVcR1ehTUYVdHT4kfg6GwSoBTQt4mfX?= =?us-ascii?Q?U+Ikmcuf0ht4sWUXXMxNfTmKI4Qm3WmI+5CcG3xF6hjqBRkgkQeph3e8hDJm?= =?us-ascii?Q?lbjxAxpbKfVbK40Vu2vALwozZQTawUGtoW/a1FZmfDp5JnwvUpeVSqDtbETQ?= =?us-ascii?Q?DdpXDMJke7EJ2msKErrPi4p2pK7qL3SRhdaAQjzFrtG8FKFhRgdWGfYilDuP?= =?us-ascii?Q?hvWz9ZAU+UXf2VDHVueGb3JMHlFgsHrDC7SsrBTdXd5i6SuZg+8zEcfbNGch?= =?us-ascii?Q?2+DohWKrLJDXtgbrzIvilgfTp29cOoMXRdP4kUGYua7BiAvQbir3OofCTql5?= =?us-ascii?Q?KX+0MCK4vuvufUZ4+1lH4mSJ8EQG0CTuLw9/3J6PKJAHLQTHpAdOPaoxsKiU?= =?us-ascii?Q?9ZeltCk1r1+VzAgwEQLKt2DOSPrH3PsZ9oVgDMw3pKFAtxlA0OhVV5HNbWex?= =?us-ascii?Q?AKE2bMmNoiecsZxHVXnl5kEDYynqUnZ18t4rURyZ+U1Z3LCrbWeA1aZdGAD4?= =?us-ascii?Q?PBW+EYSNdDI+IlO1lSbspFFKb33kgTDBN0/qs+yRcRKY/kXOgJUP/JTDKcZO?= =?us-ascii?Q?z8yX7keAZ/xsaVhAErvE9atR1LmLJ1rZNrwGWmNvqb9I5pRnh8Oz9EbNoIVm?= =?us-ascii?Q?d8fUxMhtR0wwHn9AekKSoimZIRZp9Rq3KjAGajWpe9VXR/Blbrf4loPXbv7d?= =?us-ascii?Q?kqlxuJLdgyeSa1IWac1lA06BEOg5ceApb6prD8gm+NRgilRRROkoucQjKNfb?= =?us-ascii?Q?jabzU5YTmxvkOxvud8s6pYbe4UISoSRoyGsmObkaFoXc8+FWTMYBcRd9TJSP?= =?us-ascii?Q?72QL4BU1wnYimWAmGgjpL9DKP3QnE0Fz407xn2Q3Oy7SkyaXMaknnl6QyzAC?= =?us-ascii?Q?jWR7QQNc4I7fkf40sRA3HvbicxXAnf3QuKlHtgbegJF9zkDWNpkM883KDObd?= =?us-ascii?Q?BS5IDEykP/q9txwVKfuyyC6RcxXAy2Xw/qwE1lhaOve72mNL1RI/Qw6jSfup?= =?us-ascii?Q?aAk6ljSP1lxIW3BRTSUywRnZ7Z7eKqVNzVqVgSvBl6dJkd5nqXlnNhcByKn+?= =?us-ascii?Q?4X3eYcvOpKmsZftk7UJMsOFQCmV6xFBcx8dogXDpNLMDKpR/3o/aAnSSOyGs?= =?us-ascii?Q?X050pTeEbzVXZM08Qnz4pAUCsYxol56T+aH/PRZ4+Srah+g+BJXxWnE4jHFa?= =?us-ascii?Q?JLm7SX2hDC+pMrbtZqmJeOQxoE32cK0rMietp/R2XqHajvS0e7RUv34ugARv?= =?us-ascii?Q?3+BETJlBmw/t2+AzvxBZwNmFeACSqahzpFjIQeSEvilvfH8m34HltwzDZpRU?= =?us-ascii?Q?XWW/xdtgVICrfGFnTmtw1P6fSaRl0JCzZzp5V2yYamIFJWUwEwmb9EZ3B5tX?= =?us-ascii?Q?ZI2WVswwMT+Y0zrCD3IAzPfKcidJAGkt4Ey0y1qQOBdCdjo8r7F0IcEUDZdt?= =?us-ascii?Q?5QCx4UW/s7fUZk2iszVmE+MPfPdEhJuDhTU/QxYfz3kVitf3wFOR5Xx1pEa6?= =?us-ascii?Q?WAVbCthFfnSNn4tBzuXBSJTogFmJHjdLlAm2JR43xjoX+F8mZoJe5iICT+hI?= =?us-ascii?Q?2j38Yy4F8VUhutvohw6IUAJ/oM/9gtJJSJQghPlZykhAsFSGzsbo7hhi+5Vs?= =?us-ascii?Q?GZS5Td4tlsuShu/VdPvknn72nW8AKSap6qlQRu72vC77vLZ1mJRvFkVlXgUU?= =?us-ascii?Q?CwkoSIPEig=3D=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9541e37-629d-4dc5-0d15-08de83f60089 X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8461.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2026 07:22:53.3284 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xMdwjMEyfYaZu8+M+eYciyZmYjl0QQ82q6zdmKpnhLowg0l5y3LoLkk3mLFkXOZur+XLk7mCIOkUrGnTT8XF1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB11262 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260317_002332_194781_7B0DFFEB X-CRM114-Status: UNSURE ( 8.85 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 16, 2026 at 04:34:40PM +0100, Geert Uytterhoeven wrote: >Each SCMI firmware quirk contains a code snippet, which handles the >quirk, and has full access to the surrounding context. When this >context is (part of) a loop body, the code snippet may want to use loop >control statements like "break" and "continue". Unfortunately the >SCMI_QUIRK() macro implementation contains a dummy loop, taking >precedence over any outer loops. Hence quirk code cannot use loop >control statements, but has to resort to polluting the surrounding >context with a label, and use goto. > >Fix this by replacing the "do { ... } while (0)" construct in the >SCMI_QUIRK() implementation by "({ ... })". > >Signed-off-by: Geert Uytterhoeven Reviewed-by: Peng Fan