From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 906ADC2BBCA for ; Tue, 25 Jun 2024 09:55:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kECwLGxqId1Ov65xGDMi5MpX17DgpZQ+tjYQbJXb13M=; b=H+RG22+ZwR9gEJBLaAyvt3ch3s bM5ZHrhW7+Uj5laTNQbKzVP5BmNFm2aJnPakvKaTHhZYWvJ8N7IaFqgsE+33qkNQ38UQ2nGiJj4cx Jm7MO8n6pB2sflOB9m+QPmGdyjyZNn1Z1GtnVOK55svBvl4Pzqum26TIqDBOlaOSKCcurB6YEA0lu taONfmlSwWNHWja41aY0TXpVWOf5B0pYXR90JN+O/parZR18uibXCoJN5f0A+XOFKMDZ4TRGbTOOc WTlwzaHwNFFs6GDY4wsk1kmQ+hO04W9w05sjrRK/iU70Pk7wIAmYm4yxWHj1YQmnIC1KVHeNvy1Go y/GTc/SQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sM2tV-00000002KRd-2CQR; Tue, 25 Jun 2024 09:55:21 +0000 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sM2tQ-00000002KQB-0KdT for linux-arm-kernel@lists.infradead.org; Tue, 25 Jun 2024 09:55:17 +0000 Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2ebec2f11b7so57861331fa.2 for ; Tue, 25 Jun 2024 02:55:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719309313; x=1719914113; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=kECwLGxqId1Ov65xGDMi5MpX17DgpZQ+tjYQbJXb13M=; b=zJG0nQwcZzMH+lEBAPPgbAzlGh/I/qH/zvOzXz+UYKQGlaVfgXHYoTliZSalWSsh9d Ruu0mhuV+3/1IusogtRuIB34vga59qwQZ/lnil9uHZyv6rskzrKgn2R/IaPQ5IvFQP01 UXn9gYP9F1+kmUVD+YjSI5Ko1WulYkuJSePLLxJKUNoiZmLhNxaQSdFHvByfDLI93oN8 S5S/K2tgZJltwZoggGIeerjiT/Dgxui72iP9eReulD7x0fIzNHPgBKf0iguRnDI8ghvb iwT1hW4KFIq2Bi0joz8CyaSyyr/I0p5d8XFn4uSTS8oAZICNUkog1bN8JON2JrLEAdxL s+7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719309313; x=1719914113; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=kECwLGxqId1Ov65xGDMi5MpX17DgpZQ+tjYQbJXb13M=; b=e6ojFU8vxe00PzqzwmA/DYw2anZvuvbvXx6Hcd9awMYyTA8GZOj591OvjDLrpZC45b PlVOd06R04nYsCIWXnqKFE+0aw/HrUuSUM+TONyHiqLlECxavMS/ejHEjlQiMbcv1Xba ysUqmhOWREw8TxlA4RbX5XqNhaNbkWeqzj86KKzEH2+AKG+2qWLnPhJRtCFo1Lq2ahb8 0gbvs3nCks8RYUTtK9kpQKy3SeO+FutwHENOG4vatRKfO8TMV+K2rpLqxJQWwC7sauTK BAn4u50z3G/DZ/nX/6iRGjzrWXYI016Or+9oVJz3M8jbP8CvYHEVV5rXZfXO3/hcyxcH vV5A== X-Forwarded-Encrypted: i=1; AJvYcCWNsmflJhZhu9/5kJhrQo6D7ZcZA3dahLBpkYGjbDebrsT1ldHBEAj4RAlf379wLKTx1STlojk/rTRRzvmC2vVMVUfUx6FooUq4m8kGIdaIC9EHncg= X-Gm-Message-State: AOJu0YxNWhCJF329wHD7Othhx5ld81rcAeDKqjeTdFTsylr0HNyaAyMG p0n3I5qnRPuO5WVk/EkdeqXycdGxTBm0JFhy0jvisGehQmkQ017cDqmniuMqb1Y= X-Google-Smtp-Source: AGHT+IFMwMhvOphtvO8C5EwWqvnT9WcF0/GsSlyeQT++HVrdddjTsK1XMZKeXdCDezbgFmejez8wQg== X-Received: by 2002:a2e:2d12:0:b0:2ec:3180:d4f7 with SMTP id 38308e7fff4ca-2ec5b3460f7mr36941741fa.26.1719309312317; Tue, 25 Jun 2024 02:55:12 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:bd71:2ff1:592d:f52a? ([2a01:e0a:982:cbb0:bd71:2ff1:592d:f52a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-424817b53f2sm172394305e9.25.2024.06.25.02.55.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jun 2024 02:55:11 -0700 (PDT) Message-ID: Date: Tue, 25 Jun 2024 11:55:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH] arm64: dts: amlogic: ad402: fix thermal zone node name To: Dmitry Rokosov Cc: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240624-topic-amlogic-upstream-bindings-fixes-dts-round-2-v1-1-0a21f456eb8d@linaro.org> <1ad3429c-0bad-4662-bc9d-b912f88e7b3a@kernel.org> <4c4c7840-917e-4d00-b8a4-b97a01ca2e6a@linaro.org> <20240625095210.mnwer2d3bc5wkits@CAB-WSD-L081021> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20240625095210.mnwer2d3bc5wkits@CAB-WSD-L081021> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240625_025516_173635_13D88C53 X-CRM114-Status: GOOD ( 17.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 25/06/2024 11:53, Dmitry Rokosov wrote: > Hello Neil and Krzysztof, > > Before posting any commit I've running dt_binding_check and dtbs_check. > Which target should highlight the errors like mentioned in this fix? > Please advise what I'm doing wrong. > > My commands: > > $ /usr/bin/make ARCH=arm64 INSTALL_MOD_PATH=$ROOT/out/$TARGET/target CROSS_COMPILE="$ROOT/out/$TARGET/host/bin/aarch64-buildroot-linux-gnu-" DEPMOD=$ROOT/out/$TARGET/host/sbin/depmod INSTALL_MOD_STRIP=1 -C $ROOT/out/$TARGET/build/linux-custom dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/example_device.yaml > $ /usr/bin/make ARCH=arm64 INSTALL_MOD_PATH=$ROOT/out/$TARGET/target CROSS_COMPILE="$ROOT/out/$TARGET/host/bin/aarch64-buildroot-linux-gnu-" DEPMOD=$ROOT/out/$TARGET/host/sbin/depmod INSTALL_MOD_STRIP=1 -C $ROOT/out/$TARGET/build/linux-custom dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/example_device.yaml Thus should work, but I use: make ARCH=arm64 DTBS_CHECK=y $(cd arch/arm64/boot/dts; find amlogic/ -name "*.dts" | sed "s/dts/dtb/") to only check amlogic dtbs. Neil > > On Mon, Jun 24, 2024 at 11:45:51AM +0200, Neil Armstrong wrote: >> On 24/06/2024 11:28, Krzysztof Kozlowski wrote: >>> On 24/06/2024 10:59, Neil Armstrong wrote: >>>> Fixes the following: >>>> thermal-zones: 'soc_thermal' does not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$', 'pinctrl-[0-9]+' >>>> from schema $id: http://devicetree.org/schemas/thermal/thermal-zones.yaml# >>>> >>>> Fixes: 593ab951232b ("arm64: dts: amlogic: ad402: setup thermal-zones") >>>> Signed-off-by: Neil Armstrong >>>> --- >>>> arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts b/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts >>>> index 6883471a93b4..0d92f5253b64 100644 >>>> --- a/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts >>>> +++ b/arch/arm64/boot/dts/amlogic/meson-a1-ad402.dts >>>> @@ -86,7 +86,7 @@ vddio_1v8: regulator-vddio-1v8 { >>>> }; >>>> thermal-zones { >>>> - soc_thermal: soc_thermal { >>>> + soc_thermal: soc-thermal { >>> >>> I was fixing all underscores... but then mentioned above commit >>> re-introduced them. >> >> Sorry about that, I'm removing all dtbs check errors, so I'll be able to spot >> this before merging anything now ! >> >>> >>> Some fixes need to be done more than once to stick. :) >>> >>> Reviewed-by: Krzysztof Kozlowski > >>> Best regards, >>> Krzysztof >>> >> >> Thanks, >> Neil >