From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F271C433EF for ; Sat, 16 Apr 2022 16:59:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FAIE4uKF0kgZI87rZUcOE6QYVrEnoINP1LLSmbcjUBw=; b=tfOKjjLh0iNT9a syUKQ2CGvBzLNf3H6vnf9CCQr4WYUCBowGpTOt6svS0NR+Mh7i+xv7rxM2ciIm6tkrYoF35/wCZoW g4qLWbDzPgqh5ixc6qGdOMvdlKeR1MvlO6auFlO7/Y2TO9hQ68fG8v65cP+eQZx5Z6zixdxxx+5cA fV4N9NrfVF8szC4WlTYIHXO63OQeq2TvffE8WGRoLtfFJWuSICRSMPlKfHeE8+r+VxCYvzipua1Pc ozkilGbA++1fC2QW089DA9YtVXtbqf9mcYsOP5yGMQAs2hQ9UUEmmpoa0CiVz4Ro7rx46H4lbE6xZ QpcrLpJM+yekwG184uzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfll5-00DGxG-Uo; Sat, 16 Apr 2022 16:58:52 +0000 Received: from relay3.hostedemail.com ([64.99.140.34]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfll1-00DGwE-HV for linux-arm-kernel@lists.infradead.org; Sat, 16 Apr 2022 16:58:49 +0000 Received: from omf06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 112E5223DA; Sat, 16 Apr 2022 16:58:43 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf06.hostedemail.com (Postfix) with ESMTPA id 42FA32000E; Sat, 16 Apr 2022 16:58:41 +0000 (UTC) Message-ID: Subject: Re: [PATCH v4 2/5] fpga: fix for coding style issues From: Joe Perches To: Nava kishore Manne , mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, trix@redhat.com, michal.simek@xilinx.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, git@xilinx.com Date: Sat, 16 Apr 2022 09:58:40 -0700 In-Reply-To: <20220416133719.3382895-3-nava.manne@xilinx.com> References: <20220416133719.3382895-1-nava.manne@xilinx.com> <20220416133719.3382895-3-nava.manne@xilinx.com> User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 X-Stat-Signature: 5iasq51u9gsrfia9ayz48s37ztk95x9o X-Rspamd-Server: rspamout02 X-Rspamd-Queue-Id: 42FA32000E X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX18NXzAwtfsG6VD8cMuiMu8V8tvZafI+GT8= X-HE-Tag: 1650128321-724278 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220416_095847_684431_DB6536AA X-CRM114-Status: GOOD ( 14.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 2022-04-16 at 19:07 +0530, Nava kishore Manne wrote: > fixes the below checks reported by checkpatch.pl > Lines should not end with a '(' > Alignment should match open parenthesis in fpga-mgr: Another possibillty would be to change the function arguments and in fpga-region: Ideally keep the include declaration and definition styles synced Perhaps: --- drivers/fpga/fpga-mgr.c | 13 ++++++++----- drivers/fpga/fpga-region.c | 6 +++--- include/linux/fpga/fpga-region.h | 6 +++--- 3 files changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c index d49a9ce34568..c65b97450a67 100644 --- a/drivers/fpga/fpga-mgr.c +++ b/drivers/fpga/fpga-mgr.c @@ -148,12 +148,15 @@ static int fpga_mgr_write_init_buf(struct fpga_manager *mgr, int ret; mgr->state = FPGA_MGR_STATE_WRITE_INIT; - if (!mgr->mops->initial_header_size) - ret = fpga_mgr_write_init(mgr, info, NULL, 0); - else - ret = fpga_mgr_write_init( - mgr, info, buf, min(mgr->mops->initial_header_size, count)); + if (mgr->mops->initial_header_size) { + count = min(mgr->mops->initial_header_size, count); + } else { + buf = NULL; + count = 0; + } + + ret = fpga_mgr_write_init(mgr, info, buf, count); if (ret) { dev_err(&mgr->dev, "Error preparing FPGA for writing\n"); mgr->state = FPGA_MGR_STATE_WRITE_INIT_ERR; diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c index b0ac18de4885..485948e3c0db 100644 --- a/drivers/fpga/fpga-region.c +++ b/drivers/fpga/fpga-region.c @@ -18,9 +18,9 @@ static DEFINE_IDA(fpga_region_ida); static struct class *fpga_region_class; -struct fpga_region *fpga_region_class_find( - struct device *start, const void *data, - int (*match)(struct device *, const void *)) +struct fpga_region * +fpga_region_class_find(struct device *start, const void *data, + int (*match)(struct device *, const void *)) { struct device *dev; diff --git a/include/linux/fpga/fpga-region.h b/include/linux/fpga/fpga-region.h index 3b87f232425c..9d4d32909340 100644 --- a/include/linux/fpga/fpga-region.h +++ b/include/linux/fpga/fpga-region.h @@ -52,9 +52,9 @@ struct fpga_region { #define to_fpga_region(d) container_of(d, struct fpga_region, dev) -struct fpga_region *fpga_region_class_find( - struct device *start, const void *data, - int (*match)(struct device *, const void *)); +struct fpga_region * +fpga_region_class_find(struct device *start, const void *data, + int (*match)(struct device *, const void *)); int fpga_region_program_fpga(struct fpga_region *region); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel