From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF39ED0E6C1 for ; Mon, 21 Oct 2024 07:57:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=58kG6E9taHK6TTsZfdidB/P2/Hcxp/vWM653t/Aj+tg=; b=ZaD/qE6zYkjwVfyps7LtbzejEp XpHckl60Gb37WBT+yMIkaXfIEnv0Go5J2JVyFJAzEKHOblXDwkIZ7ZGrr2mNgOGkkxgM50LscJM8C rscODzcRPK5Z0UE7AVeueSOgrpc5dhbCs39Fr4+3kH41Vwpn/Rl5qUwl+lu64ZEnJ65MWqhDoqdVM FUXwf5NhEY+JI7qzCuBVlEyxuTjE3jT4XtR7jEIFiMr50Xt3RhZhkmLzEjXkfs+lENVqzi4H/AGvv +vTMcWM8OjfeXB5iWZ5CTDsQ2P4AwK06KCnA/IQdayb9qY8ztwkZJHPBygsLaxEuwaw7PmIhDFbAU CzyXIFLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t2nHT-00000006SqC-45lE; Mon, 21 Oct 2024 07:56:47 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t2nA2-00000006RUr-0Dd9 for linux-arm-kernel@lists.infradead.org; Mon, 21 Oct 2024 07:49:07 +0000 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-43161c0068bso27366955e9.1 for ; Mon, 21 Oct 2024 00:49:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1729496944; x=1730101744; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=58kG6E9taHK6TTsZfdidB/P2/Hcxp/vWM653t/Aj+tg=; b=pXt4tAUvlfIrlcW0WUfbtvUrOj7Lw+/+CKBIahXhAwqyiX8/9NIPZtiIUrCJqJSc7i /RdGY8/utceG+JeHDhLAE22Td7YOgdaJxP5Z1ny5phRZPWAdG74Caopp4IUu0ix7cfbc XA6V64YlVstoNVm74enCz2WwKMLTveohtjrRXhEvPizUVe/bjjjy2m6mWxIIo+oMDgzC 4hf2nyidUb1y76NI4YSZxLmDjirX9n2GPEvguXM6e3VijJDCEd/Ncjm61mPKgQhnidwW E1HPm1KaRAOUbrvxf/QrviaJ8HS4FHPh8KU3n5RNG2UmdJOdXaFXyig8/5yAdHimwtfd wI1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729496944; x=1730101744; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=58kG6E9taHK6TTsZfdidB/P2/Hcxp/vWM653t/Aj+tg=; b=v7IH3ybrWEKbemaiRu2KTEsu/frgalPwJUadQockYdxyX0npelpRcr/D32YvsAySjH TRXAAuHght2niP7P6mJIvyj3saz9J9JQJzDZ9aqKwwjr+HuMF5UR9PMYCy8J5hgNOETO YJia6Z11MHiS5bo6E22V8M8DvVu0rB07ga1BuIA/6eTHSVDdHX8Z+4/RJXsN8GUe0j2I b+2wwqNCoQTp39A2h7PJWwAjZdsL26O4AXSSBIXcPHKotcyX1Ch/1Jo7cppJ+H5JYu7o f3DRTgHCCqN7ioLUPRbkFGeJpz8zVfMXKKnEkzp3XzTImpL6F9JzKPsOoWSUe6ZogHaG Ggdw== X-Forwarded-Encrypted: i=1; AJvYcCX2XiOA4YN0S7jMBhMZdMNMzvzfUFdU2epgc1OSfw/ImH5GId7AMaQ1LxESQ1BcU0iOHpJoCQfuDR4mT+1GKGfD@lists.infradead.org X-Gm-Message-State: AOJu0YyJVB4RubdngogAiox8gzRTdsF84gqJvaxWJfvXJe/ZesblCh0y BKcOSCRqvhchWJAXorKzJVHdoVnzid0dCi1BlEHbZBBsSsNf5LU/NIV8RoqOGaI= X-Google-Smtp-Source: AGHT+IFvgo6qt2vB4D+5CxWmwBneFTMm7VvkmB3DADmGjcvJnOJUVQG58Cd4uUg0J+6QI23+xFjXxA== X-Received: by 2002:a05:600c:4595:b0:431:3b53:105e with SMTP id 5b1f17b1804b1-4316163bccfmr91296875e9.9.1729496943898; Mon, 21 Oct 2024 00:49:03 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.23]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4316f5cc921sm47137075e9.46.2024.10.21.00.49.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Oct 2024 00:49:02 -0700 (PDT) Message-ID: Date: Mon, 21 Oct 2024 10:49:01 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 03/12] dt-bindings: clock: renesas,r9a08g045-vbattb: Document VBATTB Content-Language: en-US To: Krzysztof Kozlowski Cc: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, alexandre.belloni@bootlin.com, magnus.damm@gmail.com, p.zabel@pengutronix.de, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Claudiu Beznea References: <20241019084738.3370489-1-claudiu.beznea.uj@bp.renesas.com> <20241019084738.3370489-4-claudiu.beznea.uj@bp.renesas.com> <5fddjnvzu2e74rtmqw6o2w5upxn6dpih3hmdbgiky75qyuvyum@ilch2rahnmih> From: Claudiu Beznea In-Reply-To: <5fddjnvzu2e74rtmqw6o2w5upxn6dpih3hmdbgiky75qyuvyum@ilch2rahnmih> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241021_004906_127065_779FE6B5 X-CRM114-Status: GOOD ( 11.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21.10.2024 10:34, Krzysztof Kozlowski wrote: > On Mon, Oct 21, 2024 at 09:32:37AM +0200, Krzysztof Kozlowski wrote: >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> + #include >>> + #include >>> + #include >>> + #include >>> + >>> + clock-controller@1005c000 { >>> + compatible = "renesas,r9a08g045-vbattb"; >>> + reg = <0x1005c000 0x1000>; >>> + interrupts = ; >>> + clocks = <&cpg CPG_MOD R9A08G045_VBAT_BCLK>, <&vbattb_xtal>; >>> + clock-names = "bclk", "rtx"; >>> + assigned-clocks = <&vbattb VBATTB_MUX>; >>> + assigned-clock-parents = <&vbattb VBATTB_XC>; >> >> Why are you configuring internal clocks to internal parents? That's part >> internal to this device, not DTS... or at least some explanation would >> be useful. > > From DTS I see this belongs to the board, not SoC, so makes sense. That's true. This configuration depends on the type of the input clock connected to the RTXIN, RTXOUT pins which is board specific (see below diagram): +----------+ XC `\ RTXIN --->| |----->| \ +----+ VBATTCLK | 32K clock| | |----->|gate|-----------> | osc | XBYP | | +----+ RTXOUT --->| |----->| / +----------+ ,/ Thank you, Claudiu Beznea > > Best regards, > Krzysztof >