Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Lu Baolu <baolu.lu@linux.intel.com>,
	Kevin Tian <kevin.tian@intel.com>,
	Nicolin Chen <nicolinc@nvidia.com>,
	robin.murphy@arm.com, joro@8bytes.org, praan@google.com,
	mmarrid@nvidia.com, kees@kernel.org,
	Alexander.Grest@microsoft.com, smostafa@google.com,
	linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
	linux-kernel@vger.kernel.org, bbiber@nvidia.com,
	skaestle@nvidia.com
Subject: Re: [PATCH rc] iommu/arm-smmu-v3: Drain in-flight fault handlers
Date: Tue, 24 Mar 2026 14:35:14 +0000	[thread overview]
Message-ID: <acKhIh-s3pglUmEL@willie-the-truck> (raw)
In-Reply-To: <20260324141716.GB7340@nvidia.com>

On Tue, Mar 24, 2026 at 11:17:16AM -0300, Jason Gunthorpe wrote:
> On Tue, Mar 24, 2026 at 02:04:03PM +0000, Will Deacon wrote:
> > Sorry, that was sloppy terminology on my part. I'm trying to reason about
> > faults that are generated by accesses that were translated with the
> > page-tables of the old domain being reported once we think we are using
> > the new domain.
> 
> It doesn't matter.
> 
> If a concurrent fault is resolving on the old domain and it completes
> after the STE is in the new domain the device will restart and if the
> IOVA is still non-present it will refault. This is normal and fine.
> 
> If it is resolving on the new domain and the new domain has a present
> PTE so the PRI is spurious then the fault handler should NOP it and
> restart the device.

Hmm, I can see that working out if both domains expect faults, but if
I'm switching to a domain without a handler wouldn't I be better off
draining the outstanding faults generated on the old domain first?
Otherwise, won't we see a bunch of noise from the eventq thread as
it dumps unexpected events to the console?

Will


  reply	other threads:[~2026-03-24 14:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-07  0:17 [PATCH rc] iommu/arm-smmu-v3: Drain in-flight fault handlers Nicolin Chen
2026-03-12 13:51 ` Will Deacon
2026-03-12 14:25   ` Jason Gunthorpe
2026-03-24 14:04     ` Will Deacon
2026-03-24 14:17       ` Jason Gunthorpe
2026-03-24 14:35         ` Will Deacon [this message]
2026-03-24 18:53           ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acKhIh-s3pglUmEL@willie-the-truck \
    --to=will@kernel.org \
    --cc=Alexander.Grest@microsoft.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=bbiber@nvidia.com \
    --cc=iommu@lists.linux.dev \
    --cc=jgg@nvidia.com \
    --cc=joro@8bytes.org \
    --cc=kees@kernel.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarrid@nvidia.com \
    --cc=nicolinc@nvidia.com \
    --cc=praan@google.com \
    --cc=robin.murphy@arm.com \
    --cc=skaestle@nvidia.com \
    --cc=smostafa@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox