From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46863CF9C6C for ; Wed, 25 Sep 2024 06:19:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k9sz9F33oYRkRDljM840h89ujFz6JH+m4NCRZgOqIbc=; b=W75W/I0+BYi4T5MbX/buzmCEIP mMGWJtP9z5Z/NXNOMz/GbiY8zD77jikblMbHFmx0AsWuaAFu81lItjXYK6Emp2l1Ne4Xaj+fuTGBS aYyjgpfaqpkfvCjzJCn49fIo8uqXkyRjpjhc5izngI8OYruqw3ojo/Xgd+QtBgoC2bRsVz16f3PEc LQhkQBLxZvVgji3gb1ElDnPoLmfDwpOey6DOZkRO44mHcoJAP3XdJwzHfvhHt9vEMpd/gthr2WocN jRkirzzx2sqNY/+PDEJHyavM0TJ4fTDJskOmYjbJ1KINMbHFVaLhD1xJNTamBFA4w/aKOhmcfHPm2 17OI1f1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1stLNI-000000049is-2LV7; Wed, 25 Sep 2024 06:19:44 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1stLM7-000000049Vx-29UT; Wed, 25 Sep 2024 06:18:33 +0000 X-UUID: f985a3d47b0511efba0aef63c0775dbf-20240924 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date:Message-ID; bh=k9sz9F33oYRkRDljM840h89ujFz6JH+m4NCRZgOqIbc=; b=Nb9FQ3pZd7R57M3QBb0IvShsKUkFOEYWmOdm21WwZik4fMn8qDMaLhtlohyJW3S0E/V736xpVDQzcN3tdo3N3umWZGhuTkw+VWgBDs42B7h4P0sJLIhgScpumNl7iqhCoAsLZu9uLXn3gldGeojGyYUR4cdSRJeKotKTMaUSn3I=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.41,REQID:cd5c2939-ba12-4459-abc4-01c1c5cdb9bc,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:6dc6a47,CLOUDID:77cd3718-b42d-49a6-94d2-a75fa0df01d2,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0|-5,EDM:-3,IP:ni l,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES :1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: f985a3d47b0511efba0aef63c0775dbf-20240924 Received: from mtkmbs14n2.mediatek.inc [(172.21.101.76)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1643888056; Tue, 24 Sep 2024 23:18:26 -0700 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by MTKMBS14N1.mediatek.inc (172.21.101.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Wed, 25 Sep 2024 14:18:14 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Wed, 25 Sep 2024 14:18:14 +0800 Message-ID: Date: Wed, 25 Sep 2024 14:18:12 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 2/6] dt-bindings: iommu: mediatek: Fix interrupt count constraint for new SoCs Content-Language: en-US To: Conor Dooley , , Yong Wu CC: Chun-Kuang Hu , Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , "Krzysztof Kozlowski" , Conor Dooley , Yong Wu , Joerg Roedel , Will Deacon , Robin Murphy , Matthias Brugger , AngeloGioacchino Del Regno , , , , , , , Alexandre Mergnat , Bear Wang , Pablo Sun , Macpaul Lin , Sen Chu , Chris-qj chen , "MediaTek Chromebook Upstream" , Chen-Yu Tsai References: <20240924103156.13119-1-macpaul.lin@mediatek.com> <20240924103156.13119-2-macpaul.lin@mediatek.com> <20240924-haiku-drudge-79e5824d4b6f@spud> From: Macpaul Lin In-Reply-To: <20240924-haiku-drudge-79e5824d4b6f@spud> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-Product-Ver: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-AS-Result: No-10--6.588500-8.000000 X-TMASE-MatchedRID: QfHZjzml1E8OwH4pD14DsPHkpkyUphL9BGvINcfHqhdb6PBUqmq+UvQU BVrvaj2GVqzxHEDTg4yCIO7cu5PDkZShxRaS8Dn1EhGH3CRdKUUS12tj9Zvd8zRCaZSKE/Osl0B rH8BQUYUhXi7xgp14q38pRfXsZjabnEpyfsnNrVIzw5Ejs3g1lqIf1lfNT7ZiVxk27EKh25I+C9 E+fi6GeW7movz4+rjW78PdD37e4xy4aCSQ7hdJ78xmTzofEWOOazzS+36ix9ybKItl61J/ycnjL TA/UDoAA6QGdvwfwZZWRVlrjsKO8N0H8LFZNFG7CKFCmhdu5cXEsTcv4IYmcFuCpxJB4M3gJq70 pWlFtQWWbNCyNAdblyX6zonwXAPVNJ30o4E0TPxXF3PdlZlUCc0/jHJTVScj1iM9jSWVg5985c/ x1FQodgevtLgqnPLci7PEd0wIBlEj2EMHngcSkJ6oP1a0mRIj X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--6.588500-8.000000 X-TMASE-Version: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-SNTS-SMTP: BF41B72D588AEB07E4AC90B862252831A27D922EF92665FEF4C9BB815DD795142000:8 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240924_231831_598948_C479CD2A X-CRM114-Status: GOOD ( 22.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/25/24 00:02, Conor Dooley wrote: > On Tue, Sep 24, 2024 at 06:31:52PM +0800, Macpaul Lin wrote: >> The infra-iommu node in mt8195.dtsi was triggering a CHECK_DTBS error due >> to an excessively long 'interrupts' property. The error message was: >> >> infra-iommu@10315000: interrupts: [[0, 795, 4, 0], [0, 796, 4, 0], >> [0, 797, 4, 0], [0, 798, 4, 0], [0, 799, 4, 0]] >> is too long >> >> To address this issue, add "minItems: 1" and "maxItems: 5" constraints to >> the 'interrupts' property in the DT binding schema. This change allows for >> flexibility in the number of interrupts for new SoCs >> >> Fixes: bca28426805d ("dt-bindings: iommu: mediatek: Convert IOMMU to DT schema") >> > > This space should be removed. Thanks! Will fix it in the next version. >> Signed-off-by: Macpaul Lin >> --- >> Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml >> index ea6b0f5f24de..a00f1f0045b1 100644 >> --- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml >> +++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml >> @@ -96,7 +96,8 @@ properties: >> maxItems: 1 >> >> interrupts: >> - maxItems: 1 >> + minItems: 1 >> + maxItems: 5 > > You need to add an items list here, and probably some per compatible > constraints. What are each of the itnerrupts for? > According to Friday Yang's comment, The IOMMU of MT8195 has 5 banks: 0/1/2/3/4. Each bank has a set of APB registers corresponding to the normal world, protected world 1/2/3, and secure world, respectively. Therefore, 5 interrupt numbers are needed. >> >> clocks: >> items: >> -- >> 2.45.2 >> Will try to fix it and add some description for MT8195. I think this patch could be split as a separated patch from the origin patch set. It'll take some time to refine the patch. Thanks Macpaul Lin