Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@nxp.com>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Daniel Scally" <dan.scally@ideasonboard.com>,
	"Marco Felsch" <m.felsch@pengutronix.de>,
	"Gilles Talis" <gilles.talis@gmail.com>,
	"Viorel Suman" <viorel.suman@nxp.com>,
	"Shengjiu Wang" <shengjiu.wang@nxp.com>,
	"Jagan Teki" <jagan@amarulasolutions.com>,
	"Manoj Sai" <abbaraju.manojsai@amarulasolutions.com>,
	"Matteo Lisi" <matteo.lisi@engicam.com>,
	"Ray Chang" <ray.chang@technexion.com>,
	"Richard Hu" <richard.hu@technexion.com>,
	"Heiko Schocher" <hs@denx.de>,
	"Martyn Welch" <martyn.welch@collabora.com>,
	"Josua Mayer" <josua@solid-run.com>,
	"Goran Rađenović" <goran.radni@gmail.com>,
	"Börge Strümpfel" <boerge.struempfel@gmail.com>,
	"Christoph Niedermaier" <cniedermaier@dh-electronics.com>,
	"Marek Vasut" <marex@denx.de>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@dh-electronics.com,
	"Peng Fan" <peng.fan@nxp.com>,
	"Kieran Bingham" <kieran.bingham@ideasonboard.com>
Subject: Re: [PATCH v2 00/12] arm64: dts: imx8mp: Correct PAD settings for PMIC_nINT
Date: Fri, 27 Mar 2026 10:32:17 -0400	[thread overview]
Message-ID: <acaU8SPQ3aJkG808@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20260326-imx8mp-dts-fix-v2-v2-0-62c4ce727448@nxp.com>

On Thu, Mar 26, 2026 at 03:28:04PM +0800, Peng Fan (OSS) wrote:
> As reported in [1], there is interrupt storm for i.MX8MP DEBIX Model A.
> Per schematic, there is no on board PULL-UP resistors for GPIO1_IO03,
> so need to set PAD PUE and PU together to make pull up work properly.
>
> DEBIX Model SOM also has same issue as reported in [2].
>
> I gave a check on current i.MX8MP based boards, most boards have wrong
> PAD settings with PMIC_nINT. It is low level triggered interrupt.
> many boards only set PU, but PUE not set, so pull up not work properly.
>
> Patch 1 and 2 are to fix issue that confirmed by Laurent and  Kieran.
>
> I checked AB2 and NAVQ schematic, so these two boards are also having
> same issue.
>
> For other boards, I not able to find any public schematics. For per
> the DT settings(interrupt is configured LOW LEVEL trigger), so PMIC_nINT
> should be configured as PULL UP, per NXP reference design, there is no
> on-board resistors for PMIC_nINT, it counts on SoC internal PULL. So I think
> these boards are also having issues. But I use phase "there might be" in
> commit log.
>
> The last two patches, I think the PAD settings are wrong, but not sure
> they have interrupt storm issues, so just correct the settings.
>
> For imx8mp-skov-reva.dtsi, I am not sure whether it needs same fix, so
> not touch it.
>
> [1] https://lore.kernel.org/all/20260323105858.GA2185714@killaraus.ideasonboard.com/
> [2] https://lore.kernel.org/all/20260324194353.GB2352505@killaraus.ideasonboard.com/
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> Changes in V2:
>  - Fix more boards
>  - Drop preceding zero
>  - Link to v1: https://lore.kernel.org/all/20260324-imx8mp-dts-fix-v1-1-df0eb2f62543@nxp.com/
>
> ---
> Peng Fan (12):
>       arm64: dts: imx8mp-debix-model-a: Correct PAD settings for PMIC_nINT
>       arm64: dts: imx8mp-debix-som-a: Correct PAD settings for PMIC_nINT
>       arm64: dts: imx8mp-navqp: Correct PAD settings for PMIC_nINT
>       arm64: dts: imx8mp-ab2: Correct PAD settings for PMIC_nINT

This one squash to 7adad1a52c420 ("arm64: dts: imx8mp-ab2: add support for NXP i.MX8MP audio board (version 2)")
because it is still in my tree.

>       arm64: dts: imx8mp-icore-mx8mp: Correct PAD settings for PMIC_nINT
>       arm64: dts: imx8mp-edm-g: Correct PAD settings for PMIC_nINT
>       arm64: dts: imx8mp-aristainetos3a-som-v1: Correct PAD settings for PMIC_nINT
>       arm64: dts: imx8mp-nitrogen-som: Correct PAD settings for PMIC_nINT
>       arm64: dts: imx8mp-sr-som: Correct PAD settings for PMIC_nINT
>       arm64: dts: imx8mp-ultra-mach-sbc: Correct PAD settings for PMIC_nINT
>       arm64: dts: imx8mp-dhcom-som: Correct PAD settings for PMIC_nINT
>       arm64: dts: imx8mp-data-modul-edm-sbc: Correct PAD settings for PMIC_nINT

Other apply to 7.0 fixes branch. Thanks

Frank
>
>  arch/arm64/boot/dts/freescale/imx8mp-ab2.dts                    | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mp-aristainetos3a-som-v1.dtsi | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts     | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts          | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts     | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mp-debix-som-a.dtsi           | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mp-dhcom-som.dtsi             | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mp-edm-g.dtsi                 | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mp-icore-mx8mp.dtsi           | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mp-navqp.dts                  | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mp-nitrogen-som.dtsi          | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mp-sr-som.dtsi                | 4 ++--
>  arch/arm64/boot/dts/freescale/imx8mp-ultra-mach-sbc.dts         | 4 ++--
>  13 files changed, 15 insertions(+), 15 deletions(-)
> ---
> base-commit: 66ba480978ce390e631e870b740a3406e3eb6b01
> change-id: 20260326-imx8mp-dts-fix-v2-89ede7320c6a
>
> Best regards,
> --
> Peng Fan <peng.fan@nxp.com>
>


      parent reply	other threads:[~2026-03-27 14:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26  7:28 [PATCH v2 00/12] arm64: dts: imx8mp: Correct PAD settings for PMIC_nINT Peng Fan (OSS)
2026-03-26  7:28 ` [PATCH v2 01/12] arm64: dts: imx8mp-debix-model-a: " Peng Fan (OSS)
2026-03-26  7:28 ` [PATCH v2 02/12] arm64: dts: imx8mp-debix-som-a: " Peng Fan (OSS)
2026-03-26  7:28 ` [PATCH v2 03/12] arm64: dts: imx8mp-navqp: " Peng Fan (OSS)
2026-03-26  7:28 ` [PATCH v2 04/12] arm64: dts: imx8mp-ab2: " Peng Fan (OSS)
2026-03-26  7:28 ` [PATCH v2 05/12] arm64: dts: imx8mp-icore-mx8mp: " Peng Fan (OSS)
2026-03-26  7:28 ` [PATCH v2 06/12] arm64: dts: imx8mp-edm-g: " Peng Fan (OSS)
2026-03-26  7:28 ` [PATCH v2 07/12] arm64: dts: imx8mp-aristainetos3a-som-v1: " Peng Fan (OSS)
2026-03-26  7:28 ` [PATCH v2 08/12] arm64: dts: imx8mp-nitrogen-som: " Peng Fan (OSS)
2026-03-26  7:28 ` [PATCH v2 09/12] arm64: dts: imx8mp-sr-som: " Peng Fan (OSS)
2026-03-26  8:58   ` Laurent Pinchart
2026-03-26  9:55     ` Peng Fan
2026-03-26 12:33       ` Josua Mayer
2026-03-26  7:28 ` [PATCH v2 10/12] arm64: dts: imx8mp-ultra-mach-sbc: " Peng Fan (OSS)
2026-03-26  7:28 ` [PATCH v2 11/12] arm64: dts: imx8mp-dhcom-som: " Peng Fan (OSS)
2026-03-26  7:28 ` [PATCH v2 12/12] arm64: dts: imx8mp-data-modul-edm-sbc: " Peng Fan (OSS)
2026-03-27 14:32 ` Frank Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acaU8SPQ3aJkG808@lizhi-Precision-Tower-5810 \
    --to=frank.li@nxp.com \
    --cc=abbaraju.manojsai@amarulasolutions.com \
    --cc=boerge.struempfel@gmail.com \
    --cc=cniedermaier@dh-electronics.com \
    --cc=conor+dt@kernel.org \
    --cc=dan.scally@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=gilles.talis@gmail.com \
    --cc=goran.radni@gmail.com \
    --cc=hs@denx.de \
    --cc=imx@lists.linux.dev \
    --cc=jagan@amarulasolutions.com \
    --cc=josua@solid-run.com \
    --cc=kernel@dh-electronics.com \
    --cc=kernel@pengutronix.de \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=krzk+dt@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=marex@denx.de \
    --cc=martyn.welch@collabora.com \
    --cc=matteo.lisi@engicam.com \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=ray.chang@technexion.com \
    --cc=richard.hu@technexion.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=shengjiu.wang@nxp.com \
    --cc=viorel.suman@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox