From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DB72C433DF for ; Tue, 16 Jun 2020 20:20:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC40520739 for ; Tue, 16 Jun 2020 20:20:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jnfmIM0V"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N81wUKNP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC40520739 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O2V13+sq2lpKdDBqgSJEBHREyqVlsNfv5DSjXAsE6EI=; b=jnfmIM0VK82AfN ZKIfdvTkrjt3RMuVhKUE+Tv/2i2GIsxwVbdQIbHt4PTdMZ6yVFM+CTi2aOLynmfKj3xTmVGCpy0Lw jm6/7xPLm7MuzAzk/u+y8XFaTYR76NxXGionPX0754Wr6XKWlWaYxEKyy76e18MR5LUtyHABTzWz7 HAk0SxZJ0bz3S/4b814j6x98mTM3XLPEMqNKQJEPjwDUUxor1Nkl3iLCpTI7Jk6U6jioszzJ7yGVt G6IgJK/MqC63wWSJLG9+YBq6sb8U/yX/krq99OHh6tK/G1c0DPPRHxwf8gZ0EKTn2iGkiefVlgLHl oR6ng2KLY/bqyPq/fljQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jlI3w-0005xC-ML; Tue, 16 Jun 2020 20:20:04 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jlI3t-0005Mt-0r for linux-arm-kernel@lists.infradead.org; Tue, 16 Jun 2020 20:20:02 +0000 Received: by mail-wm1-x344.google.com with SMTP id c71so4069409wmd.5 for ; Tue, 16 Jun 2020 13:19:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3wFm9ppO8ULkxiCADJKRnXA2iDnjr8ZjowAIpexl/Hc=; b=N81wUKNPQIZUxYmgUDgnPT/wwOQ2Xk7LebNpYpXXzRQPKKBe9DdvyeRK31obFJjroO zS8w1RE2w04XzBodYo9FCnghtQ0ona725X6rYAfrpPePssH0Fkm4TR9TYbcjsc2A+AX1 e2OB7Idnj7AwlP6OLaY/Je77kZmqr2ylq2TTvZwE0ETfXY0XoAgwd24WHg/2WB+ixAL0 jxTt81dtKTKfmJwldzEpoOeca8EQQjwCQGFx1sY8D7JK+BIADYT2Zi0Q81hD8xH98ZF1 pv6Gcg2qp/ZTIFu0bRidEGUZmB4OfAf1adxMZSVcM0PkJGdtBobDeocd26fA+iWz8FEQ /zWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3wFm9ppO8ULkxiCADJKRnXA2iDnjr8ZjowAIpexl/Hc=; b=pWuiw9qBDpsbGmn7InbJ321nS5/OGYY+2RIJqMKyV1waSeviAyZQAIe8ndODcp6euv lg+kSCnByDj24x5sfSKBEdjZ4k8SLr6JxREV+vNIFqTMeInTwIcRZ5l47OJA2jWUcLKa +9R7jJIkl3UquuctGP5cb3fOaf/naZ3jSeS0AeM5GCSreddfAdv8zGTl2quzF5SThLEa TOEFrfTPcMftJApMkU7K5XFfVL85t67pQP6W3unIKr9hiUDzEQMEqyPdok2zjEfv/W8y 6yJAobw3dBkAkwsiUe7/tYOyRjnLsr8InjFqpcX8ERFRBnN1c2Opot8MWSVTzgIi59nI ndwg== X-Gm-Message-State: AOAM533880pbSCBO5OfAnZeAGsHjlogVmaiYq9a3jt+L1NXYLSW9CPsf ETa/aZA2xkvAuQ/VksXi5DH8KgFW X-Google-Smtp-Source: ABdhPJwTLjwBRYfFzDikwfA1l4lRZVBR11j6vEk91mXAzf1GLkWmxFGBWFgj3BG3+hwuJCDXmu9Hqg== X-Received: by 2002:a1c:22d7:: with SMTP id i206mr4862866wmi.186.1592338797117; Tue, 16 Jun 2020 13:19:57 -0700 (PDT) Received: from localhost.localdomain (haganm.plus.com. [212.159.108.31]) by smtp.gmail.com with ESMTPSA id i10sm29871318wrw.51.2020.06.16.13.19.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2020 13:19:56 -0700 (PDT) Subject: Re: [PATCH 2/3] ARM: dts: NSP: Correct amac_base lengths, mailbox reg and add amac3 To: Florian Fainelli References: From: Matthew Hagan Message-ID: Date: Tue, 16 Jun 2020 21:19:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200616_132001_084163_896DCD64 X-CRM114-Status: GOOD ( 21.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Scott Branden , Ray Jui , Russell King , Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14/06/2020 23:28, Florian Fainelli wrote: > > > On 6/9/2020 9:58 AM, Matthew Hagan wrote: >> According to gmac/src/et/sys/et_linux.c, IORESOURCE_MEM end address for each >> mac is IPROC_GMACx_REG_BASE+0xbff. > > The datasheet shows an entire GMAC to end at 0x1000 from its base offset > which is likely what was used to construct this DTS, I do not believe > this is a functional change, and if we look at the register details, the > last register starts at 0xb44 so 0xc00 is giving a little bit of > headroom. In practice it does not change anything since you are still > going to need a full 4KB page frame to map the registers. > >> >> The FA2 mailbox is specified at 0x18025000 but should actually be 0x18025c00, >> length 0x400 according to socregs_nsp.h and board_bu.c. amac3 is at 25000. > > Yes, FA2 definitively start 0x18025c00, and ends 0x400 later, so I did > split this patch in three patches: > > - one that fixes the FA2 base address, which can be queued to stable > kernel branches > - one that changes the AMAC register size > - one that adds the AMAC3 Since AMAC3 has been added with interrupt 150, should the mailbox interrupt not also be incremented to 151? > > Such that the first patch can be queued for -stable fixes, whereas the > other two, not being functional changes are candidates for devicetree/next. > > Result here: > > https://github.com/Broadcom/stblinux/commits/devicetree/next > > Thanks! > Thanks, Matthew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel