linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: vzapolskiy@gmail.com (Vladimir Zapolskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] [ARM] [IMX]: Removed superfluous checks for argument validity.
Date: Wed, 17 Mar 2010 13:34:50 +0300	[thread overview]
Message-ID: <acc484891003170334p133ee328y2d1b17533b672ac5@mail.gmail.com> (raw)
In-Reply-To: <20100317091349.GA16150@pengutronix.de>

Hello Uwe,

__clk_enable() and __clk_disable() are recursive with another arguments,
that means it is hardly possible to remove the checks from them.

2010/3/17 Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>

> Hello Vladimir,
>
> On Wed, Mar 17, 2010 at 10:11:55AM +0300, Vladimir Zapolskiy wrote:
> > The checks for clk argument are doubled in __clk_disable() and
> > __clk_enable() functions and thus may be skipped in clk_disable() and
> > clk_enable() bodies.
> Maybe better get rid of the test in __clk_{en,dis}able, as these are
> called more often?  Actually I think even a WARN_ON(clk == NULL ||
> IS_ERR(clk)) would be OK.
>
> Best regards
> Uwe
>
> With best wishes,
Vladimir
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100317/08a7f91b/attachment-0001.htm>

  reply	other threads:[~2010-03-17 10:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-17  7:11 [PATCH 1/2] [ARM] [IMX]: Removed superfluous checks for argument validity Vladimir Zapolskiy
2010-03-17  7:11 ` [PATCH 2/2] [ARM] [IMX]: Fix clock usecount counter from underflow Vladimir Zapolskiy
2010-03-17  9:20   ` Uwe Kleine-König
2010-03-17 10:15     ` javier Martin
2010-03-17 10:57       ` Vladimir Zapolskiy
2010-03-17 11:03     ` [PATCH 2/2 v2] [ARM] [IMX]: Fix clock use counter from underflow on multiple clk_disable() Vladimir Zapolskiy
2010-03-18  8:30       ` Uwe Kleine-König
2010-03-18 13:21         ` Vladimir Zapolskiy
2010-03-17  9:13 ` [PATCH 1/2] [ARM] [IMX]: Removed superfluous checks for argument validity Uwe Kleine-König
2010-03-17 10:34   ` Vladimir Zapolskiy [this message]
2010-03-18  8:37     ` Uwe Kleine-König
2010-03-18 13:07       ` Vladimir Zapolskiy
2010-03-18 13:27       ` [PATCH 1/2 v2] imx: optimize __clk_enable() and __clk_disable() functions Vladimir Zapolskiy
2010-03-18 14:23         ` Vladimir Zapolskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acc484891003170334p133ee328y2d1b17533b672ac5@mail.gmail.com \
    --to=vzapolskiy@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).