Re: [PATCH net-next v2 00/14] net: stmmac: TSO fixes/cleanups

Andrew Lunn
2026-04-01T12:36:52Z

> I'm moving the setup of the GSO features, cleaning those up, and
> adding a warning if platform glue requests this to be enabled but the
> hardware has no support. Hopefully this will never trigger if everyone
> got the STMMAC_FLAG_TSO_EN flag correct.

Is this:

snps,tso:
$ref: /schemas/types.yaml#/definitions/flag
description:
Enables the TSO feature otherwise it will be managed by MAC HW capability
register.

I would not be too surprised if there is cargo cult copy/paste going
on and some do get it wrong.

arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi: snps,tso;
arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi: snps,tso;
arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi: snps,tso;
arch/arm64/boot/dts/toshiba/tmpv7708.dtsi: snps,tso;
arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi: snps,tso;
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi: snps,tso;
arch/arm64/boot/dts/rockchip/rk3576.dtsi: snps,tso;
arch/arm64/boot/dts/rockchip/rk3576.dtsi: snps,tso;
arch/arm64/boot/dts/rockchip/rk3568.dtsi: snps,tso;
arch/arm64/boot/dts/rockchip/rk3528.dtsi: snps,tso;
arch/arm64/boot/dts/rockchip/rk3528.dtsi: snps,tso;
arch/arm64/boot/dts/rockchip/rk356x-base.dtsi: snps,tso;
arch/arm64/boot/dts/qcom/qcs404.dtsi: snps,tso;
arch/arm64/boot/dts/qcom/lemans.dtsi: snps,tso;
arch/arm64/boot/dts/qcom/lemans.dtsi: snps,tso;
arch/arm64/boot/dts/qcom/sm8150.dtsi: snps,tso;
arch/arm64/boot/dts/qcom/sc8280xp.dtsi: snps,tso;
arch/arm64/boot/dts/qcom/sc8280xp.dtsi: snps,tso;
arch/arm64/boot/dts/qcom/monaco.dtsi: snps,tso;
arch/arm64/boot/dts/st/stm32mp253.dtsi: snps,tso;
arch/arm64/boot/dts/st/stm32mp233.dtsi: snps,tso;
arch/arm64/boot/dts/st/stm32mp231.dtsi: snps,tso;
arch/arm64/boot/dts/st/stm32mp251.dtsi: snps,tso;
arch/riscv/boot/dts/sophgo/sg2042.dtsi: snps,tso;
arch/riscv/boot/dts/sophgo/sg2044.dtsi: snps,tso;
arch/riscv/boot/dts/starfive/jh7110.dtsi: snps,tso;
arch/riscv/boot/dts/starfive/jh7110.dtsi: snps,tso;
arch/arm/boot/dts/axis/artpec6.dtsi: snps,tso;
arch/arm/boot/dts/rockchip/rv1126.dtsi: snps,tso;
arch/arm/boot/dts/st/stm32mp131.dtsi: snps,tso;
arch/arm/boot/dts/st/stm32mp133.dtsi: snps,tso;
arch/arm/boot/dts/st/stm32mp151.dtsi: snps,tso;

Andrew