From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD301C433E2 for ; Mon, 7 Sep 2020 09:18:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 604142078E for ; Mon, 7 Sep 2020 09:18:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="u5dJf06v"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="br9kTLMS"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="jBIcNwty" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 604142078E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/3Axx/IKgnTGhYt1OIKuhjwMPTrLnkiOnssiA5Vi8eM=; b=u5dJf06v58IC1TsHzbg2eBF04 lowrrCHbKPzcWTS8C8iv1TIFmj75F0QFFvJWsTN+n/rekktIyZnOK3fFeJrK+Cy8UkRIgm0VBnLdv MH5X89xwwFw7vjG1Z/NDMOd9NoXfmKe3GMU/AHOWqap7xwhaMG3hqpT6y+NtwIsFwffiMgqnYIJ8i 5qWyN/7naa6Wn52o7MqcOQnS3BEBf9/IK7WtN91c7skWekXCDoEHaZ9uTIRgpVrnQfR6/arAL8Uyd YonQykiuizbW+kbifp067y4Z3oyuZHhygUEmRMXWJeZUPFI+uWsgJoVYHjCkE3nOzqc1aBLrrnw/V +Enfq3YVg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFDGx-0001Kx-2v; Mon, 07 Sep 2020 09:17:11 +0000 Received: from esa4.microchip.iphmx.com ([68.232.154.123]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFDGq-0001Ic-9t for linux-arm-kernel@lists.infradead.org; Mon, 07 Sep 2020 09:17:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1599470224; x=1631006224; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=wA723HqO3WncHSNqAUyxI0kCShkemxzj/fpkkitaCG8=; b=br9kTLMSLVo+SCcYyDSigcgtzr0fIjHngdQAeLSxQ+7tosBrtAJmE6C3 uHWkFGJRr2DbummmqRN+Nk7b+51EEIeCJd3H2mTZlbFl2nEgFLyaAKm79 0y0d6+YflR/UDcTEB3b5bY4eZ1CiSe9WBUrxw6Ig7cYZgdLhfrXL22uOy LqG8xBH7J2I+Zzb/cHpSauGP4uT6JXJ8lLf7VkS9ZGc7iFFRxkc3qzA8j CBsYwYXqrX0fCnyXl/MqaMq/Dd3cSTIW9rN9aSrxA90jKU61b7a+a3EDN Yg5Brxt5ssCjcnf3C7Ta/A3WM2VaHOY88+tcwRmrk+v8ihgPpZXjiBVfy A==; IronPort-SDR: KYR0CiC3jRbG53ZtZ2Y3bJubEV+WvTfSoCFo5+hO/qb8nSbPUpUkmIbRl35/qGzLNBtQLzwECe cYcYsABaCc+RNLWPL9sW8oDKZK9f0sKSuSHz+0tcf2bjIFwpWhitZHpbfra8WLpmacfWH74bsn mKxbDVkHHwNkGxrP9wYA5YJFX8YbkRXo9TR1ONepTcMjixjbBvPFwYq66g5E/MIoK5SZyckuWN +sZZ5/LjoWtEJ7sUL7PYbxX+2t5deZVfnk5DknrY2w6iMWpqrPl6igE4HHEIBPKNSfGnqeGtoV Zpc= X-IronPort-AV: E=Sophos;i="5.76,401,1592895600"; d="scan'208";a="86039770" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 07 Sep 2020 02:17:00 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Mon, 7 Sep 2020 02:16:35 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3 via Frontend Transport; Mon, 7 Sep 2020 02:16:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iy7kjlu4oqXwXwaUweiDyMxyMgXOvmfkhfaCxK8dUdcLmyQwa/nRDc9ngUvLDmpO9dtrCxiPaRgLkFSK8U86lJQjLnEmvJAMl2N8B2qGw4g+OV/Kh1aXvZKnHOgARwM4UwXF32x8xdLYAjFuM6Wp1us/jW1kcmWsdfJiyOwA1uphaqzcPA1beY5KWKAYPDtb2aCA6aFKmVN2SjAczL2Nui/xnetRIJ+WzedlNgDrg7g5uLqXinC6DD60XsjbV2XnZJU+Mc1Ze0+vxCG86RFpsNwLWgjTiLczoxjVl3RkQBMGTJFnYDpQZy+R6qdPgU44Z79qdf6gMoy0VFhbw68D8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wA723HqO3WncHSNqAUyxI0kCShkemxzj/fpkkitaCG8=; b=EofAj7gtlHU8IRYSjk3IDN7qQe4h4hvqnUfaiq9PWoJFizX6dRVV0+oeIQzUfIzM5wtWA2doVlBpePC46pM2q5bUpiqO+LqYVBm9uztYkbPU5oNtX+eT98gftbkUtIHOAuY9Q56dDpp0DvDRp3BiSEIgE+u5xd3Ff14rK9JvK6y0/G5YVTeeFd8q+XlOOpjcHjIG1N3aft4HKn0QGd0gcxC0nCA9ZwuieRwuaGA7PdwK6l4Vy5voxZU1gIe1zvxryLykIfnhYKHlijr8WWCIy2FR3u85iZIoAKUOABhx+orXT3RiSBYfsDeuIJXg4oL9Vlcvk/6H9W0HoSqJLXcxyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wA723HqO3WncHSNqAUyxI0kCShkemxzj/fpkkitaCG8=; b=jBIcNwtyJlmagx+y4o2hdtVRqE/vzxWqdaujzUL+0sViZ6fAK+tIs1oOy6BBYR2g/7ekduet438Q40CtFqzaTK4PpGgPdc0m8to3eNvn1phqnNlCY89Wz4S9/bSfmA48e+zEhy9tstM9uf5AJUV7uj9Q3/oAtIa4mLZT1LRSQ5Q= Received: from BYAPR11MB2999.namprd11.prod.outlook.com (2603:10b6:a03:90::17) by BYAPR11MB3494.namprd11.prod.outlook.com (2603:10b6:a03:86::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.15; Mon, 7 Sep 2020 09:16:57 +0000 Received: from BYAPR11MB2999.namprd11.prod.outlook.com ([fe80::3956:c6f:11a4:b79]) by BYAPR11MB2999.namprd11.prod.outlook.com ([fe80::3956:c6f:11a4:b79%7]) with mapi id 15.20.3348.015; Mon, 7 Sep 2020 09:16:57 +0000 From: To: Subject: Re: [PATCH v3 2/3] media: atmel: introduce microchip csi2dc driver Thread-Topic: [PATCH v3 2/3] media: atmel: introduce microchip csi2dc driver Thread-Index: AQHWe3V9RwslavJrYkuDX2boZhbxY6lR8KWAgAsHsoA= Date: Mon, 7 Sep 2020 09:16:57 +0000 Message-ID: References: <20200826065142.205000-1-eugen.hristev@microchip.com> <20200826065142.205000-2-eugen.hristev@microchip.com> <20200831085031.GB844@valkosipuli.retiisi.org.uk> In-Reply-To: <20200831085031.GB844@valkosipuli.retiisi.org.uk> Accept-Language: en-US, ro-RO Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 authentication-results: iki.fi; dkim=none (message not signed) header.d=none;iki.fi; dmarc=none action=none header.from=microchip.com; x-originating-ip: [188.27.154.227] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ccc2fe02-c978-4ae1-366e-08d8530ec548 x-ms-traffictypediagnostic: BYAPR11MB3494: x-microsoft-antispam-prvs: x-bypassexternaltag: True x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xcNXYgtVCTofL8XNozIwU2DTKZch5gsaOjlTeHNxJRaJqGlUSUee9LD0xiZVgOeZJ8G9jOHi9fc9zBLrTGk+sJvsAPeHkvQRc00NdYatTDK3eIZvkyB+eeIf3VbnHxStzdFbv5OAP3UrHHMmsQcLdes9u1hkiSil7xCB0TGkVBREfzw/7fjNBegvMLuGjFnhBEYYMt2LZ9Cn5wge5GWW14iJwH3sk9GFvzwg0X4YOtEDMeopOqj13HXCan93rzjIEOLjMkDZfy/vzoWoHPC6rzmBO4S1pLb0vppRwrHVEwO6B29g6cNcIrGAZAoYE4C0k5XjFLF225lhbJ+ZL0V3HoH8rES99ITrgqDCO5CNXghm5hQH71vvOJtwv1RpBsn31FXlw7OMCnqOcEK4IlSc/HYolXQcQI3oVbIDrfuhgkA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB2999.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(136003)(39860400002)(376002)(396003)(346002)(26005)(2616005)(186003)(2906002)(86362001)(54906003)(83380400001)(36756003)(316002)(30864003)(4326008)(6512007)(31696002)(76116006)(8936002)(64756008)(478600001)(6486002)(6916009)(5660300002)(66446008)(31686004)(91956017)(6506007)(66476007)(71200400001)(53546011)(8676002)(66946007)(66556008)(461764006)(43740500002)(559001)(579004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: XokJANnhr/JEcZUISHYK4l5W52xj2lk9xoVeXywsCS3auBLjPKT9aTEFGo5jQvXpKVP85TjdR54zbuxMxiMsvnCPV10Edw/KcDkX3ZNe4H5d0l4cN3YodvWOEDtG+/3N1+qKDYWgZwCIobtDq0VaHzAe5ujdScAJeQyEAP+JLfHa+ZvAEqi+5HO0W0p0Jr/ZtHB7VcJzxsx4jRLszlJ386p1IcVGbe8z82O5YRQ5ggVx6b+/kI4ldKCWJ1GL+8t+sOnLbnZ5OERF0PT0cLSDAo0kVJL1Lka/wq9RkTdkMaIjonZPlLOowDODOPTf/pyEG97qCjmnrZN38QEMyynRmH+zymbr7vCaUkyXHiqjiXGZvLAbhRtgP1cpK2XFkKMcA19GaANV+je58fyj7YhQnWCZ2O5Du7OBIl5+2UwW5uy+1M70c/aiM2XOcgwLTh8FBqjMemsMCrvf2VRz2wjPWnBQNBuWmte5T9+yTnH7+BoWHd/oxYJF4HILkWRhwbh+RSxx+VgiVnXC3d3ZtkWSAR16Khqz/eygHZhgswBG7RWhh992VHpHE6UouP2+yAf0vVlnbdPTlSlG27ygkEdhdK74mXT20eq4X4duXlCdYV2kNSEVop4CoVKlphrKAPP9x+DTpAhGaymrEma+68OqTA== x-ms-exchange-transport-forked: True Content-ID: <870928CBFA4CA946BF19908ACD83FC5F@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB2999.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ccc2fe02-c978-4ae1-366e-08d8530ec548 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2020 09:16:57.5727 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yODmFxAueRHPee7wAIHEVnflQQENn4LiUrQq17gbruLNbyHxiBDbzAGPTWAsx2h0zIbsGgQ/YCJlxLaG8r7hfJ2pe9YzZBbP2ebbolmGd74= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3494 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200907_051704_779424_0D62ECA7 X-CRM114-Status: GOOD ( 20.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, robh+dt@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 31.08.2020 11:50, Sakari Ailus wrote: > Hi Eugen, > > Thanks for the update. Hi Sakari, Thanks for reviewing, but, could you please help me understand your review below ? > > On Wed, Aug 26, 2020 at 09:51:41AM +0300, Eugen Hristev wrote: >> Microchip CSI2DC (CSI2 Demultiplexer Controller) is a misc bridge device >> that converts a byte stream in IDI Synopsys format (coming from a CSI2HOST) >> to a pixel stream that can be captured by a sensor controller. >> >> Signed-off-by: Eugen Hristev >> --- >> Changes in v2: >> - moved driver to platform/atmel >> - fixed minor things as per Sakari's review >> - still some things from v2 review are not yet addressed, to be followed up >> >> drivers/media/platform/atmel/Kconfig | 13 + >> drivers/media/platform/atmel/Makefile | 1 + >> .../media/platform/atmel/microchip-csi2dc.c | 700 ++++++++++++++++++ >> 3 files changed, 714 insertions(+) >> create mode 100644 drivers/media/platform/atmel/microchip-csi2dc.c >> >> diff --git a/drivers/media/platform/atmel/Kconfig b/drivers/media/platform/atmel/Kconfig >> index 1850fe7f9360..80bbddcc2504 100644 >> --- a/drivers/media/platform/atmel/Kconfig >> +++ b/drivers/media/platform/atmel/Kconfig >> @@ -21,3 +21,16 @@ config VIDEO_ATMEL_ISI >> help >> This module makes the ATMEL Image Sensor Interface available >> as a v4l2 device. >> + >> +config VIDEO_MICROCHIP_CSI2DC >> + tristate "Microchip CSI2 Demux Controller" >> + depends on VIDEO_V4L2 && COMMON_CLK && OF >> + depends on ARCH_AT91 || COMPILE_TEST >> + select MEDIA_CONTROLLER >> + select VIDEO_V4L2_SUBDEV_API >> + select V4L2_FWNODE >> + help >> + CSI2 Demux Controller driver. CSI2DC is a helper chip >> + that converts IDI interface byte stream to a parallel pixel stream. >> + It supports various RAW formats as input. >> + Performs clock domain crossing between hardware blocks. >> diff --git a/drivers/media/platform/atmel/Makefile b/drivers/media/platform/atmel/Makefile >> index 2dba38994a70..8af7c5b534c3 100644 >> --- a/drivers/media/platform/atmel/Makefile >> +++ b/drivers/media/platform/atmel/Makefile >> @@ -3,3 +3,4 @@ atmel-isc-objs = atmel-sama5d2-isc.o atmel-isc-base.o >> >> obj-$(CONFIG_VIDEO_ATMEL_ISI) += atmel-isi.o >> obj-$(CONFIG_VIDEO_ATMEL_ISC) += atmel-isc.o >> +obj-$(CONFIG_VIDEO_MICROCHIP_CSI2DC) += microchip-csi2dc.o >> diff --git a/drivers/media/platform/atmel/microchip-csi2dc.c b/drivers/media/platform/atmel/microchip-csi2dc.c >> new file mode 100644 >> index 000000000000..97d07a80bbf7 >> --- /dev/null >> +++ b/drivers/media/platform/atmel/microchip-csi2dc.c >> @@ -0,0 +1,700 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Microchip CSI2 Demux Controller (CSI2DC) driver >> + * >> + * Copyright (C) 2018-2020 Microchip Technology, Inc. >> + * >> + * Author: Eugen Hristev >> + * >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include >> +#include >> +#include >> +#include >> + >> +/* Global configuration register */ >> +#define CSI2DC_GCFG 0x0 >> + >> +/* MIPI sensor pixel clock is free running */ >> +#define CSI2DC_GCFG_MIPIFRN BIT(0) >> +/* Output waveform inter-line minimum delay */ >> +#define CSI2DC_GCFG_HLC(v) ((v) << 4) >> +#define CSI2DC_GCFG_HLC_MASK GENMASK(7, 4) >> + >> +/* Global control register */ >> +#define CSI2DC_GCTLR 0x04 >> +#define CSI2DC_GCTLR_SWRST BIT(0) >> + >> +/* Global status register */ >> +#define CSI2DC_GS 0x08 >> + >> +/* SSP interrupt status register */ >> +#define CSI2DC_SSPIS 0x28 >> +/* Pipe update register */ >> +#define CSI2DC_PU 0xC0 >> +/* Video pipe attributes update */ >> +#define CSI2DC_PU_VP BIT(0) >> + >> +/* Pipe update status register */ >> +#define CSI2DC_PUS 0xC4 >> + >> +/* Video pipeline enable register */ >> +#define CSI2DC_VPE 0xF8 >> +#define CSI2DC_VPE_ENABLE BIT(0) >> + >> +/* Video pipeline configuration register */ >> +#define CSI2DC_VPCFG 0xFC >> +/* Data type */ >> +#define CSI2DC_VPCFG_DT(v) ((v) << 0) >> +#define CSI2DC_VPCFG_DT_MASK GENMASK(5, 0) >> +/* Virtual channel identifier */ >> +#define CSI2DC_VPCFG_VC(v) ((v) << 6) >> +#define CSI2DC_VPCFG_VC_MASK GENMASK(7, 6) >> +/* Decompression enable */ >> +#define CSI2DC_VPCFG_DE BIT(8) >> +/* Decoder mode */ >> +#define CSI2DC_VPCFG_DM(v) ((v) << 9) >> +#define CSI2DC_VPCFG_DM_DECODER8TO12 0 >> +/* Decoder predictor 2 selection */ >> +#define CSI2DC_VPCFG_DP2 BIT(12) >> +/* Recommended memory storage */ >> +#define CSI2DC_VPCFG_RMS BIT(13) >> +/* Post adjustment */ >> +#define CSI2DC_VPCFG_PA BIT(14) >> + >> +/* Video pipeline column register */ >> +#define CSI2DC_VPCOL 0x100 >> +/* Column number */ >> +#define CSI2DC_VPCOL_COL(v) ((v) << 0) >> +#define CSI2DC_VPCOL_COL_MASK GENMASK(15, 0) >> + >> +/* Video pipeline row register */ >> +#define CSI2DC_VPROW 0x104 >> +/* Row number */ >> +#define CSI2DC_VPROW_ROW(v) ((v) << 0) >> +#define CSI2DC_VPROW_ROW_MASK GENMASK(15, 0) >> + >> +/* Version register */ >> +#define CSI2DC_VERSION 0x1FC >> + >> +/* register read/write helpers */ >> +#define csi2dc_readl(st, reg) readl_relaxed((st)->base + (reg)) >> +#define csi2dc_writel(st, reg, val) writel_relaxed((val), (st)->base + (reg)) >> + >> +/* supported RAW data types */ >> +#define CSI2DC_DT_RAW6 0x28 >> +#define CSI2DC_DT_RAW7 0x29 >> +#define CSI2DC_DT_RAW8 0x2A >> +#define CSI2DC_DT_RAW10 0x2B >> +#define CSI2DC_DT_RAW12 0x2C >> +#define CSI2DC_DT_RAW14 0x2D >> + >> +struct csi2dc_format { >> + u32 mbus_code; >> + u32 dt; >> +}; >> + >> +static struct csi2dc_format csi2dc_formats_list[] = { > > const Elements from this array are being selected in a dynamic list, and pointed from a non-const array of selected working formats (at subdevice completion time). If I make this const , I will get compiler warnings when assigning to the non-const array. What solution do you suggest for this ? > >> + { >> + .mbus_code = MEDIA_BUS_FMT_SRGGB10_1X10, >> + .dt = CSI2DC_DT_RAW10, >> + }, >> +}; >> + >> +enum mipi_csi_pads { >> + CSI2DC_PAD_SINK = 0, >> + CSI2DC_PAD_SOURCE = 1, >> + CSI2DC_PADS_NUM = 2, >> +}; >> + >> +struct csi2dc_device { >> + void __iomem *base; >> + struct v4l2_subdev csi2dc_sd; >> + struct device *dev; >> + struct v4l2_device v4l2_dev; > > This device is a bridge; the V4L2 device should be registered by the master > driver, i.e. the one handling DMA and registering the video nodes. Please > drop this. > >> + struct clk *pclk; >> + struct clk *scck; >> + >> + bool video_pipe; >> + >> + u32 num_fmts; >> + struct csi2dc_format **formats; >> + >> + struct csi2dc_format *cur_fmt; >> + struct csi2dc_format *try_fmt; >> + >> + struct media_pad pads[CSI2DC_PADS_NUM]; >> + >> + bool clk_gated; >> + u32 inter_line_delay; >> + u32 vc; >> + >> + struct v4l2_async_subdev *asd; >> + struct v4l2_async_notifier notifier; >> + >> + struct v4l2_subdev *input_sd; >> + bool completed; >> +}; >> + >> +static void csi2dc_vp_update(struct csi2dc_device *csi2dc) >> +{ >> + u32 vp; >> + >> + vp = CSI2DC_VPCFG_DT(csi2dc->cur_fmt->dt) & CSI2DC_VPCFG_DT_MASK; >> + vp |= CSI2DC_VPCFG_VC(csi2dc->vc) & CSI2DC_VPCFG_VC_MASK; >> + vp &= ~CSI2DC_VPCFG_DE; >> + vp |= CSI2DC_VPCFG_DM(CSI2DC_VPCFG_DM_DECODER8TO12); >> + vp &= ~CSI2DC_VPCFG_DP2; >> + vp &= ~CSI2DC_VPCFG_RMS; >> + vp |= CSI2DC_VPCFG_PA; >> + >> + csi2dc_writel(csi2dc, CSI2DC_VPCFG, vp); >> + csi2dc_writel(csi2dc, CSI2DC_VPE, CSI2DC_VPE_ENABLE); >> + csi2dc_writel(csi2dc, CSI2DC_PU, CSI2DC_PU_VP); >> +} >> + >> +static inline struct csi2dc_device * >> +csi2dc_sd_to_csi2dc_device(struct v4l2_subdev *csi2dc_sd) >> +{ >> + return container_of(csi2dc_sd, struct csi2dc_device, csi2dc_sd); >> +} >> + >> +static int csi2dc_enum_mbus_code(struct v4l2_subdev *csi2dc_sd, >> + struct v4l2_subdev_pad_config *cfg, >> + struct v4l2_subdev_mbus_code_enum *code) >> +{ >> + struct csi2dc_device *csi2dc = csi2dc_sd_to_csi2dc_device(csi2dc_sd); >> + >> + if (code->index >= csi2dc->num_fmts) >> + return -EINVAL; >> + >> + code->code = csi2dc->formats[code->index]->mbus_code; >> + return 0; >> +} >> + >> +static int csi2dc_try_fmt(struct v4l2_subdev *csi2dc_sd, >> + struct v4l2_subdev_pad_config *cfg, >> + struct v4l2_subdev_format *req_fmt) >> +{ >> + struct csi2dc_device *csi2dc = csi2dc_sd_to_csi2dc_device(csi2dc_sd); >> + struct csi2dc_format *fmt; >> + >> + if (!csi2dc->completed) { >> + dev_dbg((csi2dc)->dev, "subdev not registered yet\n"); >> + return 0; >> + } >> + >> + for (fmt = csi2dc->formats[0]; fmt; fmt++) >> + if (req_fmt->format.code == fmt->mbus_code) >> + csi2dc->try_fmt = fmt; >> + >> + /* in case we could not find the desired format, default to something */ >> + if (!csi2dc->try_fmt || >> + req_fmt->format.code != csi2dc->try_fmt->mbus_code) { >> + csi2dc->try_fmt = csi2dc->formats[0]; >> + req_fmt->format.code = csi2dc->formats[0]->mbus_code; >> + } >> + >> + return v4l2_subdev_call(csi2dc->input_sd, pad, set_fmt, cfg, req_fmt); >> +} >> + >> +static int csi2dc_set_fmt(struct v4l2_subdev *csi2dc_sd, >> + struct v4l2_subdev_pad_config *cfg, >> + struct v4l2_subdev_format *req_fmt) >> +{ >> + struct csi2dc_device *csi2dc = csi2dc_sd_to_csi2dc_device(csi2dc_sd); >> + int ret; >> + >> + if (!csi2dc->completed) { >> + dev_dbg((csi2dc)->dev, "subdev not registered yet\n"); >> + return 0; >> + } >> + >> + csi2dc_try_fmt(csi2dc_sd, cfg, req_fmt); >> + >> + if (csi2dc->try_fmt->mbus_code != req_fmt->format.code) { >> + dev_dbg(csi2dc->dev, "CSI2DC unsupported format 0x%x\n", >> + req_fmt->format.code); > > Please adjust the format into a supported one instead. I thought that only the 'try_fmt' calls should adapt to something that works. It is the same case for set_fmt ? This function cannot return invalid format ? > >> + return -EINVAL; >> + } >> + >> + ret = v4l2_subdev_call(csi2dc->input_sd, pad, set_fmt, cfg, req_fmt); >> + if (ret) { >> + dev_err(csi2dc->dev, "input subdev failed %d\n", ret); >> + return ret; >> + } >> + >> + csi2dc->cur_fmt = csi2dc->try_fmt; >> + /* update video pipe */ >> + csi2dc_vp_update(csi2dc); >> + >> + dev_dbg(csi2dc->dev, "CSI2DC new format: 0x%x\n", req_fmt->format.code); >> + return 0; >> +} >> + >> +static int csi2dc_formats_init(struct csi2dc_device *csi2dc) >> +{ >> + int i, j; >> + struct csi2dc_format *fmt = &csi2dc_formats_list[0]; >> + >> + csi2dc->num_fmts = 1; >> + >> + csi2dc->formats = devm_kcalloc(csi2dc->dev, csi2dc->num_fmts, >> + sizeof(*csi2dc->formats), GFP_KERNEL); >> + >> + for (i = 0, j = 0; i < ARRAY_SIZE(csi2dc_formats_list); i++, fmt++) >> + if (fmt->mbus_code == MEDIA_BUS_FMT_SRGGB10_1X10) >> + csi2dc->formats[j++] = fmt; >> + return 0; >> +} >> + >> +static int csi2dc_s_power(struct v4l2_subdev *csi2dc_sd, int on) >> +{ >> + struct csi2dc_device *csi2dc = csi2dc_sd_to_csi2dc_device(csi2dc_sd); >> + int ret = 0; >> + >> + if (!csi2dc->completed) { >> + dev_dbg((csi2dc)->dev, "subdev not registered yet\n"); >> + return 0; >> + } >> + >> + if (on) >> + ret = clk_prepare_enable(csi2dc->scck); >> + else >> + clk_disable_unprepare(csi2dc->scck); >> + if (ret) >> + dev_err(csi2dc->dev, "failed to enable scck: %d\n", ret); >> + >> + /* if powering up, deassert reset line */ >> + if (on) >> + csi2dc_writel(csi2dc, CSI2DC_GCTLR, CSI2DC_GCTLR_SWRST); >> + >> + ret = v4l2_subdev_call(csi2dc->input_sd, core, s_power, on); >> + >> + /* if powering down, assert reset line */ >> + if (!on) >> + csi2dc_writel(csi2dc, CSI2DC_GCTLR, !CSI2DC_GCTLR_SWRST); > > These go to the runtime resume and suspend callbacks. Okay I will update > >> + >> + return ret; >> +} >> + >> +static int csi2dc_s_stream(struct v4l2_subdev *csi2dc_sd, int enable) >> +{ >> + struct csi2dc_device *csi2dc = csi2dc_sd_to_csi2dc_device(csi2dc_sd); >> + >> + if (!csi2dc->completed) { >> + dev_dbg((csi2dc)->dev, "subdev not registered yet\n"); >> + return 0; >> + } >> + >> + return v4l2_subdev_call(csi2dc->input_sd, video, s_stream, enable); >> +} >> + >> +static int csi2dc_g_frame_interval(struct v4l2_subdev *csi2dc_sd, >> + struct v4l2_subdev_frame_interval *interval) >> +{ >> + struct csi2dc_device *csi2dc = csi2dc_sd_to_csi2dc_device(csi2dc_sd); >> + >> + if (!csi2dc->completed) { >> + dev_dbg((csi2dc)->dev, "subdev not registered yet\n"); >> + return 0; >> + } >> + >> + return v4l2_subdev_call(csi2dc->input_sd, video, g_frame_interval, >> + interval); >> +} >> + >> +static int csi2dc_s_frame_interval(struct v4l2_subdev *csi2dc_sd, >> + struct v4l2_subdev_frame_interval *interval) >> +{ >> + struct csi2dc_device *csi2dc = csi2dc_sd_to_csi2dc_device(csi2dc_sd); >> + >> + if (!csi2dc->completed) { >> + dev_dbg((csi2dc)->dev, "subdev not registered yet\n"); >> + return 0; >> + } >> + >> + return v4l2_subdev_call(csi2dc->input_sd, video, s_frame_interval, >> + interval); > > If your driver is used with a MC-enabled master driver, you can drop all > the v4l2_subdev_call() macros apart from the ones related to s_stream > operation. And the set frame interval for example, will it be sent to the sensor automatically ? I noticed that such operations on the master driver were not propagated to the underlying subdevice. How does the master device 'know' how to call the input_sd ? this input_sd is not referenced anywhere in the master driver. > > If not, then you can drop the HAS_DEVNODE flag from the subdev flags. But > I'd try to avoid this route if possible. > >> +} >> + >> +static int csi2dc_enum_frame_size(struct v4l2_subdev *csi2dc_sd, >> + struct v4l2_subdev_pad_config *cfg, >> + struct v4l2_subdev_frame_size_enum *fse) >> +{ >> + struct csi2dc_device *csi2dc = csi2dc_sd_to_csi2dc_device(csi2dc_sd); >> + >> + if (!csi2dc->completed) { >> + dev_dbg((csi2dc)->dev, "subdev not registered yet\n"); >> + return 0; >> + } >> + >> + return v4l2_subdev_call(csi2dc->input_sd, pad, enum_frame_size, cfg, >> + fse); >> +} >> + >> +static int csi2dc_enum_frame_interval(struct v4l2_subdev *csi2dc_sd, >> + struct v4l2_subdev_pad_config *cfg, >> + struct v4l2_subdev_frame_interval_enum *fie) >> +{ >> + struct csi2dc_device *csi2dc = csi2dc_sd_to_csi2dc_device(csi2dc_sd); >> + >> + if (!csi2dc->completed) { >> + dev_dbg((csi2dc)->dev, "subdev not registered yet\n"); >> + return 0; >> + } >> + >> + return v4l2_subdev_call(csi2dc->input_sd, pad, enum_frame_interval, cfg, >> + fie); >> +} >> + >> +static const struct v4l2_subdev_core_ops csi2dc_core_ops = { >> + .s_power = csi2dc_s_power, > > Please use runtime PM instead. > >> +}; >> + >> +static const struct v4l2_subdev_pad_ops csi2dc_pad_ops = { >> + .enum_mbus_code = csi2dc_enum_mbus_code, >> + .set_fmt = csi2dc_set_fmt, >> + .enum_frame_size = csi2dc_enum_frame_size, >> + .enum_frame_interval = csi2dc_enum_frame_interval, >> +}; >> + >> +static const struct v4l2_subdev_video_ops csi2dc_video_ops = { >> + .s_stream = csi2dc_s_stream, >> + .g_frame_interval = csi2dc_g_frame_interval, >> + .s_frame_interval = csi2dc_s_frame_interval, >> +}; >> + >> +static const struct v4l2_subdev_ops csi2dc_subdev_ops = { >> + .core = &csi2dc_core_ops, >> + .pad = &csi2dc_pad_ops, >> + .video = &csi2dc_video_ops, >> +}; >> + >> +static int csi2dc_async_bound(struct v4l2_async_notifier *notifier, >> + struct v4l2_subdev *subdev, >> + struct v4l2_async_subdev *asd) >> +{ >> + struct csi2dc_device *csi2dc = container_of(notifier->v4l2_dev, >> + struct csi2dc_device, v4l2_dev); >> + csi2dc->input_sd = subdev; >> + >> + return 0; >> +} >> + >> +static int csi2dc_async_complete(struct v4l2_async_notifier *notifier) >> +{ >> + struct csi2dc_device *csi2dc = >> + container_of(notifier->v4l2_dev, struct csi2dc_device, v4l2_dev); > > Over 80 characters per line. Please check the rest of the driver, too. > >> + int ret; >> + >> + ret = v4l2_device_register_subdev_nodes(&csi2dc->v4l2_dev); >> + if (ret < 0) { >> + v4l2_err(&csi2dc->v4l2_dev, "failed to register subdev nodes\n"); >> + return ret; >> + } >> + >> + csi2dc_writel(csi2dc, CSI2DC_GCFG, >> + (CSI2DC_GCFG_HLC(csi2dc->inter_line_delay) & >> + CSI2DC_GCFG_HLC_MASK) | >> + (csi2dc->clk_gated ? 0 : CSI2DC_GCFG_MIPIFRN)); >> + >> + csi2dc_writel(csi2dc, CSI2DC_VPCOL, >> + CSI2DC_VPCOL_COL(0xFFF) & CSI2DC_VPCOL_COL_MASK); >> + csi2dc_writel(csi2dc, CSI2DC_VPROW, >> + CSI2DC_VPROW_ROW(0xFFF) & CSI2DC_VPROW_ROW_MASK); >> + >> + csi2dc->completed = true; >> + >> + return ret; >> +} >> + >> +static const struct v4l2_async_notifier_operations csi2dc_async_ops = { >> + .bound = csi2dc_async_bound, >> + .complete = csi2dc_async_complete, >> +}; >> + >> +static void csi2dc_cleanup_notifier(struct csi2dc_device *csi2dc) >> +{ >> + v4l2_async_notifier_unregister(&csi2dc->notifier); >> + v4l2_async_notifier_cleanup(&csi2dc->notifier); >> +} >> + >> +static int csi2dc_prepare_notifier(struct csi2dc_device *csi2dc, >> + struct device_node *input_parent) >> +{ >> + int ret; >> + >> + v4l2_async_notifier_init(&csi2dc->notifier); >> + >> + csi2dc->asd = kzalloc(sizeof(*csi2dc->asd), GFP_KERNEL); >> + if (!csi2dc->asd) >> + return -ENOMEM; >> + >> + csi2dc->asd->match_type = V4L2_ASYNC_MATCH_FWNODE; >> + csi2dc->asd->match.fwnode = of_fwnode_handle(input_parent); >> + >> + ret = v4l2_async_notifier_add_subdev(&csi2dc->notifier, csi2dc->asd); >> + if (ret) { >> + dev_err(csi2dc->dev, "failed to add async notifier.\n"); >> + v4l2_async_notifier_cleanup(&csi2dc->notifier); >> + goto csi2dc_prepare_notifier_err; >> + } >> + >> + csi2dc->notifier.ops = &csi2dc_async_ops; >> + >> + ret = v4l2_async_notifier_register(&csi2dc->v4l2_dev, >> + &csi2dc->notifier); >> + >> + if (ret) { >> + dev_err(csi2dc->dev, "fail to register async notifier.\n"); >> + goto csi2dc_prepare_notifier_err; >> + } >> + >> +csi2dc_prepare_notifier_err: >> + of_node_put(input_parent); >> + >> + return ret; >> +} >> + >> +static int csi2dc_of_parse(struct csi2dc_device *csi2dc, >> + struct device_node *of_node) >> +{ >> + struct device_node *input_node, *sink_node, *input_parent; >> + struct v4l2_fwnode_endpoint input_endpoint = { 0 }, sink_endpoint = { 0 }; >> + int ret; >> + >> + input_node = of_graph_get_next_endpoint(of_node, NULL); >> + >> + if (!input_node) { >> + dev_err(csi2dc->dev, "missing port node at %s, input node is mandatory.\n", >> + of_node->full_name); >> + return -EINVAL; >> + } >> + >> + ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(input_node), >> + &input_endpoint); >> + >> + if (ret) { >> + dev_err(csi2dc->dev, "endpoint not defined at %s\n", >> + of_node->full_name); >> + return ret; >> + } >> + >> + input_parent = of_graph_get_remote_port_parent(input_node); >> + if (!input_parent) { >> + dev_err(csi2dc->dev, "could not get input node's parent node.\n"); >> + return -EINVAL; >> + } >> + >> + sink_node = of_graph_get_next_endpoint(of_node, input_node); >> + >> + if (sink_node) >> + ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(sink_node), >> + &sink_endpoint); >> + >> + if (!sink_node || ret) { >> + dev_info(csi2dc->dev, "missing sink node at %s, data pipe available only.\n", >> + of_node->full_name); >> + } else { >> + csi2dc->video_pipe = true; >> + csi2dc->vc = sink_endpoint.base.id; >> + >> + dev_dbg(csi2dc->dev, "block %s %d.%d->%d.%d video pipe VC %d\n", >> + of_node->full_name, input_endpoint.base.port, >> + input_endpoint.base.id, sink_endpoint.base.port, >> + sink_endpoint.base.id, csi2dc->vc); >> + } >> + >> + csi2dc->clk_gated = of_property_read_bool(of_node, >> + "microchip,clk-gated"); >> + >> + dev_dbg(csi2dc->dev, "%s clock\n", >> + csi2dc->clk_gated ? "Gated" : "Free running"); >> + >> + ret = of_property_read_u32(of_node, "microchip,inter-line-delay", >> + &csi2dc->inter_line_delay); >> + >> + if (ret || csi2dc->inter_line_delay > 16 || >> + csi2dc->inter_line_delay == 0) { >> + dev_dbg(csi2dc->dev, "assuming inter line delay = 16 clocks"); >> + csi2dc->inter_line_delay = 16; >> + ret = 0; >> + } >> + /* hardware automatically adds 1 */ >> + csi2dc->inter_line_delay--; >> + >> + /* prepare async notifier for subdevice completion */ >> + >> + of_node_put(sink_node); >> + of_node_put(input_node); >> + >> + return csi2dc_prepare_notifier(csi2dc, input_parent); >> +} >> + >> +static int csi2dc_probe(struct platform_device *pdev) >> +{ >> + struct device *dev = &pdev->dev; >> + struct csi2dc_device *csi2dc; >> + struct resource *res = NULL; >> + int ret = 0; >> + >> + csi2dc = devm_kzalloc(dev, sizeof(*csi2dc), GFP_KERNEL); >> + if (!csi2dc) >> + return -ENOMEM; >> + >> + csi2dc->dev = dev; >> + >> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> + if (!res) >> + return -EINVAL; >> + >> + csi2dc->base = devm_ioremap_resource(dev, res); >> + >> + if (IS_ERR(csi2dc->base)) { >> + dev_err(dev, "base address not set\n"); >> + return PTR_ERR(csi2dc->base); >> + } >> + >> + csi2dc->pclk = devm_clk_get(dev, "pclk"); >> + if (IS_ERR(csi2dc->pclk)) { >> + ret = PTR_ERR(csi2dc->pclk); >> + dev_err(dev, "failed to get pclk: %d\n", ret); >> + return ret; >> + } >> + >> + ret = clk_prepare_enable(csi2dc->pclk); >> + if (ret) { >> + dev_err(dev, "failed to enable pclk: %d\n", ret); >> + return ret; >> + } >> + >> + csi2dc->scck = devm_clk_get(dev, "scck"); >> + if (IS_ERR(csi2dc->scck)) { >> + ret = PTR_ERR(csi2dc->scck); >> + dev_err(dev, "failed to get scck: %d\n", ret); >> + goto csi2dc_clk_fail; >> + } >> + >> + ret = v4l2_device_register(dev, &csi2dc->v4l2_dev); >> + if (ret) { >> + dev_err(dev, "unable to register v4l2 device.\n"); >> + goto csi2dc_clk_fail; >> + } >> + >> + v4l2_subdev_init(&csi2dc->csi2dc_sd, &csi2dc_subdev_ops); >> + >> + csi2dc->csi2dc_sd.owner = THIS_MODULE; >> + csi2dc->csi2dc_sd.dev = dev; >> + snprintf(csi2dc->csi2dc_sd.name, sizeof(csi2dc->csi2dc_sd.name), >> + "CSI2DC.0"); >> + >> + csi2dc->csi2dc_sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; >> + csi2dc->csi2dc_sd.entity.function = MEDIA_ENT_F_VID_IF_BRIDGE; >> + csi2dc->pads[CSI2DC_PAD_SINK].flags = MEDIA_PAD_FL_SINK; >> + csi2dc->pads[CSI2DC_PAD_SOURCE].flags = MEDIA_PAD_FL_SOURCE; >> + >> + ret = media_entity_pads_init(&csi2dc->csi2dc_sd.entity, CSI2DC_PADS_NUM, >> + csi2dc->pads); >> + if (ret < 0) { >> + dev_err(dev, "media entity init failed\n"); >> + goto csi2dc_probe_entity_err; >> + } >> + >> + v4l2_set_subdevdata(&csi2dc->csi2dc_sd, pdev); >> + >> + platform_set_drvdata(pdev, &csi2dc->csi2dc_sd); >> + >> + ret = csi2dc_of_parse(csi2dc, dev->of_node); >> + if (ret) >> + goto csi2dc_probe_entity_err; >> + >> + ret = csi2dc_formats_init(csi2dc); >> + if (ret) >> + goto csi2dc_probe_error; >> + >> + ret = v4l2_async_register_subdev(&csi2dc->csi2dc_sd); >> + if (ret) >> + goto csi2dc_probe_error; >> + >> + pr_info("Microchip CSI2DC version %x\n", >> + csi2dc_readl(csi2dc, CSI2DC_VERSION)); > > dev_info(), please. Or just dev_dbg(). > >> + >> + pm_runtime_set_active(dev); >> + pm_runtime_enable(dev); >> + pm_request_idle(dev); >> + >> + return 0; >> + >> +csi2dc_probe_error: >> + v4l2_async_unregister_subdev(&csi2dc->csi2dc_sd); >> + csi2dc_cleanup_notifier(csi2dc); >> + >> +csi2dc_probe_entity_err: >> + media_entity_cleanup(&csi2dc->csi2dc_sd.entity); >> + v4l2_device_unregister(&csi2dc->v4l2_dev); >> +csi2dc_clk_fail: >> + clk_disable_unprepare(csi2dc->pclk); >> + return ret; >> +} >> + >> +static int csi2dc_remove(struct platform_device *pdev) >> +{ >> + struct v4l2_subdev *csi2dc_sd = platform_get_drvdata(pdev); >> + struct csi2dc_device *csi2dc = csi2dc_sd_to_csi2dc_device(csi2dc_sd); >> + >> + pm_runtime_disable(&pdev->dev); >> + csi2dc_cleanup_notifier(csi2dc); >> + media_entity_cleanup(&csi2dc->csi2dc_sd.entity); >> + v4l2_device_unregister(&csi2dc->v4l2_dev); >> + clk_disable_unprepare(csi2dc->pclk); >> + >> + return 0; >> +} >> + >> +static int __maybe_unused csi2dc_runtime_suspend(struct device *dev) >> +{ >> + return 0; >> +} >> + >> +static int __maybe_unused csi2dc_runtime_resume(struct device *dev) >> +{ >> + return 0; >> +} >> + >> +static const struct dev_pm_ops csi2dc_dev_pm_ops = { >> + SET_RUNTIME_PM_OPS(csi2dc_runtime_suspend, csi2dc_runtime_resume, NULL) >> +}; >> + >> +static const struct of_device_id csi2dc_of_match[] = { >> + { .compatible = "microchip,sama7g5-csi2dc" }, >> + { } >> +}; >> + >> +MODULE_DEVICE_TABLE(of, csi2dc_of_match); >> + >> +static struct platform_driver csi2dc_driver = { >> + .probe = csi2dc_probe, >> + .remove = csi2dc_remove, >> + .driver = { >> + .name = "microchip-csi2dc", >> + .pm = &csi2dc_dev_pm_ops, >> + .of_match_table = of_match_ptr(csi2dc_of_match), >> + }, >> +}; >> + >> +module_platform_driver(csi2dc_driver); >> + >> +MODULE_AUTHOR("Eugen Hristev "); >> +MODULE_DESCRIPTION("Microchip CSI2 Demux Controller driver"); >> +MODULE_LICENSE("GPL v2"); >> +MODULE_SUPPORTED_DEVICE("video"); > > Hmm. This line needs to be more specific. I'd just drop it. > > -- > Kind regards, > > Sakari Ailus > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel