From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B584C2BD09 for ; Tue, 9 Jul 2024 07:30:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:CC:To: Subject:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qcejXQfkAmk+hbozziFn//GAS+EIpAiTNXHsKzqoyqw=; b=e6NzmrqgI2SgJTqKX3hyFT0+d3 M/W676RbCOjPzxp6fH/CD8tOuXW0VMkLf7knQ7j0Q+Ypame7YrVQtETpcFJ/+EbH1Z5rgqkkfeCL0 7/lFa4FZHTtDjG05pEixUUtilmbeeoc0cjktV68kdUaecp4ID438xZNvmC5bGiGy9+QnEJ9uY2NlF riHjs5YEyVT7h3Y1j9vvXlftKYpzERoZ04YlFmocKVt2nEW1Wa0SLbp6U3DMA8Fsza3eNdArsy34J wSkDDWON/fL4m/oKzGsdhPCa4cxuVGINsgJQYxhh7yqQC/6NxgNU1+p3T8BLGQgNGIj6xQNrgDuB/ ALpfSZ+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sR5Iq-00000006ETs-1NB4; Tue, 09 Jul 2024 07:30:20 +0000 Received: from szxga01-in.huawei.com ([45.249.212.187]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sR5IY-00000006ELp-47Ko; Tue, 09 Jul 2024 07:30:05 +0000 Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4WJCF73k6HzwWd4; Tue, 9 Jul 2024 15:25:15 +0800 (CST) Received: from kwepemm600007.china.huawei.com (unknown [7.193.23.208]) by mail.maildlp.com (Postfix) with ESMTPS id B1012180AE5; Tue, 9 Jul 2024 15:29:56 +0800 (CST) Received: from [10.174.185.179] (10.174.185.179) by kwepemm600007.china.huawei.com (7.193.23.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 9 Jul 2024 15:29:54 +0800 Subject: Re: [PATCH 6/9] accel/rocket: Add a new driver for Rockchip's NPU To: Tomeu Vizoso CC: Joerg Roedel , Will Deacon , Robin Murphy , Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Oded Gabbay , Tomeu Vizoso , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Philipp Zabel , Sumit Semwal , =?UTF-8?Q?Christian_K=c3=b6nig?= , , , , , , , , References: <20240612-6-10-rocket-v1-0-060e48eea250@tomeuvizoso.net> <20240612-6-10-rocket-v1-6-060e48eea250@tomeuvizoso.net> From: Zenghui Yu Message-ID: Date: Tue, 9 Jul 2024 15:29:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20240612-6-10-rocket-v1-6-060e48eea250@tomeuvizoso.net> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.185.179] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600007.china.huawei.com (7.193.23.208) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240709_003003_371232_D59E8DF7 X-CRM114-Status: GOOD ( 10.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2024/6/12 21:52, Tomeu Vizoso wrote: > This initial version supports the NPU as shipped in the RK3588 SoC and > described in the first part of its TRM, in Chapter 36. > > This NPU contains 3 independent cores that the driver can submit jobs > to. > > This commit adds just hardware initialization and power management. > > Signed-off-by: Tomeu Vizoso [...] > +void rocket_core_reset(struct rocket_core *core) > +{ > + reset_control_assert(core->a_reset); > + reset_control_assert(core->h_reset); > + > + udelay(10); > + > + reset_control_deassert(core->a_reset); > + reset_control_deassert(core->h_reset); > +} Seems unused. > +void rocket_core_reset(struct rocket_core *core); > +void rocket_device_reset(struct rocket_device *rdev); Ditto.