From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F2A7C25B75 for ; Mon, 3 Jun 2024 05:13:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rh6FEO1NBY7yXm5QANFzMn1w1wGOI3bh5YiNupu7gOg=; b=YP6a62Nj+y0Nt/ WIXHTmWjf7BeuvV/07eWz0URBzLNeEnqsoxSm9F94sVuSgudZCTVczdVgKYNSUhk29fqORMuMerJv 9YsK7OnJUHd7bVB1RBougfIuW8o9dpk4EOKqnlmaNK7gl6Vq3mUp2aERmgJQuzH3Qc/LNg50FUN0y XrR74JNMvratF96lbtptZiKQjpc499hpc8mJhvrrRVvGhWkPPUFUWaBz7G+Y4ws+P3yWIW5FKRLDe Dm4uHSX+gj6oEHe5EGHpzmEC1kg8V8EmEpt8AQe4cLYeoQfzpscrgdzNM5Kq1vxnISX5SKPGnOL6G y1jpmEq8aFA4UmYPop7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sE00O-0000000Fej3-21YQ; Mon, 03 Jun 2024 05:13:12 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sE00K-0000000FeiK-05lI for linux-arm-kernel@lists.infradead.org; Mon, 03 Jun 2024 05:13:10 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 253B21042; Sun, 2 Jun 2024 22:13:25 -0700 (PDT) Received: from [10.162.40.16] (a077893.blr.arm.com [10.162.40.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4C4EC3F762; Sun, 2 Jun 2024 22:12:56 -0700 (PDT) Message-ID: Date: Mon, 3 Jun 2024 10:42:53 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V17 1/9] arm64/sysreg: Add BRBE registers and fields To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, will@kernel.org, catalin.marinas@arm.com, Mark Brown , James Clark , Rob Herring , Marc Zyngier , Suzuki Poulose , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , linux-perf-users@vger.kernel.org References: <20240405024639.1179064-1-anshuman.khandual@arm.com> <20240405024639.1179064-2-anshuman.khandual@arm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240602_221308_156130_A5617D77 X-CRM114-Status: GOOD ( 21.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/21/24 18:54, Mark Rutland wrote: > On Fri, Apr 05, 2024 at 08:16:31AM +0530, Anshuman Khandual wrote: >> This adds BRBE related register definitions and various other related field >> macros there in. These will be used subsequently in a BRBE driver, which is >> being added later on. While here, this drops redundant register definitions >> from the header i.e (arch/arm64/include/asm/sysreg.h). >> >> BRBINFx_EL1_TYPE_IMPDEF_TRAP_EL3 register field value has been derived from >> latest ARM DDI 0601 ID121123, AKA 2023-12 instead of latest ARM ARM i.e ARM >> DDI 0487J.a. Please find the definition here. >> >> https://developer.arm.com/documentation/ddi0601/2023-12/ > > The K.a release of the ARM ARM has now been published, and that includes > the "0b110000 IMPLEMENTATION DEFINED exception to EL3" value, so we can > point to that now. Sure. > > With that in mind, for the commit message we can say: > > | This patch adds definitions related to the Branch Record Buffer > | Extension (BRBE) as per ARM DDI 0487K.a. These will be used by KVM and > | a BRBE driver in subsequent patches. > | > | Some existing BRBE definitions in asm/sysreg.h are replaced with > | equivalent generated definitions. Replaced the commit message wordings as suggested. > > Aside from a couple of minor issues below, this looks good to me. With > those fixed up (and the commit message above): > > Reviewed-by: Mark Rutland Thanks Mark. > > [...] > >> +Sysreg BRBIDR0_EL1 2 1 9 2 0 >> +Res0 63:16 >> +Enum 15:12 CC >> + 0b101 20_BIT >> +EndEnum > > Please pad this to the width of the field, i.e. > > 0b0101 20_bit Done. > >> +Enum 11:8 FORMAT >> + 0b0 0 >> +EndEnum > > Likewise, this should be padded to the width of the field. Done. > > As with the BRBFCR_EL1.BANK definitions, I reckon it's worth givin the > enum value a prefix, so please make this: > > 0b0000 FORMAT_0 Sure, will change as suggested. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel