From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: wens@csie.org
Cc: Yong Deng <yong.deng@magewell.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Maxime Ripard <mripard@kernel.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: platform: sunxi: sun6i-csi: fix error return code of sun6i_video_start_streaming()
Date: Mon, 8 Mar 2021 10:54:08 +0800 [thread overview]
Message-ID: <ad3e4bd5-9db9-da04-37fa-b7fe5d9d431e@gmail.com> (raw)
In-Reply-To: <CAGb2v660_jsK565dN4D2wSTmGjt1WUnHRkMOG7vzaqgZwY-Zeg@mail.gmail.com>
On 2021/3/7 20:47, Chen-Yu Tsai wrote:
> On Sat, Mar 6, 2021 at 10:15 PM Jia-Ju Bai <baijiaju1990@gmail.com> wrote:
>> When sun6i_video_remote_subdev() returns NULL to subdev, no error return
>> code of sun6i_video_start_streaming() is assigned.
>> To fix this bug, ret is assigned with -EINVAL in this case.
>>
>> Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
>> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
> This should have the tag:
>
> Fixes: 5cc7522d8965 ("media: sun6i: Add support for Allwinner CSI V3s")
>
> Please try to add them when fixing bugs. And this should also be tagged
> for stable, so
>
> Cc: <stable@kernel.org>
>
> Otherwise,
>
> Acked-by: Chen-Yu Tsai <wens@csie.org>
Thanks for the advice :)
I will add the fixes and stable tags in my future patches.
Best wishes,
Jia-Ju Bai
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-03-08 2:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-06 14:15 [PATCH] media: platform: sunxi: sun6i-csi: fix error return code of sun6i_video_start_streaming() Jia-Ju Bai
2021-03-07 12:47 ` Chen-Yu Tsai
2021-03-08 2:54 ` Jia-Ju Bai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad3e4bd5-9db9-da04-37fa-b7fe5d9d431e@gmail.com \
--to=baijiaju1990@gmail.com \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=wens@csie.org \
--cc=yong.deng@magewell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).