From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3AAEC433DB for ; Mon, 8 Mar 2021 02:57:09 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A6B2650E0 for ; Mon, 8 Mar 2021 02:57:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A6B2650E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TTd16WOZh0xIAN6ba8i4UnT8fzDRBZl8+SVhHDIUNrI=; b=jLsnmcAqGBcLgPsXP+q5ZuxM0 e9fESnkp4W1TSppdEBKwHJhe4LCszo67SV0Ykh65TbQbyCgbSx5BwYv30YeOe71coLhCZNpPlxqBT egb2V8Z1m3vDNs59GJjRgJSqZiGjRQwkrqWeH4hnJ4qYGZ2FOh96OogvzeBTq3s8EqFNpeip+YQ8c b4iX8U0MBsLn/Aa1G4hOc4mlJPoJQ6/DNWzGRa+0UAHN0UX4wgqbpOZ56gff4mJQ8uEdRbvqEGUGi rYy0vlUg/6V3oEUF4TMn7YgSQkUUPj9JPzfEjIyG9MhkziYRAyhZJpadEugE7LGK3YsXctSJg8BVu VmIgsUmQQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJ63L-00Eeat-V1; Mon, 08 Mar 2021 02:55:28 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJ626-00Edvn-RS for linux-arm-kernel@lists.infradead.org; Mon, 08 Mar 2021 02:54:13 +0000 Received: by mail-pf1-x432.google.com with SMTP id 16so4722766pfn.5 for ; Sun, 07 Mar 2021 18:54:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=mFSkViZXOvwmWAhS7tYtXVJXwXatkvhNxjoAxYZhg/s=; b=kVXg1qiK64BM/wA9A7kLXmNiANwfY4X+x1YJKBrZhjJCIA/ykx1/eo7t4eYZ5+zdSG HOOvd2b4YUXuJPZoE9FtYYkHGQEDFsgf+C6mvh9O8GkJ8PhnS2tyM997uvonql1MdAYk Jawd4oAPGfvip0k4Aivcrb2c2ZmfAYkI0BbsEdb9v6mqdTlVylV6wbAfvqmdE727vtMp Rk+AW4RtICpdAaIdclEBFJhS99W+e05lXKXjztvA/iYDI2Enoo+nYPu5iEABs0h+VCnc QNwfIdu3SDhTon8GS8J/feJu/QERJ7cCBRWcpqAfml1tZwJh2G2fTx3bxkMtfY7XeUdz Al8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=mFSkViZXOvwmWAhS7tYtXVJXwXatkvhNxjoAxYZhg/s=; b=OW8GA2uuc6U+GdCtomAaH2s8ptF150OISrkkKHSdYIU8rfuK7tFtd+IbuSrprnQDXQ dAzl/5CkX7OlvVzAiKKxvqasoaAKjUgc8eE+nJ0bfxVVfAKiB6fNxedf+hB03eDuRPnl NjoMNylnlQI+JSrt/bTk8TCHbQHgCqZonu/TRAivZaP7eE2s5C9o93i0IgZ/H0QkdSn8 J+MCLT9kwdv1vIBHb9zsTG57a89kLrav36uprauGDWePNim/1AaBzo9HRsh/tfw3IUbp +EPLfolHgX+wUizty2eXblRTsHMm/6VRF3NVjnIsaKGuS7L4U5w6NitML3XmVqnAGb5U oWmA== X-Gm-Message-State: AOAM5335QVoA2YM12AtudGKcbOm0lg6lyMFLt+iR8IROoPWoOgCIJv/c oH+WaS3jKDtckxA1IprRDlY= X-Google-Smtp-Source: ABdhPJy9xhOPu5/0+XQIwwNkR0Bjtnppnsbuz9fr0degL00AQ1ak0eHSEVkDa9SRlaehrCCCxwFs2g== X-Received: by 2002:a62:2786:0:b029:1ee:afe7:6bfb with SMTP id n128-20020a6227860000b02901eeafe76bfbmr18715044pfn.14.1615172048618; Sun, 07 Mar 2021 18:54:08 -0800 (PST) Received: from [10.187.1.26] ([45.135.186.66]) by smtp.gmail.com with ESMTPSA id g22sm2447811pju.30.2021.03.07.18.54.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Mar 2021 18:54:08 -0800 (PST) Subject: Re: [PATCH] media: platform: sunxi: sun6i-csi: fix error return code of sun6i_video_start_streaming() To: wens@csie.org Cc: Yong Deng , Mauro Carvalho Chehab , Maxime Ripard , Jernej Skrabec , Linux Media Mailing List , linux-arm-kernel , linux-kernel References: <20210306141528.18925-1-baijiaju1990@gmail.com> From: Jia-Ju Bai Message-ID: Date: Mon, 8 Mar 2021 10:54:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210308_025411_197459_68495F6D X-CRM114-Status: GOOD ( 15.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021/3/7 20:47, Chen-Yu Tsai wrote: > On Sat, Mar 6, 2021 at 10:15 PM Jia-Ju Bai wrote: >> When sun6i_video_remote_subdev() returns NULL to subdev, no error return >> code of sun6i_video_start_streaming() is assigned. >> To fix this bug, ret is assigned with -EINVAL in this case. >> >> Reported-by: TOTE Robot >> Signed-off-by: Jia-Ju Bai > This should have the tag: > > Fixes: 5cc7522d8965 ("media: sun6i: Add support for Allwinner CSI V3s") > > Please try to add them when fixing bugs. And this should also be tagged > for stable, so > > Cc: > > Otherwise, > > Acked-by: Chen-Yu Tsai Thanks for the advice :) I will add the fixes and stable tags in my future patches. Best wishes, Jia-Ju Bai _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel