From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3903C4332F for ; Thu, 9 Nov 2023 12:26:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m1yEzQeepFVqO3A8uasa29Guvgped3mXh2tnFsYfNpk=; b=ZdqwKyD8w/XbRc ntnYroxaB39nuHR0sieTWhA1Yh+27qhCfYPcwsIjTMJ4QPsuTEnMte5Zl1B60poPPGTJ5P4ldU5dU C/pGVHERRSyc2yQjZa2ovc5+cqppW/31CqAkjiniAgqx8qAxh2HV5Ds5MjHvvwJOYoUmoM4ZMLdyd pd5WyA7P9t8CHKbe9eGFQY5h+0zplkyTl2diKchrfvzORMXS14xwEROWCEOj1uN8lazFKqE+RDOhC kbotasW/CfS13lcHjGJbmgp/4kHLQlzo6NrnGlx0q8apyh+f/4OIo5lCwv3zeoC+XqB42qFY2LXkw 1NbVA95JA8wiMK2+zj8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r1479-006JTo-1p; Thu, 09 Nov 2023 12:26:27 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r1476-006JSe-0t for linux-arm-kernel@lists.infradead.org; Thu, 09 Nov 2023 12:26:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699532782; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1/haom+yH9xLwnE9aURcVj9dx4YOUUdXMdvnVMAeYqM=; b=HecThWgbZ6C6ynnvaiA5u144VgmDj3hSFaWTn+bmjBw2kNcU6zE8tnR1MyIm4vBIuTvt7M I0yxU28PrYVHhwiFDUZOyZirXAGjduhcXuF+q6fHTPWQ1wccLWfWu6IaODU0z3aNdwrpU+ qe9SwYxgdW9RN1gu9hnGBz5bDvdix1g= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-446-32Wt2QqPNye99N-1uhU1Sw-1; Thu, 09 Nov 2023 07:26:21 -0500 X-MC-Unique: 32Wt2QqPNye99N-1uhU1Sw-1 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-5b596737797so1586267b3.0 for ; Thu, 09 Nov 2023 04:26:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699532781; x=1700137581; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=1/haom+yH9xLwnE9aURcVj9dx4YOUUdXMdvnVMAeYqM=; b=r8e+cEawHuegpA8aNz3Eyc4qWuA+PnszynHgb2GwkiXeT8ZNAOQ8wk6u77XjjI4Tf2 9qXRJYdfhGWhxXeOMj9q3yl0ylen6X3nj64EKG/xrWH76TX8eNdob8bUaxWV4cQZi7i7 FJSIu+ewHsYDiwO7CJy5riWDyHTuyI5fxLY9giQIS4taDB7K0+tTHqfSSyM6vXaQ2fYK eXLocxObFYFyCJlp9o+1lEkwT+HF8FiRxX9LVPDWUTFCRNBdzojDaxt0AdocBJ5berap 1klpKQhWVt6suaw9YXRucP7feAJ2uxNfg4q4iS2R8dZjtlqb1HdG6G6wNtxtvSLFn0tS eeQw== X-Gm-Message-State: AOJu0YxdAbkXZFPAAtAHTmnfvpplHJy/xAogmL4PoeBaMjnRCudRUO06 IbYgSG2sujmX4TUrd1o0F/kzzpCLbE39tePVvzBfVLdJmksXnV8bhzktP/nbtZZChAd5fp7PX1/ +4qu0YnsAi20ddFFBpmXu2MpnD+JJsmhI5lWoVb+K9lw= X-Received: by 2002:a81:a941:0:b0:5a7:ba54:5127 with SMTP id g62-20020a81a941000000b005a7ba545127mr3971924ywh.3.1699532781101; Thu, 09 Nov 2023 04:26:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IFlXxTrprPZijY3/9XY14mMrwVZ8+lm8hhrgq8SG1ZGANmgzirEEjusP4RzmaSaOW2ShlenrA== X-Received: by 2002:a81:a941:0:b0:5a7:ba54:5127 with SMTP id g62-20020a81a941000000b005a7ba545127mr3971916ywh.3.1699532780737; Thu, 09 Nov 2023 04:26:20 -0800 (PST) Received: from gerbillo.redhat.com (146-241-228-197.dyn.eolo.it. [146.241.228.197]) by smtp.gmail.com with ESMTPSA id g24-20020ac84dd8000000b00417db2593bdsm1876925qtw.72.2023.11.09.04.26.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Nov 2023 04:26:20 -0800 (PST) Message-ID: Subject: Re: [PATCH net v4 0/3] Fix large frames in the Gemini ethernet driver From: Paolo Abeni To: Vladimir Oltean , Linus Walleij Cc: Hans Ulli Kroll , "David S. Miller" , Eric Dumazet , Jakub Kicinski , =?UTF-8?Q?Micha=C5=82_Miros=C5=82aw?= , Andrew Lunn , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 09 Nov 2023 13:26:17 +0100 In-Reply-To: <20231109105037.zppxrr3bptd7a7i6@skbuf> References: <20231109-gemini-largeframe-fix-v4-0-6e611528db08@linaro.org> <20231109105037.zppxrr3bptd7a7i6@skbuf> User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231109_042624_381755_92D726FB X-CRM114-Status: GOOD ( 24.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2023-11-09 at 12:50 +0200, Vladimir Oltean wrote: > On Thu, Nov 09, 2023 at 10:03:11AM +0100, Linus Walleij wrote: > > This is the result of a bug hunt for a problem with the > > RTL8366RB DSA switch leading me wrong all over the place. > > > > I am indebted to Vladimir Oltean who as usual pointed > > out where the real problem was, many thanks! > > > > Tryig to actually use big ("jumbo") frames on this > > hardware uncovered the real bugs. Then I tested it on > > the DSA switch and it indeed fixes the issue. > > > > To make sure it also works fine with big frames on > > non-DSA devices I also copied a large video file over > > scp to a device with maximum frame size, the data > > was transported in large TCP packets ending up in > > 0x7ff sized frames using software checksumming at > > ~2.0 MB/s. > > > > If I set down the MTU to the standard 1500 bytes so > > that hardware checksumming is used, the scp transfer > > of the same file was slightly lower, ~1.8-1.9 MB/s. > > > > Despite this not being the best test it shows that > > we can now stress the hardware with large frames > > and that software checksum works fine. > > > > Signed-off-by: Linus Walleij > > --- > > Thanks for being persistent with this! I hope we didn't miss today's > "net" pull request :) I fear this is a bit too late for today's PR. I hope it should not be a big problem, since we are very early in the release cycle. Cheers, Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel