From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD0EEC2D0E4 for ; Mon, 23 Nov 2020 10:48:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63CE720721 for ; Mon, 23 Nov 2020 10:48:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OU6HAKG5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63CE720721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UWML0TXs53w8WE1Ien/vKbdSkzTRv2Kyql+x+7dH/n8=; b=OU6HAKG52XoCyzKFjVNZNG1n0 Rt5d/6g+ScFjQImo9Rndns17kWfGLUMd5/Adq2V4Ay+Fzr3XvvCVHeXSXyC5+YObt+f3lvkVBJdTB g6mqqLQifNDhjE1oGrDyjpT38GglrXU8L2eju2xDnXaqjnpo55JcHa6HruYv0TrFA19dd5RdzvB2g +z2f2FPTi7wRmuYA06JUdYIXHCBGngH6f5YyV+cW+6q6ofc/kD6vXKNMJs5fRkUH8UGOdxXn5nM1i FNp3jmE3t4L71xooJuATetQClWMPytNxDcJVUg4VhLXRVe43+S0FE06vq3ldkjKo1KDxO37qakZ8v eI9NxvTgw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kh9NG-00063k-CA; Mon, 23 Nov 2020 10:47:10 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kh9ND-000639-IB for linux-arm-kernel@lists.infradead.org; Mon, 23 Nov 2020 10:47:08 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0CE96101E; Mon, 23 Nov 2020 02:47:03 -0800 (PST) Received: from [10.57.53.209] (unknown [10.57.53.209]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 649513F70D; Mon, 23 Nov 2020 02:47:01 -0800 (PST) Subject: Re: [PATCH] coresight: tmc-etr: Check if page is valid before dma_map_page() To: Sai Prakash Ranjan , Mathieu Poirier , Mike Leach References: <20201123102133.18979-1-saiprakash.ranjan@codeaurora.org> From: Suzuki K Poulose Message-ID: Date: Mon, 23 Nov 2020 10:46:56 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201123102133.18979-1-saiprakash.ranjan@codeaurora.org> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201123_054707_683760_948B7605 X-CRM114-Status: GOOD ( 18.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, Mao Jinlong , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Stephen Boyd , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/23/20 10:21 AM, Sai Prakash Ranjan wrote: > From: Mao Jinlong > > alloc_pages_node() return should be checked before calling > dma_map_page() to make sure that valid page is mapped or > else it can lead to aborts as below: > > Unable to handle kernel paging request at virtual address ffffffc008000000 > Mem abort info: > ... > pc : __dma_inv_area+0x40/0x58 > lr : dma_direct_map_page+0xd8/0x1c8 > > Call trace: > __dma_inv_area > tmc_pages_alloc > tmc_alloc_data_pages > tmc_alloc_sg_table > tmc_init_etr_sg_table > tmc_alloc_etr_buf > tmc_enable_etr_sink_sysfs > tmc_enable_etr_sink > coresight_enable_path > coresight_enable > enable_source_store > dev_attr_store > sysfs_kf_write > > Fixes: 99443ea19e8b ("coresight: Add generic TMC sg table framework") > Cc: stable@vger.kernel.org > Signed-off-by: Mao Jinlong > Signed-off-by: Sai Prakash Ranjan Reviewed-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-tmc-etr.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c > index 525f0ecc129c..a31a4d7ae25e 100644 > --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c > +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c > @@ -217,6 +217,8 @@ static int tmc_pages_alloc(struct tmc_pages *tmc_pages, > } else { > page = alloc_pages_node(node, > GFP_KERNEL | __GFP_ZERO, 0); > + if (!page) > + goto err; > } > paddr = dma_map_page(real_dev, page, 0, PAGE_SIZE, dir); > if (dma_mapping_error(real_dev, paddr)) > > base-commit: c04e5d7bbf6f92a346d6b36770705e7f034df42d > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel