From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D51A0E64016 for ; Mon, 6 Apr 2026 12:35:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oY3q1h2AWxYa+aq6tw2htsu9P781lAVUFOH6kSb0j8U=; b=uWs0V54snQeJ4U+RLTdjn9Z+pP rsFuGKcXWBCxWKfFQCb5LoYdyP+NWJChxR6TFAUgKww773XVA1b4nbusX4PhUOExhuweR6d72W2co 1CnxHYh2ZmqeMOb/MDhEpD8iBctcckcAJwqT1HAT83eEqU9grDu1KY/BztLfmOZSFtZ+j0W5wSk/p QCaCWXoFlJIxyxlmbesfzCauFdix/i4LzrBvECdQhSEeyElrhAn99LFapmZDb59GiSLKNqt0GqZfK FwTD66B+2xLLxETJ5c464NdcCCXq6vBpl8DvE1XGGhbmJ9EIS8xRpVKBxIpulDZiqthpCZh+4xoFT P+xEa+qQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w9jAZ-000000056iE-1dhe; Mon, 06 Apr 2026 12:35:07 +0000 Received: from elvis.franken.de ([193.175.24.41]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w9jAW-000000056gt-1dp0; Mon, 06 Apr 2026 12:35:06 +0000 Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1w9jAQ-00040p-00; Mon, 06 Apr 2026 14:34:58 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 0DB2EC0C39; Mon, 6 Apr 2026 14:29:28 +0200 (CEST) Date: Mon, 6 Apr 2026 14:29:28 +0200 From: Thomas Bogendoerfer To: Shiji Yang Cc: linux-mips@vger.kernel.org, Matthias Brugger , AngeloGioacchino Del Regno , Philipp Zabel , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 3/3] mips: pci-mt7620: rework initialization procedure Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260406_053504_591183_F898B4CA X-CRM114-Status: GOOD ( 15.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 18, 2025 at 11:42:07AM +0800, Shiji Yang wrote: > Move the reset operation to the common part to reduce the code > redundancy. They are actually the same and needed for all SoCs. > Disabling power and clock are unnecessary for MT7620 and will be > removed. In vendor SDK, it's used to save the power when the PCI > driver is not selected. The MT7628 GPIO pinctrl has been removed > because this should be done in device-tree. Some delay intervals > have also been increased to follow the recommendations of the SoC > SDK and datasheet. Tested on both MT7620 and MT7628. > > Signed-off-by: Shiji Yang > --- > arch/mips/pci/pci-mt7620.c | 38 +++++++++++++------------------------- > 1 file changed, 13 insertions(+), 25 deletions(-) applied to mips-next Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]