From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53ED6C001DB for ; Tue, 8 Aug 2023 08:36:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h3OzkSDWfSEqm/4JzUjqh/hyniFH/v9teCquogKh4f4=; b=lDb4e7wiEHD9tn Cjbb26+6WLDNhPpFS+P+mD5pySnvztnxY66UL92C4csu+1RyGSA6CijScfDPPeUU0BNBrWJLlHNB7 h/hvqvVLaUfO0SOueLy9/T2DqaANyuWOYA8Xy+N2yO73Hel9VIJA+RM3ilyWCoRLz9l+kUqf1Fqnv ENPL8QUqIu2XmTQfDGExxLuG4TwB63YBBLPvTvh2Vmy/er1MqfWG3wqwHIKcPoIkg+PslOXI9BDBe BlLtBgXxdI+8nbv76hLzFHJki+t5nKk94PJ/HDGZhZNtCg5zigbi5Uf6ZcFPLfb1cAhesE0rAJdpO O6j0azCF/DIvoUs6vmDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTICX-0023Cs-0F; Tue, 08 Aug 2023 08:36:25 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTICT-0023Bh-1Z for linux-arm-kernel@lists.infradead.org; Tue, 08 Aug 2023 08:36:24 +0000 Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-99c136ee106so792123366b.1 for ; Tue, 08 Aug 2023 01:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691483778; x=1692088578; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sQgrfQw0P6pTmKNcUIhzKP/rgp8qN+H1U22DXchyEX8=; b=cqekJx2OUd9OxkIRqgeZm8BuUmihA4kixHMtW5alQCzTejCXWHftUNC69FanIFegOU XVbBDH89XGxDzd4APzFOkKgqCjaxX+7O2Rqc2jDu/0IEH7M+B0Q0KOwTy7Kdfkh0MZcY 6FV+cZABl+Zj256dEQmPXU8axfM/DPMbuxgoTa+fweg+aAGLmSAAlwvZrZ9qw0Q6jm+V +CnbJeGrDlIL+p8+EbAnNskiFqh9u3jSdGulX+0Su6N1kT6pyRGtrC4vnAgyDcm5l364 VWsr07FC03OcRtwJAJibGSLMAy4ohPOiCOL2vnOLjyIjBGYfqFfdLTHuXGF9c2h9q4AP Z/lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691483778; x=1692088578; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sQgrfQw0P6pTmKNcUIhzKP/rgp8qN+H1U22DXchyEX8=; b=kPXQtTFQA9cjBgfPjuHJL5fUUttwPiXpxbesLiDZVVqcBK5zs6SR9b3iY3TRGZ2tQI 8nEs3IJbCGL1GEaKm8iPfo77kXmYio0OTnimlYHvuOI4zysTi+Ma12gy/6O1frELNMY3 909WmaI3oafBApwYuEsZJwJd7sGofZMgkIqzzNTfAKiDTD6fspgU9vMoQio1uOIynqKC WHoTvtv5ij3pH6lPtOAmaRUgYQG11PAVJ7/hnWkyKMomSBkkcz2sN3lxpQTFhXPatdE3 g2ylZ4f70gHiQkY2+GK3x1iWQBDSinwOZJtB9oHq01+NNMa6hFx/zAVmeB4POdWY44js RxAw== X-Gm-Message-State: AOJu0YycbRTdEtUlr3ivbGS64BkmvjOepnDVrJQrsFaRgndLhru9Z0Bf hFzzjUKTdAaDnLL/yjSomRFX6g== X-Google-Smtp-Source: AGHT+IHOV1+SwptyB2y6PObKLYIfXb0SnPIa+qNzfFQDPldY+tNhzDRnIS3lyd9q6xt4sZxlqEOpfw== X-Received: by 2002:a17:906:84:b0:99c:980:d551 with SMTP id 4-20020a170906008400b0099c0980d551mr10554435ejc.50.1691483778414; Tue, 08 Aug 2023 01:36:18 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.113]) by smtp.gmail.com with ESMTPSA id k2-20020a1709063fc200b00993470682e5sm6344518ejj.32.2023.08.08.01.36.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Aug 2023 01:36:17 -0700 (PDT) Message-ID: Date: Tue, 8 Aug 2023 10:36:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v3 4/9] i2c: hisi: Use dev_err_probe in probe function Content-Language: en-US To: Liao Chang , andi.shyti@kernel.org, florian.fainelli@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, yangyicong@hisilicon.com, aisheng.dong@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, kblaiech@nvidia.com, asmaa@nvidia.com, loic.poulain@linaro.org, rfoss@kernel.org, ardb@kernel.org, gcherian@marvell.com Cc: linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20230808012954.1643834-1-liaochang1@huawei.com> <20230808012954.1643834-5-liaochang1@huawei.com> From: Krzysztof Kozlowski In-Reply-To: <20230808012954.1643834-5-liaochang1@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_013621_523664_CEB8D31A X-CRM114-Status: GOOD ( 18.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/08/2023 03:29, Liao Chang wrote: > Use the dev_err_probe function instead of dev_err in the probe function > so that the printed messge includes the return value and also handles > -EPROBE_DEFER nicely. > > Reviewed-by: Yicong Yang > Signed-off-by: Liao Chang > --- > drivers/i2c/busses/i2c-hisi.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-hisi.c b/drivers/i2c/busses/i2c-hisi.c > index e067671b3ce2..6fc8d6fa43b6 100644 > --- a/drivers/i2c/busses/i2c-hisi.c > +++ b/drivers/i2c/busses/i2c-hisi.c > @@ -462,18 +462,14 @@ static int hisi_i2c_probe(struct platform_device *pdev) > hisi_i2c_disable_int(ctlr, HISI_I2C_INT_ALL); > > ret = devm_request_irq(dev, ctlr->irq, hisi_i2c_irq, 0, "hisi-i2c", ctlr); > - if (ret) { > - dev_err(dev, "failed to request irq handler, ret = %d\n", ret); > - return ret; > - } > + if (ret) > + return dev_err_probe(dev, ret, "failed to request irq handler\n"); I don't think this is needed: https://lore.kernel.org/all/20230721094641.77189-1-frank.li@vivo.com/ Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel