Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jie Gan <jie.gan@oss.qualcomm.com>
To: Leo Yan <leo.yan@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@arm.com>,
	James Clark <james.clark@linaro.org>
Cc: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Tingwei Zhang <tingwei.zhang@oss.qualcomm.com>,
	Jingyi Wang <jingyi.wang@oss.qualcomm.com>,
	Abel Vesa <abel.vesa@oss.qualcomm.com>,
	Yuanfang Zhang <yuanfang.zhang@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, coresight@lists.linaro.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: kaanapali: fix traceNoC probe issue
Date: Tue, 30 Jun 2026 09:03:52 +0800	[thread overview]
Message-ID: <adb45638-1787-45cd-b4fd-d957323cc608@oss.qualcomm.com> (raw)
In-Reply-To: <20260629142848.GB1812158@e132581.arm.com>



On 6/29/2026 10:28 PM, Leo Yan wrote:
> On Mon, Jun 29, 2026 at 10:08:17AM +0800, Jie Gan wrote:
> 
> [...]
> 
>> Can I fix the issue by adding "arm,primecell-periphid" property. That's
>> would be the best temp solution as it avoids breaking the original design of
>> both the TraceNoC AMBA driver and interconnect TraceNoC platform driver.
> 
> Before proceeding with the "arm,primecell-periphid" property, could you
> clarify a bit:
> 
>    - For an interconnect TraceNoC, what would be the consequence of
>      enabling ATID? Would it simply be a no-op, or are there any side
>      effects? Or is the concern that the trace IDs could be exhausted?
> 

TPDM0(or ATB source) -> interconnect TraceNoC0 -> Aggregator TraceNoc -> 
sink
TPDM1(or ATB source) -> interconnect TraceNoC1 -> Aggregator TraceNoc -> 
sink

We only have one Aggregator TraceNoC and many interconnect TraceNoC 
devices for one platform. All interconnect TraceNoC devices are 
connected to Aggregator TraceNoC devices in the topology, so the itnoc 
doesnt need an ATID.

That's the design purpose from hardware perspective.


>    - How can you guarantee that a interconnect TraceNoC will never
>      require ATID in the future?
> 

The interconnect TraceNoC is primarily introduced to reduce routing 
complexity in the hardware design. It is typically deployed as an 
intermediate TraceNoC that connects to an Aggregator TraceNoC (AG TraceNoC).

For example, a modem subsystem may contain many TPDM devices. Directly 
connecting every TPDM to the AG TraceNoC would result in significant 
wiring complexity. Instead, an itnoc is placed within the modem 
subsystem to locally aggregate the TPDM connections. All TPDMs first 
connect to the itnoc, and the itnoc then connects to the system-level AG 
TraceNoC.

 From a hardware perspective, there is no fundamental difference between 
an itnoc and an AG TraceNoC. They use the same TraceNoC hardware 
implementation and share the same AMBA bus type. The distinction is 
purely functional: an itnoc is used for local trace aggregation within a 
subsystem, whereas an AG TraceNoC serves as the top-level aggregation 
point for the SoC.

Thanks,
Jie

>> The TraceNoC device here must be treated as an AMBA device and I am
>> continuing to investigate the issue with our hardware team.
> 
>> We aim to fix it from hardware perspetive for existing platforms if possible
>> and ensure it is fixed in future platforms.
> 
> I'm concerned that all of use end up repeatedly fixing similar issues
> whenever hardware configurations change or modules are reused in
> different topologies.
> 
> For example, if future platforms may require ATID support for an
> interconnect TraceNoC, then the issue will pop up again.
> 
> Thanks,
> Leo



  reply	other threads:[~2026-06-30  1:04 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-24  9:49 [PATCH v2 0/2] Fix traceNoC probe issue on Kaanapali Jie Gan
2026-06-24  9:49 ` [PATCH v2 1/2] dt-bindings: arm: qcom,coresight-tnoc: allow arm,primecell-periphid Jie Gan
2026-06-25  7:24   ` Krzysztof Kozlowski
2026-06-25  7:36     ` Jie Gan
2026-06-24  9:49 ` [PATCH v2 2/2] arm64: dts: qcom: kaanapali: fix traceNoC probe issue Jie Gan
2026-06-24 13:27   ` Konrad Dybcio
2026-06-24 13:48     ` Jie Gan
2026-06-24 13:51       ` Suzuki K Poulose
2026-06-24 15:08         ` Jie Gan
2026-06-24 15:16           ` Leo Yan
2026-06-25  1:01             ` Jie Gan
2026-06-25  8:56               ` Leo Yan
2026-06-26  2:03                 ` Jie Gan
2026-06-26 10:30                   ` Leo Yan
2026-06-26 12:09                     ` Jie Gan
2026-06-26 15:49                       ` Leo Yan
2026-06-29  2:08                         ` Jie Gan
2026-06-29 14:28                           ` Leo Yan
2026-06-30  1:03                             ` Jie Gan [this message]
2026-06-30  8:10                               ` Leo Yan
2026-06-30  8:42                                 ` Jie Gan
2026-06-30 10:01                                   ` Leo Yan
2026-06-30  8:21                               ` Suzuki K Poulose
2026-06-24 14:25   ` Leo Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adb45638-1787-45cd-b4fd-d957323cc608@oss.qualcomm.com \
    --to=jie.gan@oss.qualcomm.com \
    --cc=abel.vesa@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=coresight@lists.linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=james.clark@linaro.org \
    --cc=jingyi.wang@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=leo.yan@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.leach@arm.com \
    --cc=robh@kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=tingwei.zhang@oss.qualcomm.com \
    --cc=yuanfang.zhang@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox