From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Michal Simek <michal.simek@xilinx.com>, Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
"David S . Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH RESEND net] net: phy: xgmiitorgmii: Support generic PHY status read
Date: Thu, 21 Feb 2019 11:24:47 +0100 [thread overview]
Message-ID: <adbb183836e22dfc4558beaa818677c24bacf3a8.camel@bootlin.com> (raw)
In-Reply-To: <f0020e39-7ace-e1e0-e629-b84d6f92b841@xilinx.com>
Hi,
On Wed, 2019-02-20 at 07:58 +0100, Michal Simek wrote:
> Hi,
>
> On 19. 02. 19 18:25, Andrew Lunn wrote:
> > > Thanks for the suggestion! So I had a closer look at that driver to try
> > > and see what could go wrong and it looks like I found a few things
> > > there.
> >
> > Hi Paul
> >
> > Yes, this driver has issues. If i remember correctly, it got merged
> > while i was on vacation. I pointed out a few issues, but the authors
> > never responded. Feel free to fix it up.
>
> Will be good to know who was that person.
>
> I can't do much this week with this because responsible person for this
> driver is out of office this week. That's why please give us some time
> to get back to this.
Understood. I think we need to start a discussion about how the general
design of this driver can be improved.
In particular, I wonder if it could work better to make this driver a
PHY driver that just redirects all its ops to the actual PHY driver,
except for read_status where it should also add some code.
Maybe we could also manage to expose a RGMII PHY mode to the actual PHY
this way. Currently, the PHY mode has to be set to GMII for the MAC to
be configured correctly, but the PHY also gets this information while
it should be told that RGMII is in use. This doesn't seem to play a big
role in PHY configuration though, but it's still inadequate.
What do you think?
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-21 10:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 16:32 [PATCH RESEND net] net: phy: xgmiitorgmii: Support generic PHY status read Paul Kocialkowski
2019-02-15 17:02 ` Andrew Lunn
2019-02-15 17:38 ` Florian Fainelli
2019-02-15 18:34 ` Paul Kocialkowski
2019-02-15 18:53 ` Florian Fainelli
2019-02-19 9:56 ` Paul Kocialkowski
2019-02-19 17:25 ` Andrew Lunn
2019-02-20 6:58 ` Michal Simek
2019-02-21 10:24 ` Paul Kocialkowski [this message]
2019-02-21 11:03 ` Michal Simek
2019-02-27 8:43 ` Michal Simek
2019-02-27 9:05 ` Harini Katakam
2019-02-28 7:33 ` Harini Katakam
2019-03-09 12:09 ` Harini Katakam
2019-03-09 16:19 ` Andrew Lunn
2019-03-11 6:04 ` Harini Katakam
2019-03-11 12:27 ` Harini Katakam
2019-03-11 12:51 ` Michal Simek
2019-03-11 6:45 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adbb183836e22dfc4558beaa818677c24bacf3a8.camel@bootlin.com \
--to=paul.kocialkowski@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).