Re: [PATCH 3/3] ASoC: pxa: integrate sound/arm/pxa2xx into sound/soc/pxa2xx

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Mon, Apr 27, 2026 at 05:58:00PM +0200, Arnd Bergmann wrote:
> On Mon, Apr 27, 2026, at 17:52, Andy Shevchenko wrote:
> > On Mon, Apr 27, 2026 at 04:46:31PM +0200, Arnd Bergmann wrote:
> >
> >> The pxa2xx sound library modules are only used by the ASoC driver since
> >> commit b094de7810f3 ("ASoC: codec: Remove pxa2xx-ac97.c"), so move the
> >> code into the one module that uses as a simpliciation.
> >
> > Is this part of the series that touches UDC? Btw, the UDC one despite on being
> > mentioned as v2 in the changelog still have no versioning in the Subject.
> 
> Both patches came out of my work to hide the last users of GPIO numbers
> behind CONFIG_GPIO_LEGACY that I first posted last year. A lot of my
> patches got merged (or replaced with other work) in the meantime,
> so there are only a few drivers and platforms left that won't use
> GPIO descriptors any time soon.

I'm fine with that, I just got patch for UDC and patches 2 and 3 out of 3 of
some series related to ASoC PXA. I was wondering if they are coming from the
same series. Anyway, it's not so important.

...

> > What a lovely change! I would like to give a tag, but see a comment below.
> 
> >> +extern int pxa2xx_soc_pcm_new(struct snd_soc_component *component,
> >> +			      struct snd_soc_pcm_runtime *rtd);
> >
> > Can we kill 'extern' while at it?
> 
> I can change that, though I usually try to minimize changes to
> code that I just move around.

I don't see the point to have another patch to drop 'extern' while we anyway
move the code around and all those are being touched.

-- 
With Best Regards,
Andy Shevchenko