From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27BCDC43381 for ; Sat, 30 Mar 2019 16:39:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA6A12146F for ; Sat, 30 Mar 2019 16:39:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XwvHVsEP"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="gHvSRmbT"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="EQqPvFDb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA6A12146F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+e3n3fX28xcRsfFNQvlLapdGAVEg7gu4dNd+jZSoYxQ=; b=XwvHVsEP6W54KPXo+yx8Ii51M t9Q8aQUzT88ZIgCtJgqhyG2+nZgiFkGb9M+3zlfCNFqKC25GpVHiHepuUNzaog+Uj4rdMh9UolcwK Q7TB+Zl0IGN+dSfz5AxZaz8ysQp52d+pHoub7Zxaf4EKWF4vQd7/s2i+pCaFTgHlRSDqDyg/XxhVN qYwJiRQOdnOx4ugnyTP/YfaO7++FY/XHw8ovM7xjoAOZuUEGt9oksKHE6l+UnUTPlmR+aX+kgP2KZ 0k7uNPrad1lTGeI7psmfrt5UPfn7BALtPfIQtOM/GlwWAlkoE8xFdLo+jx5S1iU6qNx4Ax2H9ZHmw tbCKybOqg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAH0k-0001mk-Bt; Sat, 30 Mar 2019 16:39:14 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAH0Y-0001ZE-P8; Sat, 30 Mar 2019 16:39:06 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id C457E60ADE; Sat, 30 Mar 2019 16:39:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1553963941; bh=Co9dNLzvCqN5cyB9tc1+ZDc3Ab1HcLsdrQHHP69FeeM=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=gHvSRmbToflNSNZOkfQVoDERP/DllCZ474t54q2WyaZ/53P8zwp1yvzAvUfQNUS1T MA85Wav2zV28OClNpsqKFtgOcu3DLGNVN9L2vHyGJe34eXVeJh5IuK/QwrlMec8OhP s+LHZ4+oxMipeMg+InTOsNvQGOJslIAV3xL1bYNc= Received: from [10.79.169.97] (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mojha@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 2C9FF60736; Sat, 30 Mar 2019 16:38:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1553963940; bh=Co9dNLzvCqN5cyB9tc1+ZDc3Ab1HcLsdrQHHP69FeeM=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=EQqPvFDbc/L3TZIpQgHHFD5TdMdd/N9kveUekqRgtXANF8thDIcF2MUSzkr2jrSWr wx77Dd+VucrkEvqlMAqs1yc5WZnepBHc3xYlJo8raI0OMLdybE3OG9f3/RzGSQ91J8 WtPw6kLCHyKi2QV74gcKBIeJGYtTaOiCyki7V+JY= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2C9FF60736 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=mojha@codeaurora.org Subject: Re: [PATCH] PCI: rockchip: fix bitwise operations on status and ROCKCHIP_PCIE_EP_CMD_STATUS_IS To: Colin King , Lorenzo Pieralisi , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org References: <20190330150910.9389-1-colin.king@canonical.com> From: Mukesh Ojha Message-ID: Date: Sat, 30 Mar 2019 22:08:45 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190330150910.9389-1-colin.king@canonical.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190330_093903_276948_FA38DEC3 X-CRM114-Status: GOOD ( 16.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shawn Lin , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/30/2019 8:39 PM, Colin King wrote: > From: Colin Ian King > > Currently the bitwise operations on the u16 variable 'status' with > the setting ROCKCHIP_PCIE_EP_CMD_STATUS_IS are incorrect because > ROCKCHIP_PCIE_EP_CMD_STATUS_IS is 1UL<<19 which is wider than the > u16 variable. Fix this by making status a u32. (Not tested). > > Fixes: cf590b078391 ("PCI: rockchip: Add EP driver for Rockchip PCIe controller") > Signed-off-by: Colin Ian King > --- > drivers/pci/controller/pcie-rockchip-ep.c | 2 +- Looks valid to me. Reviewed-by: Mukesh Ojha Cheers, -Mukesh > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/pcie-rockchip-ep.c b/drivers/pci/controller/pcie-rockchip-ep.c > index a5d799e2dff2..d743b0a48988 100644 > --- a/drivers/pci/controller/pcie-rockchip-ep.c > +++ b/drivers/pci/controller/pcie-rockchip-ep.c > @@ -350,7 +350,7 @@ static void rockchip_pcie_ep_assert_intx(struct rockchip_pcie_ep *ep, u8 fn, > struct rockchip_pcie *rockchip = &ep->rockchip; > u32 r = ep->max_regions - 1; > u32 offset; > - u16 status; > + u32 status; > u8 msg_code; > > if (unlikely(ep->irq_pci_addr != ROCKCHIP_PCIE_EP_PCI_LEGACY_IRQ_ADDR || _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel