From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4FEEC433EF for ; Tue, 28 Jun 2022 17:58:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IzT4c2sPkHlFcLao/aJQAZuSu3WR2Xw3v4NnZ1F8HGQ=; b=krJiWbs1LBFFx2 wfnwaIje1VHc8E1tS9is9UAVMFVIjJAyrMl7f5o6r+4fmL+T1JglExGFlLVglzWcWXc5VA2RvZDp8 MMjU7tJpjGHwuPKMThl5/pdg/iyrx1sHSCfnL2H88SaVmSIJZpc6piM5V5HdmlT6kkRLe7aS0KXhq LwklI1f7PL0jfa0do5SWrBmyxhrObMExt4j/2W6U3A34rlNnxoqDNfOp2lUZCrGqQvnEKIgzsanqu wX+BEUnb+zfxk11/WuVtkGH32OLnSooP3x8bdwimmV+PkHiexIs3kH3qBVp2njCtESzawcb9wp1qv 5Nx/E37ukD53bZ7KrfMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6FTA-007UaS-50; Tue, 28 Jun 2022 17:57:48 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6FT7-007UZF-9X for linux-arm-kernel@lists.infradead.org; Tue, 28 Jun 2022 17:57:46 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2EAC3619FD; Tue, 28 Jun 2022 17:57:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16210C3411D; Tue, 28 Jun 2022 17:57:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656439063; bh=1JjIFtMxSAjXxKXlrad51iQP0xJ0nZGZHeaMFImOkzY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=WnhADcWq8IE1VbtDiU1HIgW/N4NCgUk8ASDoRNgqDK2Yy3wEgQwA90Wsd4jh1n2gR GIn6urs2oxsxNfo1siBgV895ZuaJ1wkaNM7lpFLRSjHsUz/19nGoLJrOPFeGMH99kp BGObeKo5gUWbc2ZUhbVwMExSWbZEXpzu9zhItXjDHryAKq03Xa0/dg4sPCKoZyqkE7 PPzAjhkvsSTVgzUhknswoTAqpPo/ykbdVYmSo+wfNZV8rHg8YSnFkX5FuHQeD/duQx IwYPbcFcXxPN1vbOFJIJkA7c+2HYh9FjixrAsib4gPfzaePW1biRiTH99GyTd+FUdh ZB49EgKXm2aFw== Message-ID: Date: Tue, 28 Jun 2022 20:57:36 +0300 MIME-Version: 1.0 Subject: Re: [PATCH V2 8/9] interconnect: imx: configure NoC mode/prioriry/ext_control Content-Language: en-US To: "Peng Fan (OSS)" , shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, abel.vesa@nxp.com, abailon@baylibre.com, l.stach@pengutronix.de, laurent.pinchart@ideasonboard.com, marex@denx.de, paul.elder@ideasonboard.com, Markus.Niebel@ew.tq-group.com, aford173@gmail.com Cc: kernel@pengutronix.de, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com, abelvesa@kernel.org, Peng Fan References: <20220616073320.2203000-1-peng.fan@oss.nxp.com> <20220616073320.2203000-9-peng.fan@oss.nxp.com> From: Georgi Djakov In-Reply-To: <20220616073320.2203000-9-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220628_105745_466039_F68B6ED9 X-CRM114-Status: GOOD ( 19.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Peng, On 16.06.22 10:33, Peng Fan (OSS) wrote: > From: Peng Fan > > Introduce imx_icc_noc_setting structure to describe a master port setting > Pass imx_icc_noc_setting as a parameter from specific driver > Set priority level, mode, ext control in imx_icc_node_set > > Signed-off-by: Peng Fan > --- > drivers/interconnect/imx/imx.c | 43 ++++++++++++++++++++++++++---- > drivers/interconnect/imx/imx.h | 44 ++++++++++++++++++++++++++++++- > drivers/interconnect/imx/imx8mm.c | 2 +- > drivers/interconnect/imx/imx8mn.c | 2 +- > drivers/interconnect/imx/imx8mq.c | 2 +- > 5 files changed, 84 insertions(+), 9 deletions(-) > > diff --git a/drivers/interconnect/imx/imx.c b/drivers/interconnect/imx/imx.c > index 78557fe6da2c..bd728caf2b85 100644 [..] > @@ -37,8 +40,24 @@ static int imx_icc_node_set(struct icc_node *node) > { > struct device *dev = node->provider->dev; > struct imx_icc_node *node_data = node->data; > + void __iomem *base; > + u32 prio; > u64 freq; > > + if (node_data->setting && !node_data->setting->ignore && node->peak_bw) { > + base = node_data->setting->reg + node_data->imx_provider->noc_base; > + if (node_data->setting->mode == IMX_NOC_MODE_FIXED) { > + prio = node_data->setting->prio_level; > + prio = PRIORITY_COMP_MARK | (prio << 8) | prio; > + writel(prio, base + IMX_NOC_PRIO_REG); > + writel(node_data->setting->mode, base + IMX_NOC_MODE_REG); > + writel(node_data->setting->ext_control, base + IMX_NOC_EXT_CTL_REG); > + } else { > + dev_info(dev, "mode: %d not supported\n", node_data->setting->mode); > + return -ENOTSUPP; Nit: I believe that -EOPNOTSUPP is the preferred error code. > + } > + } > + > if (!node_data->qos_dev) > return 0; > [..] > @@ -237,7 +263,8 @@ static int get_max_node_id(struct imx_icc_node_desc *nodes, int nodes_count) > } > > int imx_icc_register(struct platform_device *pdev, > - struct imx_icc_node_desc *nodes, int nodes_count) > + struct imx_icc_node_desc *nodes, int nodes_count, > + struct imx_icc_noc_setting *settings) > { > struct device *dev = &pdev->dev; > struct icc_onecell_data *data; > @@ -267,13 +294,19 @@ int imx_icc_register(struct platform_device *pdev, > provider->dev->of_node = dev->parent->of_node; > platform_set_drvdata(pdev, imx_provider); > > + if (settings) { > + imx_provider->noc_base = devm_of_iomap(dev, provider->dev->of_node, 0, NULL); > + if (!imx_provider->noc_base) devm_of_iomap() returns ERR_PTR(). So we should check it with IS_ERR(). Thanks, Georgi > + return PTR_ERR(imx_provider->noc_base); > + } > + > ret = icc_provider_add(provider); > if (ret) { > dev_err(dev, "error adding interconnect provider: %d\n", ret); > return ret; > } > > - ret = imx_icc_register_nodes(imx_provider, nodes, nodes_count); > + ret = imx_icc_register_nodes(imx_provider, nodes, nodes_count, settings); > if (ret) > goto provider_del; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel