[PATCH 0/4] "scm_conf" node cleanup for TI's Jacinto SoC family

[PATCH 0/4] "scm_conf" node cleanup for TI's Jacinto SoC family

[Jayesh Choudhary]

Hello All,

Now that we have PCIE ctrl node in scm_conf[0], we can go ahead and
convert "scm_conf" from "syscon" to "simple-bus".

For J7200, J721E and J721S2, "scm_conf" node is converted from a "syscon"
to a "simple-bus".
For J784S4, it removes the unnecessary "reg" property from "scm_conf" node
which already has a "simple-bus" compatible.

[0]: https://lore.kernel.org/all/174500270525.95799.12263001003103973109.b4-ty@ti.com/

Jayesh Choudhary (4):
  arm64: dts: ti: k3-j721e-main: Make the "scm_conf" node a "simple-bus"
  arm64: dts: ti: k3-j7200-main: Make the "scm_conf" node a "simple-bus"
  arm64: dts: ti: k3-j721s2-main: Make the "scm_conf" node a
    "simple-bus"
  arm64: dts: ti: k3-j784s4-j742s2-main-common: Remove "reg" from
    "scm_conf"

 arch/arm64/boot/dts/ti/k3-j7200-main.dtsi                | 5 ++---
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi                | 5 ++---
 arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi               | 5 ++---
 arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi | 1 -
 4 files changed, 6 insertions(+), 10 deletions(-)

-- 
2.34.1

[PATCH 1/4] arm64: dts: ti: k3-j721e-main: Make the "scm_conf" node a "simple-bus"

[Jayesh Choudhary]

The "scm_conf" bus need not be "syscon". Now that we have "pcie*_ctrl"
child nodes for "ti,syscon-pcie-ctrl" property in "pcie" nodes, change
"scm_conf" node to "simple-bus".
Also remove "reg" property as it is not needed by "simple-bus".

Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
index 5bd0d36bf33e..4e01c1265ae9 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
@@ -37,9 +37,8 @@ atf-sram@0 {
 		};
 	};
 
-	scm_conf: scm-conf@100000 {
-		compatible = "ti,j721e-system-controller", "syscon", "simple-mfd";
-		reg = <0 0x00100000 0 0x1c000>; /* excludes pinctrl region */
+	scm_conf: bus@100000 {
+		compatible = "simple-bus";
 		#address-cells = <1>;
 		#size-cells = <1>;
 		ranges = <0x0 0x0 0x00100000 0x1c000>;
-- 
2.34.1

Re: [PATCH 1/4] arm64: dts: ti: k3-j721e-main: Make the "scm_conf" node a "simple-bus"

[Siddharth Vadapalli]

On Tue, Jun 03, 2025 at 03:26:06PM +0530, Jayesh Choudhary wrote:
> The "scm_conf" bus need not be "syscon". Now that we have "pcie*_ctrl"
> child nodes for "ti,syscon-pcie-ctrl" property in "pcie" nodes, change
> "scm_conf" node to "simple-bus".
> Also remove "reg" property as it is not needed by "simple-bus".
> 
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>

Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>

Regards,
Siddharth.

Re: [PATCH 1/4] arm64: dts: ti: k3-j721e-main: Make the "scm_conf" node a "simple-bus"

[Krzysztof Kozlowski]

On 03/06/2025 11:56, Jayesh Choudhary wrote:
> The "scm_conf" bus need not be "syscon". Now that we have "pcie*_ctrl"
> child nodes for "ti,syscon-pcie-ctrl" property in "pcie" nodes, change
> "scm_conf" node to "simple-bus".
> Also remove "reg" property as it is not needed by "simple-bus".

This (possibly) affects all other users of DTS which were expecting this
ABI. It's not only about forward-compatibility, but other projects.

Maybe this doe snot matter for you, so explain that in commit msg and
provide rationale why you are affecting other users.



Best regards,
Krzysztof

Re: [PATCH 1/4] arm64: dts: ti: k3-j721e-main: Make the "scm_conf" node a "simple-bus"

[Jayesh Choudhary]

Hello Krzysztof,

On 03/06/25 16:32, Krzysztof Kozlowski wrote:
> On 03/06/2025 11:56, Jayesh Choudhary wrote:
>> The "scm_conf" bus need not be "syscon". Now that we have "pcie*_ctrl"
>> child nodes for "ti,syscon-pcie-ctrl" property in "pcie" nodes, change
>> "scm_conf" node to "simple-bus".
>> Also remove "reg" property as it is not needed by "simple-bus".
> 
> This (possibly) affects all other users of DTS which were expecting this
> ABI. It's not only about forward-compatibility, but other projects.
> 
> Maybe this doe snot matter for you, so explain that in commit msg and
> provide rationale why you are affecting other users.
> 
> 

This should not affect other users of DTS. J784S4 already has this
change and it serves as a validation that DT nodes are compatible
with other projects (for example uboot driver handles it).
Other SoCs are being modified with taking J784S4 as a working reference.

Considering this, do I still need to add something? Or is it okay
since I am not exactly affecting other projects?
Should I add something along the lines of "similar to j784s4...."?


Warm Regards,
Jayesh

> 
> Best regards,
> Krzysztof

Re: [PATCH 1/4] arm64: dts: ti: k3-j721e-main: Make the "scm_conf" node a "simple-bus"

[Jayesh Choudhary]

Hello Krzysztof,

On 04/06/25 15:18, Jayesh Choudhary wrote:
> Hello Krzysztof,
> 
> On 03/06/25 16:32, Krzysztof Kozlowski wrote:
>> On 03/06/2025 11:56, Jayesh Choudhary wrote:
>>> The "scm_conf" bus need not be "syscon". Now that we have "pcie*_ctrl"
>>> child nodes for "ti,syscon-pcie-ctrl" property in "pcie" nodes, change
>>> "scm_conf" node to "simple-bus".
>>> Also remove "reg" property as it is not needed by "simple-bus".
>>
>> This (possibly) affects all other users of DTS which were expecting this
>> ABI. It's not only about forward-compatibility, but other projects.
>>
>> Maybe this doe snot matter for you, so explain that in commit msg and
>> provide rationale why you are affecting other users.
>>
>>
> 
> This should not affect other users of DTS. J784S4 already has this
> change and it serves as a validation that DT nodes are compatible
> with other projects (for example uboot driver handles it).
> Other SoCs are being modified with taking J784S4 as a working reference.
> 
> Considering this, do I still need to add something? Or is it okay
> since I am not exactly affecting other projects?
> Should I add something along the lines of "similar to j784s4...."?
> 

Gentle ping on the above comment.

I have checked other projects like Barebox. That supports TI K3 SoC
but only AM62x and AM62L. Nothing in this series affects it.

Warm Regards,
Jayesh


> 
>>
>> Best regards,
>> Krzysztof

Re: [PATCH 1/4] arm64: dts: ti: k3-j721e-main: Make the "scm_conf" node a "simple-bus"

[Krzysztof Kozlowski]

On 01/07/2025 12:23, Jayesh Choudhary wrote:
> Hello Krzysztof,
> 
> On 04/06/25 15:18, Jayesh Choudhary wrote:
>> Hello Krzysztof,
>>
>> On 03/06/25 16:32, Krzysztof Kozlowski wrote:
>>> On 03/06/2025 11:56, Jayesh Choudhary wrote:
>>>> The "scm_conf" bus need not be "syscon". Now that we have "pcie*_ctrl"
>>>> child nodes for "ti,syscon-pcie-ctrl" property in "pcie" nodes, change
>>>> "scm_conf" node to "simple-bus".
>>>> Also remove "reg" property as it is not needed by "simple-bus".
>>>
>>> This (possibly) affects all other users of DTS which were expecting this
>>> ABI. It's not only about forward-compatibility, but other projects.
>>>
>>> Maybe this doe snot matter for you, so explain that in commit msg and
>>> provide rationale why you are affecting other users.
>>>
>>>
>>
>> This should not affect other users of DTS. J784S4 already has this
>> change and it serves as a validation that DT nodes are compatible
>> with other projects (for example uboot driver handles it).
>> Other SoCs are being modified with taking J784S4 as a working reference.
>>
>> Considering this, do I still need to add something? Or is it okay
>> since I am not exactly affecting other projects?
>> Should I add something along the lines of "similar to j784s4...."?
>>
> 
> Gentle ping on the above comment.
> 
> I have checked other projects like Barebox. That supports TI K3 SoC
> but only AM62x and AM62L. Nothing in this series affects it.

Your answer is really not sufficient, just something to reply so I will
bug off, so I decided to ignore it.

This affects other projects - it is clearly visible in the diff. You
removed a compatible and you cannot do that.

Best regards,
Krzysztof

[PATCH 2/4] arm64: dts: ti: k3-j7200-main: Make the "scm_conf" node a "simple-bus"

[Jayesh Choudhary]

The "scm_conf" bus need not be "syscon". Now that we have "pcie*_ctrl"
child nodes for "ti,syscon-pcie-ctrl" property in "pcie" nodes, change
"scm_conf" node to "simple-bus".
Also remove "reg" property as it is not needed by "simple-bus".

Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
index 5ce5f0a3d6f5..a3f6eea9d325 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
@@ -25,9 +25,8 @@ atf-sram@0 {
 		};
 	};
 
-	scm_conf: scm-conf@100000 {
-		compatible = "ti,j721e-system-controller", "syscon", "simple-mfd";
-		reg = <0x00 0x00100000 0x00 0x1c000>;
+	scm_conf: bus@100000 {
+		compatible = "simple-bus";
 		#address-cells = <1>;
 		#size-cells = <1>;
 		ranges = <0x00 0x00 0x00100000 0x1c000>;
-- 
2.34.1

Re: [PATCH 2/4] arm64: dts: ti: k3-j7200-main: Make the "scm_conf" node a "simple-bus"

[Siddharth Vadapalli]

On Tue, Jun 03, 2025 at 03:26:07PM +0530, Jayesh Choudhary wrote:
> The "scm_conf" bus need not be "syscon". Now that we have "pcie*_ctrl"
> child nodes for "ti,syscon-pcie-ctrl" property in "pcie" nodes, change
> "scm_conf" node to "simple-bus".
> Also remove "reg" property as it is not needed by "simple-bus".
> 
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>

Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>

Regards,
Siddharth.

[PATCH 3/4] arm64: dts: ti: k3-j721s2-main: Make the "scm_conf" node a "simple-bus"

[Jayesh Choudhary]

The "scm_conf" bus need not be "syscon". Now that we have "pcie*_ctrl"
child nodes for "ti,syscon-pcie-ctrl" property in "pcie" nodes, change
"scm_conf" node to "simple-bus".
Also remove "reg" property as it is not needed by "simple-bus".

Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
index 83cf0adb2cb7..605f753d3258 100644
--- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
@@ -37,9 +37,8 @@ l3cache-sram@200000 {
 		};
 	};
 
-	scm_conf: syscon@104000 {
-		compatible = "ti,j721e-system-controller", "syscon", "simple-mfd";
-		reg = <0x00 0x00104000 0x00 0x18000>;
+	scm_conf: bus@104000 {
+		compatible = "simple-bus";
 		#address-cells = <1>;
 		#size-cells = <1>;
 		ranges = <0x00 0x00 0x00104000 0x18000>;
-- 
2.34.1

Re: [PATCH 3/4] arm64: dts: ti: k3-j721s2-main: Make the "scm_conf" node a "simple-bus"

[Siddharth Vadapalli]

On Tue, Jun 03, 2025 at 03:26:08PM +0530, Jayesh Choudhary wrote:
> The "scm_conf" bus need not be "syscon". Now that we have "pcie*_ctrl"
> child nodes for "ti,syscon-pcie-ctrl" property in "pcie" nodes, change
> "scm_conf" node to "simple-bus".
> Also remove "reg" property as it is not needed by "simple-bus".
> 
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>

Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>

Regards,
Siddharth.

[PATCH 4/4] arm64: dts: ti: k3-j784s4-j742s2-main-common: Remove "reg" from "scm_conf"

[Jayesh Choudhary]

Remove "reg" property from "scm_conf" node as it is not needed by
"simple-bus".

Fixes: 7287d423f138 ("arm64: dts: ti: k3-j784s4-main: Add system controller and SERDES lane mux")
Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi
index 363d68fec387..9fcfa403824b 100644
--- a/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j784s4-j742s2-main-common.dtsi
@@ -47,7 +47,6 @@ l3cache-sram@200000 {
 
 	scm_conf: bus@100000 {
 		compatible = "simple-bus";
-		reg = <0x00 0x00100000 0x00 0x1c000>;
 		#address-cells = <1>;
 		#size-cells = <1>;
 		ranges = <0x00 0x00 0x00100000 0x1c000>;
-- 
2.34.1

Re: [PATCH 4/4] arm64: dts: ti: k3-j784s4-j742s2-main-common: Remove "reg" from "scm_conf"

[Siddharth Vadapalli]

On Tue, Jun 03, 2025 at 03:26:09PM +0530, Jayesh Choudhary wrote:
> Remove "reg" property from "scm_conf" node as it is not needed by
> "simple-bus".
> 
> Fixes: 7287d423f138 ("arm64: dts: ti: k3-j784s4-main: Add system controller and SERDES lane mux")
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>

Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>

Regards,
Siddharth.