From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: "Markus Elfring" <Markus.Elfring@web.de>,
"Algea Cao" <algea.cao@rock-chips.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, kernel@collabora.com,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Andy Yan" <andy.yan@rock-chips.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David Airlie" <airlied@gmail.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Mark Yao" <markyao0591@gmail.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Rob Herring" <robh@kernel.org>, "Robert Foss" <rfoss@kernel.org>,
"Sandy Huang" <hjc@rock-chips.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Thomas Zimmermann" <tzimmermann@suse.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Alexandre Arnoud <aarnoud@me.com>,
Luis de Arquer <ldearquer@gmail.com>
Subject: Re: [PATCH v5 2/4] drm/bridge: synopsys: Add DW HDMI QP TX Controller support library
Date: Tue, 10 Sep 2024 18:52:35 +0300 [thread overview]
Message-ID: <ae4db880-d64c-446b-bbf8-954b7bebca83@collabora.com> (raw)
In-Reply-To: <ab8a17d0-9505-4e81-b5ec-4a3025c48245@web.de>
On 9/8/24 12:11 PM, Markus Elfring wrote:
> …
>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c
>> @@ -0,0 +1,708 @@
> …
>> +static int dw_hdmi_qp_i2c_xfer(struct i2c_adapter *adap,
>> + struct i2c_msg *msgs, int num)
>> +{
> …
>> + mutex_lock(&i2c->lock);
> …
>> + dw_hdmi_qp_mod(hdmi, 0, I2CM_OP_DONE_MASK_N | I2CM_NACK_RCVD_MASK_N,
>> + MAINUNIT_1_INT_MASK_N);
>> +
>> + mutex_unlock(&i2c->lock);
>> +
>> + return ret;
>> +}
> …
>
> Under which circumstances would you become interested to apply a statement
> like “guard(mutex)(&i2c->lock);”?
> https://elixir.bootlin.com/linux/v6.11-rc6/source/include/linux/mutex.h#L196
Applied for the upcoming v7.
Thanks,
Cristian
next prev parent reply other threads:[~2024-09-10 15:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 21:55 [PATCH v5 0/4] Add initial support for the Rockchip RK3588 HDMI TX Controller Cristian Ciocaltea
2024-08-30 21:55 ` [PATCH v5 1/4] dt-bindings: display: bridge: Add schema for Synopsys DW HDMI QP TX IP Cristian Ciocaltea
2024-08-31 6:16 ` Krzysztof Kozlowski
2024-08-31 13:58 ` Heiko Stübner
[not found] ` <aee7b364-39df-4eb4-a823-4e734f104982@collabora.com>
2024-09-01 6:40 ` Andy Yan
2024-09-01 10:23 ` Krzysztof Kozlowski
2024-08-30 21:55 ` [PATCH v5 2/4] drm/bridge: synopsys: Add DW HDMI QP TX Controller support library Cristian Ciocaltea
2024-09-08 9:11 ` Markus Elfring
2024-09-10 15:52 ` Cristian Ciocaltea [this message]
2024-08-30 21:55 ` [PATCH v5 3/4] dt-bindings: display: rockchip: Add schema for RK3588 HDMI TX Controller Cristian Ciocaltea
2024-08-31 6:13 ` Krzysztof Kozlowski
2024-08-30 21:55 ` [PATCH v5 4/4] drm/rockchip: Add basic RK3588 HDMI output support Cristian Ciocaltea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae4db880-d64c-446b-bbf8-954b7bebca83@collabora.com \
--to=cristian.ciocaltea@collabora.com \
--cc=Markus.Elfring@web.de \
--cc=aarnoud@me.com \
--cc=airlied@gmail.com \
--cc=algea.cao@rock-chips.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=ldearquer@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=markyao0591@gmail.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).