From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E590BEDE99F for ; Tue, 10 Sep 2024 15:55:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+uBuRlf+UIk9Wo768Ja9aPkCv8hEgAIjDsdhd2Ydoxc=; b=KquTFOUTfFxh7JB4LrZIWvL/rD q4vmDj0BjlVHHgn+n2+ZivpxEvurumIBp5AX3eWQIJlxP5sxh8uurQlJcbgZNPIN4fPO5fP52rEEP fXhNPZVCKuDULaEcmaRnHX1KeWXKxcCZix4fmncphFd3kCPJfqUst1bDqs2zHz5dQPU3JjA1tm+d1 XMLfH1N5ZHoxZN7Ec+7MMUoRYE96xHkAQXV6xk3l1ZpqCPHTWWrFs8TpSaWWV1KGEqEcSkYHMeQ3R fWHHrQEGxSVzRo1LdUy/InQxnE/mKFdXeyHb+C2yn5nESsQ53qgUvhj0anyZJtYGEyEBGc/LHX1vT oMPQpeFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1so3Cm-00000006F4K-06AL; Tue, 10 Sep 2024 15:55:00 +0000 Received: from bali.collaboradmins.com ([148.251.105.195]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1so3AU-00000006EUu-3jZp; Tue, 10 Sep 2024 15:52:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1725983557; bh=VqVYu4N/Tf1UtM3sawFVKjYsdrOcwFFbjlE2c3Q5n6o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=eQguQaDhVq678MgrPKfPcNoIMM+tkkuOFHGC4Nfix43E7Oqd4JTJqZUW3043HaUQG brN2zMOxEQ3YE8qsp8XT8qjaxfA0cPPhVj8mE+aPqHARpYIhuBv95ZYVNOJeN9JTIK 8rxZ1EjcGMV0Ui7aHnw6oltLy99/yrWBpYKKvue3LZ9cTlX4TGsN0iS6ab8lG4xB+a 45uzTdAnunuUvTjqO+unl/H+VH802SJaVkurGGZ2oB/abHUN2tctLqmN6tBxbkEzGT aCxBdWj+tSvxBaN3Dtj74F7fRp23DVaapGtixCj6b9zk7xbvOrmcLlm4QeLSmOuwHh TcOWGrZ9IzLsA== Received: from [192.168.1.90] (unknown [188.27.55.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 3B9FA17E12D3; Tue, 10 Sep 2024 17:52:36 +0200 (CEST) Message-ID: Date: Tue, 10 Sep 2024 18:52:35 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/4] drm/bridge: synopsys: Add DW HDMI QP TX Controller support library To: Markus Elfring , Algea Cao , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@collabora.com, Andrzej Hajda , Andy Yan , Conor Dooley , Daniel Vetter , David Airlie , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Jernej Skrabec , Jonas Karlman , Krzysztof Kozlowski , Laurent Pinchart , Maarten Lankhorst , Mark Yao , Maxime Ripard , Neil Armstrong , Rob Herring , Robert Foss , Sandy Huang , Sascha Hauer , Thomas Zimmermann Cc: LKML , Alexandre Arnoud , Luis de Arquer References: <20240831-b4-rk3588-bridge-upstream-v5-2-9503bece0136@collabora.com> From: Cristian Ciocaltea Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240910_085239_113848_20873089 X-CRM114-Status: UNSURE ( 8.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/8/24 12:11 PM, Markus Elfring wrote: > … >> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c >> @@ -0,0 +1,708 @@ > … >> +static int dw_hdmi_qp_i2c_xfer(struct i2c_adapter *adap, >> + struct i2c_msg *msgs, int num) >> +{ > … >> + mutex_lock(&i2c->lock); > … >> + dw_hdmi_qp_mod(hdmi, 0, I2CM_OP_DONE_MASK_N | I2CM_NACK_RCVD_MASK_N, >> + MAINUNIT_1_INT_MASK_N); >> + >> + mutex_unlock(&i2c->lock); >> + >> + return ret; >> +} > … > > Under which circumstances would you become interested to apply a statement > like “guard(mutex)(&i2c->lock);”? > https://elixir.bootlin.com/linux/v6.11-rc6/source/include/linux/mutex.h#L196 Applied for the upcoming v7. Thanks, Cristian