[PATCH v2 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3 and 3S

[PATCH v2 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3 and 3S

[michael.opdenacker]

From: Michael Opdenacker <michael.opdenacker@rootcommit.com>

Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2],
which are SBCs based on the Rockchip 3566 SoC.

The "3S" version ("S" for "storage") just adds a 16 GB eMMC
and a "mask ROM" DIP switch to the "3" version.

[1] https://tinker-board.asus.com/series/tinker-board-3.html
[2] https://tinker-board.asus.com/series/tinker-board-3s.html

Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 6aceaa8acbb2..cd249325a4d9 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -86,6 +86,17 @@ properties:
           - const: asus,rk3288-tinker-s
           - const: rockchip,rk3288
 
+      - description: Asus Tinker Board 3
+        items:
+          - const: asus,rk3566-tinker-board-3
+          - const: rockchip,rk3566
+
+      - description: Asus Tinker Board 3S
+        items:
+          - const: asus,rk3566-tinker-board-3s
+          - const: asus,rk3566-tinker-board-3
+          - const: rockchip,rk3566
+
       - description: Beelink A1
         items:
           - const: azw,beelink-a1

Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3 and 3S

[Krzysztof Kozlowski]

On Fri, Nov 14, 2025 at 03:46:42PM +0000, michael.opdenacker@rootcommit.com wrote:
> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> 
> Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2],
> which are SBCs based on the Rockchip 3566 SoC.
> 
> The "3S" version ("S" for "storage") just adds a 16 GB eMMC
> and a "mask ROM" DIP switch to the "3" version.
> 
> [1] https://tinker-board.asus.com/series/tinker-board-3.html
> [2] https://tinker-board.asus.com/series/tinker-board-3s.htm

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions of patchset, under or above your Signed-off-by tag, unless
patch changed significantly (e.g. new properties added to the DT
bindings). Tag is "received", when provided in a message replied to you
on the mailing list. Tools like b4 can help here. However, there's no
need to repost patches *only* to add the tags. The upstream maintainer
will do that for tags received on the version they apply.

Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.
</form letter>

Best regards,
Krzysztof

Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3 and 3S

[Michael Opdenacker]

Hi Dragan

Oops, indeed I overlooked this message!

On 11/15/25 01:52, Dragan Simic wrote:
> Hello Michael,
>
> Thanks for the v2!  Please, see some remarks below.
>
> On Friday, November 14, 2025 16:46 CET, michael.opdenacker@rootcommit.com wrote:
>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> I'm sorry for not mentioning it in my earlier responses, but this
> line is redundant, because it duplicates the From value found in
> the actual email message.
>
>> Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2],
>> which are SBCs based on the Rockchip 3566 SoC.
>>
>> The "3S" version ("S" for "storage") just adds a 16 GB eMMC
>> and a "mask ROM" DIP switch to the "3" version.
>>
>> [1] https://tinker-board.asus.com/series/tinker-board-3.html
>> [2] https://tinker-board.asus.com/series/tinker-board-3s.html
>>
>> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>> ---
>>   Documentation/devicetree/bindings/arm/rockchip.yaml | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> index 6aceaa8acbb2..cd249325a4d9 100644
>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> @@ -86,6 +86,17 @@ properties:
>>             - const: asus,rk3288-tinker-s
>>             - const: rockchip,rk3288
>>   
>> +      - description: Asus Tinker Board 3
>> +        items:
>> +          - const: asus,rk3566-tinker-board-3
>> +          - const: rockchip,rk3566
>> +
>> +      - description: Asus Tinker Board 3S
>> +        items:
>> +          - const: asus,rk3566-tinker-board-3s
>> +          - const: asus,rk3566-tinker-board-3
>> +          - const: rockchip,rk3566
>> +
>>         - description: Beelink A1
>>           items:
>>             - const: azw,beelink-a1
> I'm sorry again for not mentioning it in my earlier responses,
> but shouldn't this addition be specified like below:
>
>       - description: Asus Tinker Board 3/3S
>         items:
>           - enum:
> 	   - asus,rk3566-tinker-board-3
>             - asus,rk3566-tinker-board-3s
>           - const: rockchip,rk3566
>
> ... because the introduced .dts files define the actual board DTs,
> by descending from the common .dtsi file, while they're compatible
> in the sense of the 3S board variant extending the 3 variant.

Indeed, that's the way it should be, looking at the rest of the 
rockchip.yaml file.

I was too hypnotized by the section for the original Tinkerboard, which 
doesn't follow this either (I'll send a separate patch).
Thanks a lot!
Cheers
Michael.

-- 
Michael Opdenacker
Root Commit
Yocto Project and OpenEmbedded Training course - Learn by doing:
https://rootcommit.com/training/yocto/

Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3 and 3S

[Michael Opdenacker]

Hi Dragan

On 11/15/25 01:52, Dragan Simic wrote:
> I'm sorry again for not mentioning it in my earlier responses,
> but shouldn't this addition be specified like below:
>
>       - description: Asus Tinker Board 3/3S
>         items:
>           - enum:
> 	   - asus,rk3566-tinker-board-3
>             - asus,rk3566-tinker-board-3s
>           - const: rockchip,rk3566
>
> ... because the introduced .dts files define the actual board DTs,
> by descending from the common .dtsi file, while they're compatible
> in the sense of the 3S board variant extending the 3 variant.

Actually, "make dtbs_check" fails if rk3566-tinker-board-3s.dts has:
compatible = "asus,rk3566-tinker-board-3s", 
"asus,rk3566-tinker-board-3", "rockchip,rk3566";

The failure is:
arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3s.dtb: / 
(asus,rk3566-tinker-board-3s): compatible: 'oneOf' conditional failed, 
one must be fixed:
     ['asus,rk3566-tinker-board-3s', 'asus,rk3566-tinker-board-3', 
'rockchip,rk3566'] is too long
     ['asus,rk3566-tinker-board-3s', 'asus,rk3566-tinker-board-3', 
'rockchip,rk3566'] is too short

If I understand correctly, to keep the rk3566-tinker-board-3s.dts file 
as it is, you need Asus Tinker Board 3 and 3S to have two different 
descriptions as in V2:

- description: Asus Tinker Board 3 items: - const: 
asus,rk3566-tinker-board-3 - const: rockchip,rk3566 - description: Asus 
Tinker Board 3S items: - const: asus,rk3566-tinker-board-3s - const: 
asus,rk3566-tinker-board-3 - const: rockchip,rk3566

The other solution is to remove the "asus,rk3566-tinker-board-3" 
compatible from rk3566-tinker-board-3s.dts, which is not a big deal in 
my opinion. In addition, if some code turns out to work only on 3 but 
not on 3S, though that's not expected if 3S is indeed a superset of 3, 
we won't be stuck.

I can submit a V3 along these lines.
Cheers
Michael.

-- 
Michael Opdenacker
Root Commit
Yocto Project and OpenEmbedded Training course - Learn by doing:
https://rootcommit.com/training/yocto/

Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3 and 3S

[Dragan Simic]

Hello Michael,

On Tuesday, November 18, 2025 06:27 CET, Michael Opdenacker <michael.opdenacker@rootcommit.com> wrote:
> On 11/15/25 01:52, Dragan Simic wrote:
> > I'm sorry again for not mentioning it in my earlier responses,
> > but shouldn't this addition be specified like below:
> >
> >       - description: Asus Tinker Board 3/3S
> >         items:
> >           - enum:
> > 	          - asus,rk3566-tinker-board-3
> >             - asus,rk3566-tinker-board-3s
> >           - const: rockchip,rk3566
> >
> > ... because the introduced .dts files define the actual board DTs,
> > by descending from the common .dtsi file, while they're compatible
> > in the sense of the 3S board variant extending the 3 variant.
> 
> Actually, "make dtbs_check" fails if rk3566-tinker-board-3s.dts has:
> compatible = "asus,rk3566-tinker-board-3s", 
> "asus,rk3566-tinker-board-3", "rockchip,rk3566";
> 
> The failure is:
> arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3s.dtb: / 
> (asus,rk3566-tinker-board-3s): compatible: 'oneOf' conditional failed, 
> one must be fixed:
>      ['asus,rk3566-tinker-board-3s', 'asus,rk3566-tinker-board-3', 
> 'rockchip,rk3566'] is too long
>      ['asus,rk3566-tinker-board-3s', 'asus,rk3566-tinker-board-3', 
> 'rockchip,rk3566'] is too short

Oh, I missed that completely, thanks for running the checks.

> If I understand correctly, to keep the rk3566-tinker-board-3s.dts file 
> as it is, you need Asus Tinker Board 3 and 3S to have two different 
> descriptions as in V2:
> 
> - description: Asus Tinker Board 3 items: - const: 
> asus,rk3566-tinker-board-3 - const: rockchip,rk3566 - description: Asus 
> Tinker Board 3S items: - const: asus,rk3566-tinker-board-3s - const: 
> asus,rk3566-tinker-board-3 - const: rockchip,rk3566
> 
> The other solution is to remove the "asus,rk3566-tinker-board-3" 
> compatible from rk3566-tinker-board-3s.dts, which is not a big deal in 
> my opinion. In addition, if some code turns out to work only on 3 but 
> not on 3S, though that's not expected if 3S is indeed a superset of 3, 
> we won't be stuck.
> 
> I can submit a V3 along these lines.

This should let us keep the "asus,rk3566-tinker-board-3" compatible
in the new rk3566-tinker-board-3s.dts board dts while satisfying the
validation properly:

  - description: Asus Tinker Board 3/3S
    items:
    - enum:
        - asus,rk3566-tinker-board-3s
    - const: asus,rk3566-tinker-board-3
    - const: rockchip,rk3566

I'm quite busy at the moment, hence my delayed response, and I also
apologize for not running the checks on the above-proposed solution,
but I think it should work as expected.

Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3 and 3S

[Michael Opdenacker]

Hi Dragan

Thanks for your reviews in busy times!

> This should let us keep the "asus,rk3566-tinker-board-3" compatible
> in the new rk3566-tinker-board-3s.dts board dts while satisfying the
> validation properly:
>
>    - description: Asus Tinker Board 3/3S
>      items:
>      - enum:
>          - asus,rk3566-tinker-board-3s
>      - const: asus,rk3566-tinker-board-3
>      - const: rockchip,rk3566
>
> I'm quite busy at the moment, hence my delayed response, and I also
> apologize for not running the checks on the above-proposed solution,
> but I think it should work as expected.

I actually already tried this, but it doesn't pass "make dtbs_check":

arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3.dtb: / 
(asus,rk3566-tinker-board-3): compatible: 'oneOf' conditional failed, 
one must be fixed:
     ['asus,rk3566-tinker-board-3', 'rockchip,rk3566'] is too short

The "enum" statement seems to mean that there is at least one of the 
items, which is not the case for rk3566-tinker-board-3.dts that doesn't 
have it.

So, my V3 seems like the way to go if we don't want to duplicate entries 
in rockchip.yaml.
Cheers
Michael.

-- 
Michael Opdenacker
Root Commit
Yocto Project and OpenEmbedded Training course - Learn by doing:
https://rootcommit.com/training/yocto/

Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3 and 3S

[Dragan Simic]

On Wednesday, November 19, 2025 08:25 CET, Michael Opdenacker <michael.opdenacker@rootcommit.com> wrote:
> > This should let us keep the "asus,rk3566-tinker-board-3" compatible
> > in the new rk3566-tinker-board-3s.dts board dts while satisfying the
> > validation properly:
> >
> >    - description: Asus Tinker Board 3/3S
> >      items:
> >      - enum:
> >          - asus,rk3566-tinker-board-3s
> >      - const: asus,rk3566-tinker-board-3
> >      - const: rockchip,rk3566
> >
> > I'm quite busy at the moment, hence my delayed response, and I also
> > apologize for not running the checks on the above-proposed solution,
> > but I think it should work as expected.
> 
> I actually already tried this, but it doesn't pass "make dtbs_check":
> 
> arch/arm64/boot/dts/rockchip/rk3566-tinker-board-3.dtb: / 
> (asus,rk3566-tinker-board-3): compatible: 'oneOf' conditional failed, 
> one must be fixed:
>      ['asus,rk3566-tinker-board-3', 'rockchip,rk3566'] is too short
> 
> The "enum" statement seems to mean that there is at least one of the 
> items, which is not the case for rk3566-tinker-board-3.dts that doesn't 
> have it.
> 
> So, my V3 seems like the way to go if we don't want to duplicate entries 
> in rockchip.yaml.

I see, thanks for the clarification.  Then the v3 is the way to go.