From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFD81C982DE for ; Sat, 19 Sep 2026 01:07:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6HewLLL8ipgY9ww2B3n9+2RGXN10iLBb3PUHWKJHjHA=; b=zrJrxjC2Q+Am9H1ILVWvj5DHeo 6+ZG/ZEX/LFUuoR0xy4ujIB3BFEB1NfIaU76rckWkATojLKJZ5rnrpXl3zPce41NvCTN2w72bQFDc cwo/0eyv8Nb/G4cMrV0d7oNJPZPC028cJd5OXQx/MEQJDYrm4BpbhZns7j8s7AxqzUno7k+KV+b3W pTUhqf9HgCzNnAWpAMBSHy4UIK+3POiCmxUf/DEccJKacd5TnT9mcY1KAPMMjaOKGPdYL4wLi+ji5 TNYZlqmqghsd/IvTgOPfnYWIJNOvPE3eapGXzH81yy8ohxgmHcHBJaTngEZ9HlM2PqOVTpBhO8vbZ Bv3dhYXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7jYV-0000000FoMJ-1Q3s; Sat, 19 Sep 2026 01:07:51 +0000 Received: from watt.d-silva.org ([119.15.109.137] helo=www.nmnhosting.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7jYR-0000000FoLl-2mEH for linux-arm-kernel@lists.infradead.org; Sat, 19 Sep 2026 01:07:49 +0000 Received: from hawking.lan (ntp.lan [10.0.1.1]) by www.nmnhosting.com (Postfix) with ESMTPSA id 551E140497; Sat, 19 Sep 2026 11:07:31 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=d-silva.org; s=2025a; t=1789780051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6HewLLL8ipgY9ww2B3n9+2RGXN10iLBb3PUHWKJHjHA=; b=JF4OYFnz5uVwSTxfHxbiXOwgyD1ltxZwUJokhs/GboS1lWV2BGfUDtEpycPy0epafOFMww /ideq4L0YJLp4kwiHDr5Sq8u/mdXbsXynYgW/l9uGHbXoguumsI/Zy5wxbEHU2gnGu0t8P MfvQTuCHWNIsYVvqooav+p2J6x6Ufi/PkdAUftABbjc5qsdFVyXzKlxGZqEWYqcy0WzFHc S8nHxBCGAWjGTjvFRAVjClB3+2W8x/mNIfuDaGCmOqNsG13X646mqz9pjl7mHdNOn5zbxq 0wHXVtCGyKQXwwok0npnNsev4zL+mdzuS49ghAOdcEnRxMsrtrkM4Pc0YrX9oQ== X-GPT-Reason: legitimate; the email is a technical discussion regarding Linux kernel patches (net-next) and contains highly specific engineering details about stmmac drivers and Allwinner H616 EMAC support; the sender identity (alastair@d-silva.org) perfectly matches the recipient mailbox (alastair@d-silva.org), indicating a personal/professional communication; the presence of a link to msgid.link is consistent with standard Linux kernel mailing list practices for patch submission; there are no indicators of phishing, urgency, or unsolicited marketing. Message-ID: Subject: Re: [PATCH net-next v3 0/3] net: stmmac: add Allwinner H616 EMAC1 support From: Alastair D'Silva To: James Hilliard , Richard Genoud , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Chevallier , Maxime Coquelin Cc: Maxime Ripard , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Date: Sat, 19 Sep 2026 11:07:31 +1000 In-Reply-To: <20260917-submit-h616-emac1-v1-v3-0-62cb8316e19b@gmail.com> References: <20260917-submit-h616-emac1-v1-v3-0-62cb8316e19b@gmail.com> Autocrypt: addr=alastair@d-silva.org; prefer-encrypt=mutual; keydata=mQINBGactvoBEADBFM2HqfQUUM4j40ZQPyYzmnM8S6zrycO0ipDDPMs7nZMzyzGzOdqfS VB/tuYvZOOKVWzJuWJ5aT/YyHx54r3L+D5hTkEG0sXPVJky3yTS9sbHEMSLBHb8TVVuhPVPuieV4g Nkqg5POMTidk8xAw50WpV++tUlewXVSciehnuCQPXhXMP7FcCh4uO8LdN7E8m7ir1LafKTFfoWPah KVT8NGG9r+ucrFcN5F+VnHxTDaI68yRPkNdtUWmp22wIX1KwDCtKFrndYO4p5Hv2hlDKomsuIIHHn muQGRwuh0xpf0nVJNF8ETZHMzxQLfo3e/HvxBFOTkwY9w7CuuQFZchbhS0I3PfmGT0+jiNcdfqjDC fPPB5uhy+DkR6wO72vuwFYUrpU2mdliDSdKEtWBHulnXMJjpBOXetfIwhI8G2dTVg59lN5i9DvJZc 7y1Sp+qfZQ4P9qpYZyQEKR4GNDOdnm6F2LW2cZkcyAU/Ii765zdDMTQMIzZNSxT/FcDd0K1voTNRl QHbQw+kmIMhzSv2JefcC9oNbE0XYzcBDNP5T3O/4itOQ90GCKQEPAbIPeBjlQif7kkyvo/H6yv4s9 duuK7zbJD9AID/+KGLkpU3p68VDB/C2ZSb9rQz3p1CJNSfsX/CPk7sPqA7RKZ4a2B0hSJ2pJCncNZ KXtMlkkm/FmewARAQABtCdBbGFzdGFpciBEJ1NpbHZhIDxhbGFzdGFpckBkLXNpbHZhLm9yZz6JAl EEEwEKADsWIQTQGemDFwqYyU/dBWv75AdnjVo60gUCZpy2+gIbAwULCQgHAgIiAgYVCgkICwIEFgI DAQIeBwIXgAAKCRD75AdnjVo60qHZEACJnLfpS71Hk8bX0CLCNJ5wgqdZD3pBHEdbv9Ux9kRlZp4a ZFwlg9ltwBjl2dZP3PLtD9xQdsdYKVippKd5a7ZZC2y81oDaHjeC9LnPYn8+ce3mGE/+gRyoNfToY N06DeUNJKSlZ9t11UIqZCgfp12u16/Yrigy8C4ihEeHXlLhNX6JkeJR5gsHXJnC7vSuMZY+Qz2R72 ZidWg+cd2WDMGop5sbTvc+55q94A7vTMlWzaix5HdbEUA3sd2U0dMBju5QodRGGhDQMcCu64TydRD MtMzzOk9ThJ036ze3HASWGOppyQmaw58k+XNzbHlr9Sc1LsFUNF7zpWXac2rzlywbyRAdFIT/TC76 hy9zOkwIo2nwA/tdIwLx1j0UZPpAMQmcDUvJqZh6sE+fv6HN0yMPr+sSYJmriMt8Z6leCEHQXOHVI SI5z5FvV3coMmHYRq6aXpfs/8SLiYgkV3B0HE/E18Y3j1OkeLYoqIH1VfzQZeCSL/S77NYvk60/MV 1HFSyqLdUR3uWZI4uZzoEcMoB0GX33uCTp2Ntc00+wSntwekCUQLCMLUb7dZrbpVuobHoWWtkiD2I uE5kAiaVwwwzM0BUwiM6VzVoKbeECz93rdsNtwoDqM0NtzoISC46H/BKVQ9mRNXDO4ThEBpJ4H2Tn mPNRYYcR0u2mNy1EJII04w== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-9 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260918_180747_883913_3D8837C0 X-CRM114-Status: GOOD ( 20.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2026-09-17 at 11:55 -0600, James Hilliard wrote: > The H616 secondary EMAC supports RMII at 10/100 Mbps and uses a > separate > system-control clock register at offset 0x34. Add its binding and a > sun8i stmmac variant using that register. A distinct compatible > without > an older fallback prevents the driver from using EMAC0's clock > register. >=20 > EMAC1 connects internally to the co-packaged AC200 or AC300 EPHY and > has > no external PHY pins. Leave PHY initialization to the PHY driver > instead > of using the H3 internal-PHY controls. The RMII-only variant does not > expose the RGMII clock-delay properties. >=20 > First move the MAC software reset from probe to the DMA reset > callback, > after PHY initialization. This lets the MAC and its MDIO bus remain > registered when the PHY driver or one of its suppliers is not ready > yet. > Keep the separate H3 MDIO-mux reset sequence unchanged. >=20 > The AC200/AC300 EPHY driver and package bindings are already in > net-next. This series separates the H616 EMAC1 MAC driver and binding > support from the earlier combined series. PWM, MFD and device-tree > enablement are being handled separately. >=20 > Signed-off-by: James Hilliard > --- > Changes in v3: > - Add a prerequisite fix moving the MAC software reset to the DMA > reset > =C2=A0 callback, after PHY initialization, so delayed module loading and > =C2=A0 deferred PHY probes do not tear down the MAC and its MDIO bus. > - Preserve the H3 MDIO-mux reset and propagate hardware-reset > failures > =C2=A0 through the normal stmmac hardware-setup error path. > - Add Alastair D'Silva to Cc and rebase onto current net-next. > - Link to v2: https://patch.msgid.link/20260915-submit-h616-emac1-v1- > v2-0-322b32e40eb9@gmail.com >=20 > Changes in v2: > - Drop EMAC1 TX/RX clock-delay property support and keep the existing > =C2=A0 RGMII-only delay descriptions unchanged, as requested by Maxime > Ripard. > - Clarify that EMAC1 connects internally to a co-packaged PHY, not an > =C2=A0 external PHY or the H3-style internal-PHY controls. > - Rebase onto current net-next. > - Link to v1: https://patch.msgid.link/20260915-submit-h616-emac1-v1- > v1-0-195de0bb1f8a@gmail.com >=20 > --- > James Hilliard (3): > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 net: stmmac: sun8i: reset the MAC after PH= Y initialization > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 dt-bindings: net: allwinner: add H616 EMAC= 1 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 net: stmmac: sun8i: add support for Allwin= ner H616 EMAC1 >=20 > =C2=A0.../bindings/net/allwinner,sun8i-a83t-emac.yaml=C2=A0=C2=A0=C2=A0 |= 13 +++++ > =C2=A0.../devicetree/bindings/net/snps,dwmac.yaml=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 |=C2=A0 2 + > =C2=A0drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c=C2=A0 | 66 > +++++++++++++--------- > =C2=A03 files changed, 55 insertions(+), 26 deletions(-) > --- > base-commit: 26ee8cd69d46a14b37ba5e512084fe80d730127a > change-id: 20260914-submit-h616-emac1-v1-143703842abb >=20 > Best regards, > --=C2=A0=20 > James Hilliard >=20 Tested-by: Alastair D'Silva Reviewed-by:=C2=A0Alastair D'Silva As a follow-up (non blocking), I would add the LED control registers I mentioned at the bottom of my test results.=20 --=20 Alastair D'Silva