> Check return value instead of is_valid_ether_addr. The latter is handled > by the former. > > Signed-off-by: Rosen Penev Acked-by: Lorenzo Bianconi > --- > drivers/net/wireless/mediatek/mt76/eeprom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/mediatek/mt76/eeprom.c b/drivers/net/wireless/mediatek/mt76/eeprom.c > index 93d91264687f..0f6ccf6ed53d 100644 > --- a/drivers/net/wireless/mediatek/mt76/eeprom.c > +++ b/drivers/net/wireless/mediatek/mt76/eeprom.c > @@ -93,7 +93,7 @@ mt76_eeprom_override(struct mt76_phy *phy) > if (err == -EPROBE_DEFER) > return err; > > - if (!is_valid_ether_addr(phy->macaddr)) { > + if (err) { > eth_random_addr(phy->macaddr); > dev_info(dev->dev, > "Invalid MAC address, using random address %pM\n", > -- > 2.54.0 >