From: Frank Li <Frank.li@nxp.com>
To: Benjamin Gaignard <benjamin.gaignard@collabora.com>
Cc: nicolas.dufresne@collabora.com, p.zabel@pengutronix.de,
mchehab@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, heiko@sntech.de,
mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com,
wens@kernel.org, jernej.skrabec@gmail.com, samuel@sholland.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-rockchip@lists.infradead.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-sunxi@lists.linux.dev, kernel@collabora.com
Subject: Re: [PATCH v3 1/2] media: verisilicon: Simplify motion vectors and rfc buffers allocation
Date: Fri, 17 Apr 2026 06:54:17 -0400 [thread overview]
Message-ID: <aeIRWW937ev_F8zF@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20260415140420.282084-2-benjamin.gaignard@collabora.com>
On Wed, Apr 15, 2026 at 04:04:19PM +0200, Benjamin Gaignard wrote:
> Until now we reserve the space needed for motion vectors and reference
> frame compression at the end of the frame buffer.
> Disentanglement mv and rfc from frame buffers by allocating
> distinct buffers for each purpose.
> That simplify the code by removing lot of offset computation.
Can you try split to more small and straight forward patches, for example
for example create patch just move hantro_h264_mv_size() to header file,
...
> +++ b/drivers/media/platform/verisilicon/hantro_hevc.c
> @@ -44,30 +44,49 @@ dma_addr_t hantro_hevc_get_ref_buf(struct hantro_ctx *ctx,
> int i;
>
> /* Find the reference buffer in already known ones */
> - for (i = 0; i < NUM_REF_PICTURES; i++) {
> + for (i = 0; i < NUM_REF_PICTURES; i++) {
> if (hevc_dec->ref_bufs_poc[i] == poc) {
> hevc_dec->ref_bufs_used |= 1 << i;
> return hevc_dec->ref_bufs[i].dma;
> }
> }
> -
> return 0;
Move this code style change to new patches.
Frank
next prev parent reply other threads:[~2026-04-17 10:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 14:04 [PATCH v3 0/2] media: verisilicon: Simplification and clean up Benjamin Gaignard
2026-04-15 14:04 ` [PATCH v3 1/2] media: verisilicon: Simplify motion vectors and rfc buffers allocation Benjamin Gaignard
2026-04-17 10:54 ` Frank Li [this message]
2026-04-15 14:04 ` [PATCH v3 2/2] media: verisilicon: Clean up messy include Benjamin Gaignard
2026-04-15 14:35 ` [PATCH v3 0/2] media: verisilicon: Simplification and clean up Benjamin Gaignard
2026-04-17 10:43 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeIRWW937ev_F8zF@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=alexandre.torgue@foss.st.com \
--cc=benjamin.gaignard@collabora.com \
--cc=festevam@gmail.com \
--cc=heiko@sntech.de \
--cc=imx@lists.linux.dev \
--cc=jernej.skrabec@gmail.com \
--cc=kernel@collabora.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=nicolas.dufresne@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=samuel@sholland.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox