From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8801F588E3 for ; Mon, 20 Apr 2026 16:03:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:In-Reply-To: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xEDfs81Jd47iepqrBF7xNRmRtmHijqCc+ulFumY0y9g=; b=elKW4z27smt9fyqVtwm2rs0hVL 9j52ZOgnYI/DiHEnVgjtt/yeR1MxPTYxk9XgLI75BamEiHc9LUIq0mWVTFOHEqyWkfo9uw2SJK4EA XK/qUJW3HAawp74amOB+SVVXlNNJLTyEarfACTv9FFpL73WHEeD6/oFeq+wJhtaZZsYiI1F3KRuql KHxkQdzpQAHl3ywM85CyVxJfa4eyXNTRHYoafkL8DFpsSdD2O6tNeHxZXso8Li1H+nti1XHdTkK6i CFNOirPSrZob5mChy7KLL0CMsMc/GNNi9qoS0ai1VL3J3X4vm22VMwhLr2w5z0Gb+Zu6n9QkCFxuh +oGcFSwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wEr5c-00000007OES-1vyW; Mon, 20 Apr 2026 16:03:12 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wEr5Z-00000007ODw-15oQ for linux-arm-kernel@lists.infradead.org; Mon, 20 Apr 2026 16:03:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776700984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xEDfs81Jd47iepqrBF7xNRmRtmHijqCc+ulFumY0y9g=; b=DZc5Bt+xs9LRdPnuoWh9iJhFXB3bcIpSXJ3Dg8d5lwrtDyTLGC0PGThZhRaf2NH3Ug3/N2 g94v30njEgbUR+jigBpAF/DKBxfVInlGvVRdj1c2PWOR1T6JWk8paZ/ZPrsmf0/HQEmp46 Dxim0kQvwLJlsFn/S9s/1Cp/G0jstYU= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-618-BMjixnUNMlCKK2Ds0Z6hPQ-1; Mon, 20 Apr 2026 12:03:03 -0400 X-MC-Unique: BMjixnUNMlCKK2Ds0Z6hPQ-1 X-Mimecast-MFC-AGG-ID: BMjixnUNMlCKK2Ds0Z6hPQ_1776700983 Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-6101726c594so1101678137.0 for ; Mon, 20 Apr 2026 09:03:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776700983; x=1777305783; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=h9/x0FxU8GBGhtJj7ey+dB7jEGAG86JGELTylQtF5nc=; b=Om9n3Ss5kkKKKcw2oA+ATagljsgw99lqQ+7zTcOX922q9v1+p+0mS/h26IBqJTDAfV OZlf4qX631fIz/GhoZZnWPYnTwV27pPL5CPe8izRGiEgZB8GqqGpL9+y2PtbjNgXihnH X7j53wB5f3m0y9ZiUOqAnU5kau+xzTSpHbHhP4SHiVsr7NL74p3uhvUyWWJYp+l05+OC RqhGYSXoY9CHWKqme6HwHwjjR+a5OY37BpBg4I4jKTjPEDisaWT23L5cVs65EOWVsA1d wFCp+4aAQ7ATgETXBHzgQn9xkWvwqbGfQ3F51PY3SbXV1/NTdzbxtjV8v90s9QudD5M9 Ls3Q== X-Forwarded-Encrypted: i=1; AFNElJ+M9fhvgPGkU+v+/Nl5SVBgkwbQSVklqVWrzzQpw0j4/+0lcq+6+r8LAiTzbTJxoPfJ/cwVJhHX9SwonaxrktNV@lists.infradead.org X-Gm-Message-State: AOJu0YzNZ7iJggfKRlbZEkTXJqXoOTEORlxIUUaWzbsiyM1Jv3j9P4Uh nk3qakp/QtbApJjxuhkFGZiZRKuhP8O5srWkU8sXInDC92EJAEQViKmxWjZgCXA0rFF7p4MCy79 q4AokmNvVrF9O26KbZuDZ9VVl9l4TQJHu3/Tu7mKCpZK1vAY1SNsk6nEGYTmkjY7/f3QAFmoUhT 4b X-Gm-Gg: AeBDiesIivuqJwVJjm+DC/QxTyheH1D+catXodocJ+cFho3p2xJ2Da+NTqYn+ahgpIn kQHLLvwLJ1ljBLVm/4ETR87ABJsOijsKF+kAeUJIyv6MkukpiucO0wR+JzeofW3TFKQuCtyUcLk k7CotFc9vI74Jnfiaz+9Txk2z20jtK8U3H9Ywl4r03cumV+oTUOLTO5jtQd3/86X3/3ttY54ItD ZDY5ai8S0C9qGWuxKoci2sm0uk/LVUgqFlqOideMRl3SgKCAdBNl3USVe5JeM1mqs/yIMLnVFu7 QaHCJoFEwjl/0v+jiC/JOv6jTDRDvgyeln4tx6EJoYw2PR9DALUDz5q+n5SdlA0D3u/vxtRhhV7 Cuodk19ULzfX+FdxSJvd5JW14pCpHqxN7IEFStKWpvOBH05QwdMP1uKePmMK0mu9ogzY= X-Received: by 2002:a05:6102:5e98:b0:602:8ccb:c993 with SMTP id ada2fe7eead31-616f89b2062mr5555889137.24.1776700982372; Mon, 20 Apr 2026 09:03:02 -0700 (PDT) X-Received: by 2002:a05:6102:5e98:b0:602:8ccb:c993 with SMTP id ada2fe7eead31-616f89b2062mr5555813137.24.1776700981596; Mon, 20 Apr 2026 09:03:01 -0700 (PDT) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8e7d5fe9638sm840199685a.1.2026.04.20.09.02.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 09:03:00 -0700 (PDT) Date: Mon, 20 Apr 2026 12:02:58 -0400 From: Brian Masney To: Sebastian Reichel , Alexey Charkov Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Michael Turquette , Stephen Boyd , Pavel Zhovner , Andy Yan , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Cristian Ciocaltea , Maxime Ripard Subject: Re: [PATCH RFC 0/4] arm64: rockchip: The hunt for exact pixel clocks on RK3576 Message-ID: References: <20260417-rk3576-dclk-v1-0-26a9d0dcb2de@flipper.net> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.3.1 (2026-03-20) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: mGzPfoZQRgeYSeH3exWafW2_o4-QPwplRA6GHKNnbKE_1776700983 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="vZqQeRlEnk8S7HaS" Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260420_090309_414852_041E2031 X-CRM114-Status: GOOD ( 62.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --vZqQeRlEnk8S7HaS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Alexey, On Sat, Apr 18, 2026 at 12:24:57AM +0200, Sebastian Reichel wrote: > On Fri, Apr 17, 2026 at 07:11:43PM +0400, Alexey Charkov wrote: > > Dear all, > > > > Need the help of the collective wisdom of the community. > > > > The problem I'm trying to solve is reliably obtaining the exact pixel > > clock for arbitrary display modes supported by the RK3576 SoC. > > > > Rockchip RK3576 has three display output processors VP0~VP2, each > > supporting different ranges of display modes, roughly as follows: > > - VP0: 4K 120Hz > > - VP1: 2.5k 60Hz > > - VP2: 1080p 60Hz > > > > Each one obviously needs a pixel clock. The required frequencies for the > > pixel clocks vary greatly depending on the display mode, and need to be > > matched within a tight tolerance, or else many displays will refuse to > > work. E.g. the preferred (maximum) display mode out of VP1 is particularly > > awkward, because it requires a pixel clock of 248.88 MHz, which cannot > > be obtained using integer dividers from its default clock source (GPLL > > at 1188 MHz), and the nearest approximation is 237.6 MHz, which is well > > outside the tolerance of e.g. DP specification, resulting in a blank > > screen on most displays by default. > > > > The clock sources are of course configurable, in particular there are muxes > > connected to each VP for selecting the source of the pixel clock: > > - Each VP can take the clock either from the (single!) HDMI PHY or from > > its dedicated dclk_vpX_src mux > > - The dclk_vpX_src mux can select the clock from a number of system PLLs > > (GPLL, CPLL, VPLL, BPLL, LPLL) > > > > While the system PLLs can be configured to output a wide range of > > frequencies, they are shared between many system components. E.g. on the > > current mainline kernel on one of my RK3576 boards I've got the following: > > GPLL: 1188 MHz, enable count 20 > > CPLL: 1000 MHz, enable count 17 > > VPLL: 594 MHz, enable count 0 (yaay!) > > BPLL, LPLL: 816 MHz, enable count 0 (but these last ones don't have > > predividers, so are less flexible) > > > > So ultimately there is exactly one free fractional PLL (VPLL) which can be > > used to generate arbitrary pixel clocks, but we have up to three consumers > > trying to drive different display modes from it (e.g. HDMI on VP0, DP on > > VP1 and MIPI DSI on VP2). We also want to be able to adjust the PLL output > > frequency on the fly to satisfy the requirements of the selected display > > mode. > > > > And this is where I'm stuck. Trying to satisfy the requirements of up to > > three consumers while changing the PLL frequency on the fly sounds like > > a poorly tractable mathematical problem (is it 3-SAT?). We can take the > > HDMI output out of the equation, because it can be driven from the HDMI > > PHY (which is capable of arbitrary rates) instead of the mux, but that > > makes the decision of which dclk source to use for a VP block dependent on > > which downstream consumer is connected to it (HDMI vs. something else). > > It becomes more messy: The HDMI PHY cannot be used as clock source > for modes exceeding 4K@60Hz. > > > Even then we somehow need two devices to cooperate in picking a PLL > > frequency that satisfies the requirements of both of them, and change to it > > without display corruption. I'm not even sure if the CCF has mechanisms > > for that?.. > > > > What follows is a brief set of patches which illustrate a partial solution > > for the case of "I just need 2.5k60Hz on VP1 via DP and don't care about > > the rest". It switches the VP1 unconditionally to use VPLL as the source > > for its dclk mux, allows changing the VPLL frequency on the fly, and also > > changes the frequency calculation logic to allow for nearest-match > > frequencies which are not necessarily rounded down. These are not meant > > to be merged as-is, as I see the following issues: > > - The flag allowing the PLL to change rate is in the clock driver, while > > the reparenting to an unused PLL is in the device tree. If these go out > > of sync, we might end up trying to change the frequency of a PLL which > > is used by other consumers (I presume that could be dangerous) > > It is a problem, see e.g. this patch from Heiko removing the flag > for an RK3588 VOP source clock: > > https://lore.kernel.org/linux-rockchip/20251008133135.3745785-1-heiko@sntech.de/ > > Also note, that there is some more general ongoing work regarding > this: > > See: https://lore.kernel.org/linux-clk/20260327-clk-scaling-v8-0-86cd0aba3c5f@redhat.com/ I'm working on the patch set above to fix the clk scaling issues. You'll have issues on clks that have CLK_SET_RATE_PARENT enabled, and there are multiple children under that parent. Patches 2 and 4 in my series has kunit tests that demonstrates the current behavior. I attached a patch to drivers/clk/rockchip/clk-pll.c that adds support for the v2 rate negotiation logic. You'll need to apply this on top my clk scaling patch set. I only compile tested this, however it should work based on the changes that I made to clk-divider.c. You'll also need to add the flag CLK_V2_RATE_NEGOTIATION to your three display clks. Otherwise, without the flag, it will just fall back to the existing behavior. Hopefully this will let you be able to use one of the PLLs that has a high enable count as the parent. Feel free to reach out to me if you have any questions or issues with my patch set. Brian --vZqQeRlEnk8S7HaS Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=0001-clk-rockchip-pll-add-support-for-v2-rate-negotiation.patch >From 66b44d756dba0152b415cc8eb8528b55c4253058 Mon Sep 17 00:00:00 2001 From: Brian Masney Date: Mon, 20 Apr 2026 11:13:53 -0400 Subject: [PATCH] clk: rockchip: pll: add support for v2 rate negotiation logic Content-type: text/plain Signed-off-by: Brian Masney --- drivers/clk/rockchip/clk-pll.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/clk/rockchip/clk-pll.c b/drivers/clk/rockchip/clk-pll.c index 6b853800cb6b..30e0722f872f 100644 --- a/drivers/clk/rockchip/clk-pll.c +++ b/drivers/clk/rockchip/clk-pll.c @@ -66,8 +66,20 @@ static int rockchip_pll_determine_rate(struct clk_hw *hw, { struct rockchip_clk_pll *pll = to_rockchip_clk_pll(hw); const struct rockchip_pll_rate_table *rate_table = pll->rate_table; + struct clk_hw *parent = req->best_parent_hw; int i; + if (parent && (clk_hw_get_flags(hw) & CLK_SET_RATE_PARENT) && + clk_has_v2_rate_negotiation(parent->core)) { + unsigned long lcm_rate; + + lcm_rate = clk_hw_get_children_lcm(parent, hw, req->rate); + if (lcm_rate > 0) { + lcm_rate = clk_hw_round_rate(parent, lcm_rate); + req->best_parent_rate = lcm_rate; + } + } + /* Assuming rate_table is in descending order */ for (i = 0; i < pll->rate_count; i++) { if (req->rate >= rate_table[i].rate) { -- 2.53.0 --vZqQeRlEnk8S7HaS--