Re: [PATCH v4 0/8] iio: stm32-adc: add support of adc for stm32mp13

Fabrice Gasnier
2022-10-14T12:54:08Z

On 10/12/22 16:21, Olivier Moysan wrote:
> On STM32MP13 SoCs, each ADC peripheral has a single ADC block.
> These ADC peripherals, ADC1 and ADC2, are fully independent.
> The STM32MP131 SoC provides only ADC2, while other STM32MP13x
> SoCs provide both ADC1 and ADC2.
>
> The STM32MP13 ADC features and characteristics are slightly
> different from STM32MP15 ADC ones, requiring a specific support
> in the driver.
>
> This patchset enables the ADC peripheral on STM32MP135F-DK board.
>
> On STM32MP135F-DK board the ADC is connected to VDDA voltage
> provided by the PMIC LOD1 supply, which has to be enabled through
> SCMI regulator framework.
> This serie introduces a fixed regulator to allow ADC probing,
> while SCMI regulators support is not available. This does
> not ensure ADC regulator enabling however.

Hi Olivier,

I've one tiny remark on PATCH 5/8, "ARM: dts: stm32: add adc support to
stm32mp13"

With that fixed, for the whole series, you can add my:

Reviewed-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>

Thanks,
Fabrice

>
> Changes in v4:
> - reformat patch 1 commit message
> - reorder adc1 node
>
> v3:
> - Remove blank line in tag block
> - Use HZ_PER_MHZ unit for max frequency definition
> - Coding style updates
>
> v2:
> - Rework commit message length
> - Add missing spaces
> - Remove useless defines
>
> Olivier Moysan (8):
> iio: adc: stm32-adc: fix channel sampling time init
> dt-bindings: iio: adc: stm32-adc: add stm32mp13 compatibles
> iio: adc: stm32-adc: add stm32mp13 support
> iio: adc: stm32: manage min sampling time on all internal channels
> ARM: dts: stm32: add adc support to stm32mp13
> ARM: dts: stm32: add adc pins muxing on stm32mp135f-dk
> ARM: dts: stm32: add dummy vdd_adc regulator on stm32mp135f-dk
> ARM: dts: stm32: add adc support on stm32mp135f-dk
>
> .../bindings/iio/adc/st,stm32-adc.yaml | 68 ++++-
> arch/arm/boot/dts/stm32mp13-pinctrl.dtsi | 7 +
> arch/arm/boot/dts/stm32mp131.dtsi | 43 +++
> arch/arm/boot/dts/stm32mp133.dtsi | 31 +++
> arch/arm/boot/dts/stm32mp135f-dk.dts | 33 +++
> drivers/iio/adc/stm32-adc-core.c | 30 ++-
> drivers/iio/adc/stm32-adc-core.h | 30 +++
> drivers/iio/adc/stm32-adc.c | 247 +++++++++++++++---
> 8 files changed, 443 insertions(+), 46 deletions(-)
>