From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8E0FC6FD1D for ; Tue, 21 Mar 2023 11:25:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yYuxOkiTHDhR24oSJ3vZMRFHqzWvtdeylie89wQJpWk=; b=jpJFepXBHkwmqb H5KN3Fo+HtOB8uLULVFv6/2HU9aNr2QGGxyFxl+2sKYVUlm1SV4nVAE6Gy4HOedHEJX2emhHqo/SE GEH2ou2QYJW8IRZ7a1aNf9p+xTzogRQlafFU/Cq75vHocNqNdlKpR7KXlJ8Oz8j1Cj1BNG2JnaxBP OpI9EbMDxul7etg9ylkLZIirqdfQU8m77wUqmNmY0iONPvxv6ddcBmNVdfGn5OorQ48W5mpcDmA5X NBKZR5cmFbWp/mwLfK33iwyn3+A+WoWZyb/42oASqtZfSrLO4WZrvsIpvAwy1gQSohp2bhoq6R44Q fYdZXJHG5UuV3ClFsgVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pea6B-00CC2x-29; Tue, 21 Mar 2023 11:24:15 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pea63-00CC0l-3C; Tue, 21 Mar 2023 11:24:12 +0000 X-UUID: e1217b90c7da11ed8687db9d93187ff1-20230321 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=Fww/5nJ3s/Mn6LOrzLIo1wn+JCkU+Ud2l29Sidq+as0=; b=VRRIX2tmRRdZPYrN2YUpo1awG7wgaNCFSwSiNdQLR4VZKl9rF/Cvk829Ux+IoF7HNRGoPfbyd0/vVkoh+KugaqHfh10NgZVRL+i2JJ1INbWGjULsiVxzvCgqGLlmoRgb+ZM1bP4IJMUFMz9/6hAW0fGfX91k4fqbHSoOh28Tj/Y=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.22,REQID:3cbb646d-d4a0-420b-a6d9-64f261479a6f,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:120426c,CLOUDID:755b76f6-ddba-41c3-91d9-10eeade8eac7,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:11|1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-UUID: e1217b90c7da11ed8687db9d93187ff1-20230321 Received: from mtkmbs13n2.mediatek.inc [(172.21.101.108)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 636748633; Tue, 21 Mar 2023 04:24:01 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by mtkmbs13n2.mediatek.inc (172.21.101.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.25; Tue, 21 Mar 2023 19:23:34 +0800 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (172.21.101.239) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server id 15.2.1118.25 via Frontend Transport; Tue, 21 Mar 2023 19:23:34 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oWCeCPHKqf73hS1/i+UmwIKyuQ4Pcfnoc9VOUcKdtFX8LmrdUOBgxX14+GerAmc9h9NnQ41pcRZYjUXjiSaKHonE/FrRc+y2UF5SZhienlqi/NhZOhkjKoPn6ixUS4xLvRDAZZWb5COzwzbZ5dgAFZW40bt4+kJM/oa/ooGQ0VrwuwkTV1bvcFgGPjVpxMGc8/zcoTfUc9psK/w8iUmFq8ZEePfJqVYrkwajjPvGQ05fpyvhp8r5HkvxKQ57/tfPq89tuvWFad7r7kdvY7xgBoVS3m5Cu/NNmJBnUM1sJyiupBIyZ+c//CjXToGvWDRMA30FM9AN6f2MUbw7qdOvmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fww/5nJ3s/Mn6LOrzLIo1wn+JCkU+Ud2l29Sidq+as0=; b=UjPNAtOTMfvxfnDPSuI3oITqMkERdk34fHfYDNeOoYhCOKHnJF/pCSDTF27ZJ9eJnokSl5KNCGOlu7x7It+Am1w6zd5/dd978MsMj2K9s08p98byzOzNZ3IzkHky7qSoGIMqEtwCf95phK8bm5BdzTFXuJ7TcMiHRfejdQ0OHo+6+K/S3AtcR+bvPOL2j7J6vLfeOAuMBPlX1ZIIQMYw6ZPk732whCQYw96Xwi9hPj9n86bAPW80eIw4EWZTIbi8jzzGDz4ZhCs7grr8mqCnna3uG9ihhUXHVHyTmJMigSB9r0E1xlMPltNLWdC58FU8yJIiNBJ0orB+ypA1kQ5ITA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fww/5nJ3s/Mn6LOrzLIo1wn+JCkU+Ud2l29Sidq+as0=; b=h54eH2CEdCQmUXHTp/mVb9zWxnrbmLBrp7UrBgCLJFwBaVUGYJwHQy/mHLCOd9NdsQRWXUG/Yplh88bJCQ8a0W7LVGYLK7UOLH3xrCfeS29K9y2Yx/3NvPLj0lnLtCqkplxO2T+YTMmv3A7EdV9hHEPG63wfjqx/qm3BpUp3gVI= Received: from TYZPR03MB7183.apcprd03.prod.outlook.com (2603:1096:400:33a::11) by TYUPR03MB7088.apcprd03.prod.outlook.com (2603:1096:400:355::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Tue, 21 Mar 2023 11:23:32 +0000 Received: from TYZPR03MB7183.apcprd03.prod.outlook.com ([fe80::a334:8b07:f1a9:99d3]) by TYZPR03MB7183.apcprd03.prod.outlook.com ([fe80::a334:8b07:f1a9:99d3%5]) with mapi id 15.20.6178.037; Tue, 21 Mar 2023 11:23:32 +0000 From: =?utf-8?B?VHplLW5hbiBXdSAo5ZCz5r6k5Y2XKQ==?= To: =?utf-8?B?Q2hlbmctSnVpIFdhbmcgKOeOi+ato+edvyk=?= , "rostedt@goodmis.org" CC: "zanussi@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-trace-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , wsd_upstream , =?utf-8?B?Qm9idWxlIENoYW5nICjlvLXlvJjnvqkp?= , "stable@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "mhiramat@kernel.org" , "matthias.bgg@gmail.com" , "angelogioacchino.delregno@collabora.com" Subject: Re: [PATCH] tracing: Fix use-after-free and double-free on last_cmd Thread-Topic: [PATCH] tracing: Fix use-after-free and double-free on last_cmd Thread-Index: AQHZWJGzSG3WGoP58UCw7mn23f1plK8A37WAgAQ+SAA= Date: Tue, 21 Mar 2023 11:23:32 +0000 Message-ID: References: <20230317053044.13828-1-cheng-jui.wang@mediatek.com> <20230318143533.1890d9bc@rorschach.local.home> In-Reply-To: <20230318143533.1890d9bc@rorschach.local.home> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR03MB7183:EE_|TYUPR03MB7088:EE_ x-ms-office365-filtering-correlation-id: 7b41798f-10b7-4ce3-0e76-08db29feb3fb x-ld-processed: a7687ede-7a6b-4ef6-bace-642f677fbe31,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: An/X4m5MF6AGzbiItbUsHkvBA3yUaYKLVGH+qhOdpDsGwC0WeGgGPPVgML7PW8JS3zsgPlZttD011Uk7B6BbLmCY2c/mErhIYzf9ErptGkh9vw1axaAzYEkw8D3dfOwrOuD3w2PccWP9AfxBubnslxJbIhtnVS0MUGM3xNDdg1LeKnX97KPFjCl/yEBYo4L+aGuWSX4/Oh8E+zs7dzlM7bg8LMCoW0Qajs2rY8KLY36FHWrMaRzzRrjs/JUtGM06bahuW5+QYsvdrLFJrgawb2vNgUy7mVpJowWAhSQf4UkfwUP/DxEIAHDqL6JVu1ljedi6NqZCtEDb/jA9hzOcar/6CPbzWD/Nv/aThDyMq8s2DSbljS7nJRt3nk6o4trf/wZRnpJoVKRKQBkxeRueJlCU+jS68NbyvQQ3SNaocWC58JWOOn7mbF6IDuMNH31fXFNNt/R2vyl6yRdZiakcCFF4u9ErgmsaWM2Df7JQxOeUUBAcpd/Ks0yDTkz+xSvVZOJoQr0uFUQkEJet5yu+/wwO1uqE63igkbjaN8G2A3Qscb02FjY4d1gwm9+v+DbHa6MzxBP5fznsh4YkNBMnvPOrzb4xEIq5ESirc06bV+snTa5YWbUcd330NlFnPTyZ82gBNa+7BOgL29JI3jK5rpF7H00HV8QzwKjMndWm2bhghbDEr5RPURiypVfFOIn0 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYZPR03MB7183.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(376002)(136003)(366004)(346002)(39860400002)(451199018)(54906003)(110136005)(5660300002)(316002)(86362001)(6486002)(2616005)(83380400001)(38100700002)(38070700005)(122000001)(71200400001)(85182001)(966005)(478600001)(6506007)(6512007)(36756003)(186003)(26005)(2906002)(4326008)(8936002)(7416002)(41300700001)(8676002)(91956017)(66556008)(66476007)(66446008)(66946007)(76116006)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WWJzWU43d2pUcGhGQVJSMTFkaDZnUlJObUJoc2VuTnA4ZU4vTmdacTJ4NWhQ?= =?utf-8?B?WkpuTzNYRFJpTTZhRldTOUFuZUZpMjhob1VrZnBlVkZSN2QxQkdIOC9ieTRT?= =?utf-8?B?SGxTQ1grYmRwcWJ6RFJkODNsWmpWL0JKMTM2YkxyWUY5SStJa2MzcGFaZ21k?= =?utf-8?B?bUMvUXlld2lmaHVGaU5kSnhMb3BoSnBsNEh4OTVkLzFQdFRPNGh6QkJjSXBr?= =?utf-8?B?b205MHBqc0RwSUxaSW8yTGhzMWdLUWNmNG1YYi92MmRsN29CcmJ1bXRhcmM1?= =?utf-8?B?UHJHZzVqSGdta1pyaW1HNkdTektoS0hQV055NXhsKzU5SGRudzFrQlpZbXV3?= =?utf-8?B?VDQxcGw3a2NzdFRNZEdTNUJ4cjgxa2x1Q0pXYUVEOFhQZVR5SWVBU25rT3hV?= =?utf-8?B?dGxEUHg5eWpqOVlpaU1mbXgvV2srL1FjRHNZL3NrazRJelJiQS9kZ3dyODJR?= =?utf-8?B?R2Z0T2tiLzlWZTVPdzIvVVRMR28xVFRtbnRqSjNvcU9SN1hIMWEvd0tKaE90?= =?utf-8?B?R2dkZURqUjdDOWdIOTVvMEl1eHQvOW43cG4xdkVIbFZOdE5US3NYTEltL2th?= =?utf-8?B?eVpNSHc2NlR2YzRLeXNiQkw1cm55QnBQN3JGcFdnUStiMi9NRm5Ic3FMZkxK?= =?utf-8?B?OUMwK0VWUytUTEovOFhDK2ljUUQySTNYR3ZqbVhnQzV6Q0pVcmRTQTN6ZWxP?= =?utf-8?B?RUkxU3Mvd0JjVm9BSDVzQTc1WS96ZWRqNWFvMWZBTkJpNkhpWDU3SHI5N0FK?= =?utf-8?B?V05ENzhRTElBTUhSZGNVR2w5SXhOOTFyTmR1KzJsYUdvWUw1UGVPYkU4ZlRE?= =?utf-8?B?OWhGWHM2NENmUWVabHJmN1JkdlluSW5kM1ZZbmpvY3dOZ3hSalM1cTNJc1lw?= =?utf-8?B?blViNXlVR25GTkRBdnJjZGw5T2dhajZyNXhBdGVkV29HWEltVDNMT21icG55?= =?utf-8?B?dzRMSjBqZ2tFSjMrN0ZDc3NlQXYxY29WdkNoc3h2Mjg2K043YkRUVDY5MHZC?= =?utf-8?B?N1FLZVY5Tk9FcW12RkxmbGNPaEJ2NzFPWE5ISmdtV2JYeG4yNGFJUDJQNXNv?= =?utf-8?B?NndFSlBrbFA3SGJJZFEyMEVXVm9XaVAxTXlDTmJ5YlA1K1dLODNpNFd6NW9F?= =?utf-8?B?K0VvSFhsY1Fpc1d4eGJvOG1UREFEdlUwZGhzUFBMWTRtWXkrRDQ2Rjd3QXpr?= =?utf-8?B?MG80WkRZQzJ3YTNoYUk5UFU1TVg3bFBYYVNhVnNBTzVTZGlxK29YdlBuR0J3?= =?utf-8?B?SndLaWhjZFlPQ0VZUXh5YnlOZUMyeFlEeno1bmxuOTFZNloxUk9zWXkxdENY?= =?utf-8?B?Y3FwTnJRR3dvNHBGS292bUVMWHYySFRtQW1EYms2RVRTaXZVOFZKWnh2T2sr?= =?utf-8?B?RWxUbFZyc3BFNGhoSTFYaVdzeTlBeDFpUzJoQkR6T0tLWTg1TWJOUXd4UlpV?= =?utf-8?B?UUI3YndGbktmNFg1RHk5dG1HcmlkN3ZSQzJKZlBWV1RlWTFqTVNYOUhCbkxu?= =?utf-8?B?T1d1ekRsY0lwS2pPY2FtZ0NtNzlubXBMK3h2OHM1aEo1ejArd0srRW8vbnh5?= =?utf-8?B?TTdNWDNxQ1dobTRVdXI2dkZDd2JRNlRBaWNqdHZlZy9TbnJuTS8vOVdYT0tI?= =?utf-8?B?M0lTTTlHUllGMzI3cWdQSkdXMmc2UG0xaCszYVhMV2NSZGQzUGdtdWhPeDY0?= =?utf-8?B?N2sxT3lwRURoWlpRYjhNcHByNDZUc3JDamYvdFI0aG9laUhLOUQwKzdzRWFs?= =?utf-8?B?R1pMUGxlWjUycmZWeC9qMlhrblVDSEtCc3NWclBSMWg4ZEE3MmFWZksxM2Zt?= =?utf-8?B?OWprOXFJK3JlbnFMOTkxNS8zdWxxMzF1dERmbThIbzFuNkN3YnRIM1EvU011?= =?utf-8?B?Z0FjSlNjTDA4dzBXSWhXV1pmR2NPUklRcC9mMGEzaUdwNXl6QmdkRUNwM2VH?= =?utf-8?B?NHB5QUs1SGkyQWZLdm9kSC9CeDlhT21sM1RndGZxL1FsbVEwdFh1MHNHL1k1?= =?utf-8?B?RzhGczFydDBQTzVkdWcwWEI1Q3FrallOZ0E1MzhXZVpvUnpQTjQ5Nm9CYmFX?= =?utf-8?B?czVmVnEvK3hkMVErMk5lc0E1ZlMvSE51VjJzYmgwcDFYTTN0MlNYcGZjOGZT?= =?utf-8?B?UUp5SjNFbzVnSWUweHZaczFBMmlka2Zab3d5ak0xY0VScXNoYUhodEpZTjFF?= =?utf-8?B?SFE9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB7183.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b41798f-10b7-4ce3-0e76-08db29feb3fb X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2023 11:23:32.0902 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oeXbrZQfUxY5dMY2AuZz9332UJRRfFwGmrRdLdJCPN8x1VAwSAm6CfdDOoqvc0vIhFqQidKMQ0TqzTaNClDdNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR03MB7088 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230321_042408_249196_6A4B4283 X-CRM114-Status: GOOD ( 26.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 2023-03-18 at 14:35 -0400, Steven Rostedt wrote: > On Fri, 17 Mar 2023 13:30:44 +0800 > Cheng-Jui Wang wrote: > > > From: "Tze-nan Wu" > > Hi! > > Thanks for the report and the patch. Some nits below. > > Also change the subject to: > > tracing/synthetic: Fix races on freeing last_cmd > > > --- > > kernel/trace/trace_events_synth.c | 23 +++++++++++++++++++---- > > 1 file changed, 19 insertions(+), 4 deletions(-) > > > > diff --git a/kernel/trace/trace_events_synth.c > > b/kernel/trace/trace_events_synth.c > > index 46d0abb32d0f..ce438eccab2e 100644 > > --- a/kernel/trace/trace_events_synth.c > > +++ b/kernel/trace/trace_events_synth.c > > @@ -42,16 +42,25 @@ enum { ERRORS }; > > #undef C > > #define C(a, b) b > > > > +static DEFINE_MUTEX(lastcmd_mutex); > > + > > static const char *err_text[] = { ERRORS }; > > > > static char *last_cmd; > > Please keep the mutex and the variable it protects next to each > other: > > static DEFINE_MUTEX(lastcmd_mutex); > static char *last_cmd; > > > > > static int errpos(const char *str) > > { > > - if (!str || !last_cmd) > > - return 0; > > + int ret = 0; > > + > > + mutex_lock(&lastcmd_mutex); > > + if (!str || !last_cmd) { > > Change this to just: > > if (!str || !last_cmd) > goto out; > > > + mutex_unlock(&lastcmd_mutex); > > + return ret; > > + } > > > > - return err_pos(last_cmd, str); > > + ret = err_pos(last_cmd, str); > > Add: > > out: > > > + mutex_unlock(&lastcmd_mutex); > > + return ret; > > } > > > > static void last_cmd_set(const char *str) > > @@ -59,18 +68,24 @@ static void last_cmd_set(const char *str) > > if (!str) > > return; > > > > + mutex_lock(&lastcmd_mutex); > > kfree(last_cmd); > > > > In this case, you can remove the space: > > mutex_lock(&lastcmd_mutex); > kfree(last_cmd); > last_cmd = kstrdup(str, GFP_KERNEL); > mutex_unlock(&lastcmd_mutex); > > > last_cmd = kstrdup(str, GFP_KERNEL); > > + mutex_unlock(&lastcmd_mutex); > > } > > > > static void synth_err(u8 err_type, u16 err_pos) > > { > > - if (!last_cmd) > > + mutex_lock(&lastcmd_mutex); > > + if (!last_cmd) { > > This should be: > > if (!last_cmd) > goto out; > > > + mutex_unlock(&lastcmd_mutex); > > return; > > + } > > > > tracing_log_err(NULL, "synthetic_events", last_cmd, err_text, > > err_type, err_pos); > > out: > > > + mutex_unlock(&lastcmd_mutex); > > } > > > > static int create_synth_event(const char *raw_command); > > Thanks, > > -- Steve Hi Steve, Thanks for the comments, the new patch with cleaner code is now ready. Since the topic has been changed, I created a new thread for the new patch: https://lore.kernel.org/lkml/20230321110444.1587-1-Tze-nan.Wu@mediatek.com/ -- Tze-nan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel